Re: [PATCH v7 1/2] dt-bindings: iio: adc: ti,ads112c04: Add binding for ADS112C04

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `excitation-current-nanoamp` and `burn-out-current-nanoamp` properties are incorrectly constrained as scalars, causing dt-schema validation failures when configuring multiple channels.
--

--- Patch [1]: [PATCH v7 1/2] dt-bindings: iio: adc: ti,ads112c04: Add binding for ADS112C04 ---
commit da6d59f78ea6520db9adcaf85a4a8583112226d0
Author: Kyle Hsieh <kylehsieh1995@gmail.com>

dt-bindings: iio: adc: ti,ads112c04: Add binding for ADS112C04

This commit adds device tree binding documentation for the Texas Instruments
ADS112C04 I2C Analog-to-Digital Converters. The binding uses child nodes
to dynamically define connected channels and includes properties to describe
hardware capabilities.

> diff --git a/Documentation/devicetree/bindings/iio/adc/ti,ads112c04.yaml b/Documentation/devicetree/bindings/iio/adc/ti,ads112c04.yaml
> new file mode 100644
> index 0000000000000..95a123cd7b67c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/ti,ads112c04.yaml
[ ... ]
> +patternProperties:
> +  "^channel@[0-9a-b]$":
> +    $ref: adc.yaml
> +    unevaluatedProperties: false
> +    properties:
[ ... ]
> +      excitation-current-nanoamp:
> +        enum: [10000, 50000, 100000, 250000, 500000, 1000000, 1500000]
> +
> +      burn-out-current-nanoamp:
> +        const: 10000

[Severity: Low]
Will dt-schema validation fail here if a device tree specifies multiple values
for these properties (e.g., excitation-current-nanoamp = <500000 500000>;)?

Due to the standard -nanoamp suffix defined in property-units.yaml, dt-schema
treats these properties as arrays. Applying the enum and const constraints
directly to the property instead of using items (e.g., items: enum: [...])
applies the scalar constraint to the entire array, which triggers a validation
failure.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260824-ti-ads112c04-driver-v7-0-6b3c9c87d0e4@gmail.com?part=1