From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2D214C5DF94 for ; Mon, 24 Aug 2026 11:40:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yFSr5QCpdJiqsuMoaB3z1z9aPIMQ8vzFcL4Rq0VWGMc=; b=IM6jAJTzI3wvQ+ BcPFuAsWLZTG27ByOkGzTH0UZl1iK++Zbq1lOIRZCWcFUESRlrQ/LtEcuwt115wVhURBN/ywj8gWb EBP+pqhfHUlC65WZO3THKx8+kTj4mxneR6jlFSVLJ7QWrUTgWxhDokB0WDl2PGB7fvZN89fPQ7Uq8 GQrb+7ALggBtBLLR+gHHonQQ1KSDB2+GmNCjnx9uPeUXiOsnq3dRd5rt3HClSj7L7vToLRtQHrAxA sPcMDNGqIHQWTLuCKpGOclcSRNhQ2MVohIpqjf02OHncyICRndaVTUJwIp233Lgwo9MCjjZLKl7X0 gN282Q9Ce77CC+Oe+3RA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wyT2l-0000000GX02-3NjI; Mon, 24 Aug 2026 11:40:47 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wyT2k-0000000GWzS-1i4q for linux-phy@lists.infradead.org; Mon, 24 Aug 2026 11:40:46 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 0A3A4412CB; Mon, 24 Aug 2026 11:40:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ADA021F000E9; Mon, 24 Aug 2026 11:40:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787571645; bh=abkoSPlNA/2tyVeA4AK9TVBNqiexJLdZyqZaGlsFMd4=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=fGo38EkgtEBMKaMMRmyjYXXKyT1wp7m6EvCipnJiQP2F+QXH1zHna86JCEhJzUA7e YIkAkQspl/Z+sOMWDPv4rXL4pdZ+A91qMKBuTeDVuKU00RMdg9YP1d6Q50Ptw10K0b R7+4MLG4gaButR6siAWB0O+dz53nxvLxBPnPAs38dvMdYvvy+a/vbYPSpZdzVYg0hy 3w6vQ4hjAg11/Bb+XZ+87RNl/Yd+PhdJtEXGcoaiIOOFrDtIHP54WUk2NuP4r/W5GH ZlNSOUiGXlPoabqGNj3nP0ZCyUHRQQXpqGg3sYTU/REcCBO5W9Rf5g4DrJ8bHTy7D5 16FsAaSO1+JGA== From: sashiko-bot@kernel.org Subject: Re: [PATCH 2/4] drm/msm/dp: clear force_link_train flag when link training succeeds To: "Saurabh Anand" Cc: vkoul@kernel.org, olteanv@gmail.com, dri-devel@lists.freedesktop.org, neil.armstrong@linaro.org, linux-phy@lists.infradead.org In-Reply-To: <20260824-qcom-dp-typec-reconnect-fixes-v1-2-2825e5bf8a96@oss.qualcomm.com> References: <20260824-qcom-dp-typec-reconnect-fixes-v1-0-2825e5bf8a96@oss.qualcomm.com> <20260824-qcom-dp-typec-reconnect-fixes-v1-2-2825e5bf8a96@oss.qualcomm.com> Date: Mon, 24 Aug 2026 11:40:45 +0000 Message-Id: <20260824114045.ADA021F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MyBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6CgpOZXcgaXNzdWVzOgotIFtMb3ddIERl YWQgc3RvcmUgb2YgYGZvcmNlX2xpbmtfdHJhaW5gIGludHJvZHVjZWQgYnkgdGhlIHBhdGNoLgoK UHJlLWV4aXN0aW5nIGlzc3VlczoKLSBbSGlnaF0gRmFpbHVyZSBpbiBgcG1fcnVudGltZV9yZXN1 bWVfYW5kX2dldCgpYCBsZWFkcyB0byBhIFBNIHJ1bnRpbWUgdXNhZ2UgY291bnQgdW5kZXJmbG93 LgotIFtIaWdoXSBVbmluaXRpYWxpemVkIHN0YWNrIG1lbW9yeSByZWFkIGluIGBtc21fZHBfY3Ry bF9jaGFubmVsX2VxX29rKClgLgotLQoKLS0tIFBhdGNoIFsyXTogW1BBVENIIDIvNF0gZHJtL21z bS9kcDogY2xlYXIgZm9yY2VfbGlua190cmFpbiBmbGFnIHdoZW4gbGluayB0cmFpbmluZyBzdWNj ZWVkcyAtLS0KY29tbWl0IDAzYTY3OTM3Y2UwOWY3YmM0MjhjNWM5YzE4NTAzNzQ1ZTQxYzYyZjYK QXV0aG9yOiBTYXVyYWJoIEFuYW5kIDxzYXVyYWJoLmFuYW5kQG9zcy5xdWFsY29tbS5jb20+Cgpk cm0vbXNtL2RwOiBjbGVhciBmb3JjZV9saW5rX3RyYWluIGZsYWcgd2hlbiBsaW5rIHRyYWluaW5n IHN1Y2NlZWRzCgptc21fZHBfZGlzcGxheV9wcmVwYXJlX2xpbmsoKSBzZXRzIGZvcmNlX2xpbmtf dHJhaW4gPSB0cnVlIGJlZm9yZSBjYWxsaW5nCm1zbV9kcF9jdHJsX29uX2xpbmsoKS4gT24gc3Vj Y2VzcyB0aGUgZmxhZyB3YXMgbmV2ZXIgY2xlYXJlZCwgc28KbXNtX2RwX2N0cmxfcHJlcGFyZV9z dHJlYW1fb24oKSB3b3VsZCB1bmNvbmRpdGlvbmFsbHkgdHJpZ2dlciBhIHNlY29uZApsaW5rIHJl dHJhaW4gZXZlbiB0aG91Z2ggdGhlIGxpbmsgd2FzIGFscmVhZHkgdHJhaW5lZC4gQ2xlYXIKZm9y Y2VfbGlua190cmFpbiBvbiB0aGUgc3VjY2VzcyBwYXRoIHNvIHRoYXQKbXNtX2RwX2N0cmxfcHJl cGFyZV9zdHJlYW1fb24oKSBvbmx5IHJldHJhaW5zIHdoZW4gdGhlIGNoYW5uZWwgRVEgY2hlY2sK ZmFpbHMsIGFzIGludGVuZGVkLgoKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL21zbS9k cC9kcF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vbXNtL2RwL2RwX2Rpc3BsYXkuYwo+IGlu ZGV4IGJjNjQ2ZDE3MmFiZTAuLjQwZTE5ZDUwNmE0NTAgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL21zbS9kcC9kcF9kaXNwbGF5LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rw L2RwX2Rpc3BsYXkuYwo+IEBAIC02NDksNiArNjQ5LDggQEAgc3RhdGljIGludCBtc21fZHBfZGlz cGxheV9wcmVwYXJlX2xpbmsoc3RydWN0IG1zbV9kcF9kaXNwbGF5X3ByaXZhdGUgKmRwKQoKW1Nl dmVyaXR5OiBIaWdoXQpUaGlzIGlzbid0IGEgYnVnIGludHJvZHVjZWQgYnkgdGhpcyBwYXRjaCwg YnV0IGRvZXMgdGhlIHBtX3J1bnRpbWUgZXJyb3IKaGFuZGxpbmcgY2F1c2UgYSB1c2FnZSBjb3Vu dCB1bmRlcmZsb3c/CgpJZiBwbV9ydW50aW1lX3Jlc3VtZV9hbmRfZ2V0KCkgZmFpbHMgZWFybGll ciBpbiBtc21fZHBfZGlzcGxheV9wcmVwYXJlX2xpbmsoKSwKaXQgcmV0dXJucyBhbiBlcnJvciB3 aXRob3V0IGFjcXVpcmluZyBhIFBNIHJ1bnRpbWUgcmVmZXJlbmNlOgoKCXJjID0gcG1fcnVudGlt ZV9yZXN1bWVfYW5kX2dldCgmbXNtX2RwX2Rpc3BsYXktPnBkZXYtPmRldik7CglpZiAocmMpIHsK CQlEUk1fRVJST1IoImZhaWxlZCB0byBwbV9ydW50aW1lX3Jlc3VtZVxuIik7CgkJcmV0dXJuIHJj OwoJfQoKU2luY2UgdGhlIERSTSBjb3JlIGF0b21pY19lbmFibGUgY2FsbGJhY2sgcmV0dXJucyB2 b2lkLCB0aGUgZnJhbWV3b3JrCmNvbnNpZGVycyB0aGUgZGV2aWNlIGVuYWJsZWQgYW5kIHdpbGwg bGF0ZXIgY2FsbCB0aGUgYXRvbWljX3Bvc3RfZGlzYWJsZQpob29rLiBUaGlzIHJvdXRlcyB0byBt c21fZHBfZGlzcGxheV91bnByZXBhcmUoKSwgd2hpY2ggdW5jb25kaXRpb25hbGx5CmRyb3BzIHRo ZSByZWZlcmVuY2U6CgoJcG1fcnVudGltZV9wdXRfc3luYygmbXNtX2RwX2Rpc3BsYXktPnBkZXYt PmRldik7CgpXaWxsIHRoaXMgZHJvcCBhIHJlZmVyZW5jZSB0aGF0IHdhcyBuZXZlciBhY3F1aXJl ZCBhbmQgbGVhZCB0byBwb3NzaWJsZQpkZXZpY2UgbG9ja3Vwcz8KCj4gIAkJcmV0dXJuIHJjOwo+ ICAJfQo+ICAKPiArCWZvcmNlX2xpbmtfdHJhaW4gPSBmYWxzZTsKPiArCgpbU2V2ZXJpdHk6IExv d10KRG9lcyB0aGlzIHVuY29uZGl0aW9uYWxseSBvdmVyd3JpdGUgdGhlIHByZXZpb3VzIGFzc2ln bm1lbnQ/CgpFYXJsaWVyIGluIG1zbV9kcF9kaXNwbGF5X3ByZXBhcmVfbGluaygpLCBmb3JjZV9s aW5rX3RyYWluIGlzIHNldCB0byB0cnVlOgoKCWlmICghbXNtX2RwX2Rpc3BsYXktPnBvd2VyX29u KSB7CgkJbXNtX2RwX2Rpc3BsYXlfaG9zdF9waHlfaW5pdChkcCk7CgkJZm9yY2VfbGlua190cmFp biA9IHRydWU7CgkJZHAtPmN0cmwtPnBsdWdnZWQgPSBkcC0+cGx1Z2dlZDsKCX0KCkJ5IHNldHRp bmcgaXQgdG8gZmFsc2UgaGVyZSB1bmNvbmRpdGlvbmFsbHksIGRvZXMgdGhlIHByaW9yIGFzc2ln bm1lbnQgYmVjb21lCmRlYWQgY29kZT8gQ291bGQgdGhpcyBwYXJhbWV0ZXIganVzdCBiZSByZW1v dmVkIG9yIHBhc3NlZCBhcyBmYWxzZSBkaXJlY3RseT8KCj4gIAlyZXR1cm4gbXNtX2RwX2N0cmxf cHJlcGFyZV9zdHJlYW1fb24oZHAtPmN0cmwsIGRwLT5wYW5lbCwgZm9yY2VfbGlua190cmFpbik7 CgpbU2V2ZXJpdHk6IEhpZ2hdClRoaXMgaXMgYSBwcmUtZXhpc3RpbmcgaXNzdWUsIGJ1dCBieSBj bGVhcmluZyBmb3JjZV9saW5rX3RyYWluIG9uIHRoZQpzdWNjZXNzIHBhdGggaGVyZSwgdGhpcyBw YXRjaCBtYWtlcyBtc21fZHBfY3RybF9wcmVwYXJlX3N0cmVhbV9vbigpIGV2YWx1YXRlCnRoZSBj aGFubmVsIEVRIGNoZWNrLiBEb2VzIHRoaXMgbGVhZCB0byBhbiB1bmluaXRpYWxpemVkIHN0YWNr IG1lbW9yeSByZWFkPwoKV2hlbiBmb3JjZV9saW5rX3RyYWluIGlzIGZhbHNlLCBpdCBldmVudHVh bGx5IGNhbGxzCm1zbV9kcF9jdHJsX2NoYW5uZWxfZXFfb2soKSB3aGljaCBwYXNzZXMgYW4gdW5p bml0aWFsaXplZCBzdGFjayBidWZmZXIgdG8KZHJtX2RwX2RwY2RfcmVhZF9saW5rX3N0YXR1cygp OgoKCXU4IGxpbmtfc3RhdHVzW0RQX0xJTktfU1RBVFVTX1NJWkVdOwoJLi4uCglkcm1fZHBfZHBj ZF9yZWFkX2xpbmtfc3RhdHVzKGN0cmwtPmF1eCwgbGlua19zdGF0dXMpOwoJcmV0dXJuIGRybV9k cF9jaGFubmVsX2VxX29rKGxpbmtfc3RhdHVzLCBudW1fbGFuZXMpOwoKSWYgZHJtX2RwX2RwY2Rf cmVhZF9saW5rX3N0YXR1cygpIGZhaWxzIChlLmcuLCBpZiB0aGUgQVVYIGNoYW5uZWwgZmFpbHMp LCBpdApyZXR1cm5zIGFuIGVycm9yIHdpdGhvdXQgaW5pdGlhbGl6aW5nIHRoZSBidWZmZXIuIEl0 cyByZXR1cm4gdmFsdWUgaXMgaWdub3JlZCwKYW5kIHRoZSB1bmluaXRpYWxpemVkIHN0YWNrIGJ1 ZmZlciBpcyB0aGVuIHJlYWQgYnkgZHJtX2RwX2NoYW5uZWxfZXFfb2soKSwKd2hpY2ggbWlnaHQg Y2F1c2UgdW5wcmVkaWN0YWJsZSBiZWhhdmlvciBkZXBlbmRpbmcgb24gc3RhY2sgZ2FyYmFnZS4K CkNhbiB3ZSBjaGVjayB0aGUgcmV0dXJuIHZhbHVlIG9mIGRybV9kcF9kcGNkX3JlYWRfbGlua19z dGF0dXMoKSBiZWZvcmUgdXNpbmcKdGhlIGJ1ZmZlcj8KCj4gIH0KCi0tIApTYXNoaWtvIEFJIHJl dmlldyDCtyBodHRwczovL3Nhc2hpa28uZGV2LyMvcGF0Y2hzZXQvMjAyNjA4MjQtcWNvbS1kcC10 eXBlYy1yZWNvbm5lY3QtZml4ZXMtdjEtMC0yODI1ZTViZjhhOTZAb3NzLnF1YWxjb21tLmNvbT9w YXJ0PTIKCi0tIApsaW51eC1waHkgbWFpbGluZyBsaXN0CmxpbnV4LXBoeUBsaXN0cy5pbmZyYWRl YWQub3JnCmh0dHBzOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4 LXBoeQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4BA9DC61CE2 for ; Mon, 24 Aug 2026 11:40:48 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A395D10E756; Mon, 24 Aug 2026 11:40:47 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="fGo38Ekg"; dkim-atps=neutral Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 63FE610E756 for ; Mon, 24 Aug 2026 11:40:46 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 0A3A4412CB; Mon, 24 Aug 2026 11:40:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ADA021F000E9; Mon, 24 Aug 2026 11:40:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787571645; bh=abkoSPlNA/2tyVeA4AK9TVBNqiexJLdZyqZaGlsFMd4=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=fGo38EkgtEBMKaMMRmyjYXXKyT1wp7m6EvCipnJiQP2F+QXH1zHna86JCEhJzUA7e YIkAkQspl/Z+sOMWDPv4rXL4pdZ+A91qMKBuTeDVuKU00RMdg9YP1d6Q50Ptw10K0b R7+4MLG4gaButR6siAWB0O+dz53nxvLxBPnPAs38dvMdYvvy+a/vbYPSpZdzVYg0hy 3w6vQ4hjAg11/Bb+XZ+87RNl/Yd+PhdJtEXGcoaiIOOFrDtIHP54WUk2NuP4r/W5GH ZlNSOUiGXlPoabqGNj3nP0ZCyUHRQQXpqGg3sYTU/REcCBO5W9Rf5g4DrJ8bHTy7D5 16FsAaSO1+JGA== From: sashiko-bot@kernel.org Subject: Re: [PATCH 2/4] drm/msm/dp: clear force_link_train flag when link training succeeds To: "Saurabh Anand" Cc: vkoul@kernel.org, olteanv@gmail.com, dri-devel@lists.freedesktop.org, neil.armstrong@linaro.org, linux-phy@lists.infradead.org In-Reply-To: <20260824-qcom-dp-typec-reconnect-fixes-v1-2-2825e5bf8a96@oss.qualcomm.com> References: <20260824-qcom-dp-typec-reconnect-fixes-v1-0-2825e5bf8a96@oss.qualcomm.com> <20260824-qcom-dp-typec-reconnect-fixes-v1-2-2825e5bf8a96@oss.qualcomm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 24 Aug 2026 11:40:45 +0000 Message-Id: <20260824114045.ADA021F000E9@smtp.kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Thank you for your contribution! Sashiko AI review found 3 potential issue(= s) to consider: New issues: - [Low] Dead store of `force_link_train` introduced by the patch. Pre-existing issues: - [High] Failure in `pm_runtime_resume_and_get()` leads to a PM runtime usa= ge count underflow. - [High] Uninitialized stack memory read in `msm_dp_ctrl_channel_eq_ok()`. -- --- Patch [2]: [PATCH 2/4] drm/msm/dp: clear force_link_train flag when lin= k training succeeds --- commit 03a67937ce09f7bc428c5c9c18503745e41c62f6 Author: Saurabh Anand drm/msm/dp: clear force_link_train flag when link training succeeds msm_dp_display_prepare_link() sets force_link_train =3D true before calling msm_dp_ctrl_on_link(). On success the flag was never cleared, so msm_dp_ctrl_prepare_stream_on() would unconditionally trigger a second link retrain even though the link was already trained. Clear force_link_train on the success path so that msm_dp_ctrl_prepare_stream_on() only retrains when the channel EQ check fails, as intended. > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp= /dp_display.c > index bc646d172abe0..40e19d506a450 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -649,6 +649,8 @@ static int msm_dp_display_prepare_link(struct msm_dp_= display_private *dp) [Severity: High] This isn't a bug introduced by this patch, but does the pm_runtime error handling cause a usage count underflow? If pm_runtime_resume_and_get() fails earlier in msm_dp_display_prepare_link= (), it returns an error without acquiring a PM runtime reference: rc =3D pm_runtime_resume_and_get(&msm_dp_display->pdev->dev); if (rc) { DRM_ERROR("failed to pm_runtime_resume\n"); return rc; } Since the DRM core atomic_enable callback returns void, the framework considers the device enabled and will later call the atomic_post_disable hook. This routes to msm_dp_display_unprepare(), which unconditionally drops the reference: pm_runtime_put_sync(&msm_dp_display->pdev->dev); Will this drop a reference that was never acquired and lead to possible device lockups? > return rc; > } > =20 > + force_link_train =3D false; > + [Severity: Low] Does this unconditionally overwrite the previous assignment? Earlier in msm_dp_display_prepare_link(), force_link_train is set to true: if (!msm_dp_display->power_on) { msm_dp_display_host_phy_init(dp); force_link_train =3D true; dp->ctrl->plugged =3D dp->plugged; } By setting it to false here unconditionally, does the prior assignment beco= me dead code? Could this parameter just be removed or passed as false directly? > return msm_dp_ctrl_prepare_stream_on(dp->ctrl, dp->panel, force_link_tr= ain); [Severity: High] This is a pre-existing issue, but by clearing force_link_train on the success path here, this patch makes msm_dp_ctrl_prepare_stream_on() evaluate the channel EQ check. Does this lead to an uninitialized stack memory read? When force_link_train is false, it eventually calls msm_dp_ctrl_channel_eq_ok() which passes an uninitialized stack buffer to drm_dp_dpcd_read_link_status(): u8 link_status[DP_LINK_STATUS_SIZE]; ... drm_dp_dpcd_read_link_status(ctrl->aux, link_status); return drm_dp_channel_eq_ok(link_status, num_lanes); If drm_dp_dpcd_read_link_status() fails (e.g., if the AUX channel fails), it returns an error without initializing the buffer. Its return value is ignor= ed, and the uninitialized stack buffer is then read by drm_dp_channel_eq_ok(), which might cause unpredictable behavior depending on stack garbage. Can we check the return value of drm_dp_dpcd_read_link_status() before using the buffer? > } --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260824-qcom-dp-ty= pec-reconnect-fixes-v1-0-2825e5bf8a96@oss.qualcomm.com?part=3D2