From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF5174189BA for ; Mon, 24 Aug 2026 12:14:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.17 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787573696; cv=none; b=mdjQPnG2F5B24O0M/EFkzMnhD8Iws9modfvCGEzkmmR5luIyaoxfy4LvtPA+YZM2yNaDzYmMz/PM2jjlmdwRtfbjuQvTvUQ5RRG17CBkddZyXnqiIcwoaQO3idpXcQnqEUveP5zWEkUbtKn9LZvi6peFAngE54V6g0k67xrXJMg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787573696; c=relaxed/simple; bh=WK+OD4npyNFV++G6qmAYdDTCKkofhwJBMZOV4i4m74k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WvhkOSI9FQhsTuwpNWmugXJWQxWRDhZ3LjkXXVAO0XTyMMxaK/cC4vSo2CyWPKGBgC+oRMG+fG+9J7OOtBydjR4MnR5/3ruxjiztw1Z6o0EQy2T6e00Uf1W2vFjzHvSYZWnP8461Yarbyen4pqmOQ3wW+BhNR7x9lRzqxLd3Y94= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=mvCUI3oc; arc=none smtp.client-ip=198.175.65.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="mvCUI3oc" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1787573694; x=1819109694; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=WK+OD4npyNFV++G6qmAYdDTCKkofhwJBMZOV4i4m74k=; b=mvCUI3ocEUZJ6sTbjHp+5KP7PMDpGIDtAs5M+nGBgFFZucQv4il8hemP V/l1JZvg3u64OH+yT5Vjf56LsKpFFs5tUC7i97jjBVkdyYxhu+BA4Td/Q hB4w0EnRZeOBn5cNcftw/cHrTMpHrMryq3rOHAJEHJ82kqJ36L4vJ3/IM y4rMW+ree+ArniLdLNiTZe3D5HgMupOqn4cb6akHD/gNkW5NXGxm6PNJL Y69piyu95/usipoXLPWeza1t4Wurgxl/6SgKWvu+fZft2QrwuBanpmWgJ 3uwRvOLXhz+a2r0Pi0+rv+bRJvkTEvoEaJNBojHjQvvAYZu4BqnkFTTRj A==; X-CSE-ConnectionGUID: XfIunN3ARi+DRI+OhLgezQ== X-CSE-MsgGUID: 0kvLQKPWQAWH7Ux+zPWMrQ== X-IronPort-AV: E=McAfee;i="6800,10657,11884"; a="88036558" X-IronPort-AV: E=Sophos;i="6.25,240,1779174000"; d="scan'208";a="88036558" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Aug 2026 05:14:51 -0700 X-CSE-ConnectionGUID: 4w3/igilRUK1jUKD4b/NUg== X-CSE-MsgGUID: jT4iTUT+R5it5cyJO5dw0Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,240,1779174000"; d="scan'208";a="270787662" Received: from ettammin-mobl3.ger.corp.intel.com (HELO kekkonen.fi.intel.com) ([10.245.244.180]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Aug 2026 05:14:49 -0700 Received: from punajuuri.localdomain (unknown [192.168.240.130]) by kekkonen.fi.intel.com (Postfix) with ESMTP id 845A0122058; Mon, 24 Aug 2026 15:14:51 +0300 (EEST) Received: from sailus by punajuuri.localdomain with local (Exim 4.98.2) (envelope-from ) id 1wyTZj-0000000E39q-2q1Q; Mon, 24 Aug 2026 15:14:51 +0300 Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo From: Sakari Ailus To: linux-media@vger.kernel.org Cc: laurent.pinchart@ideasonboard.com, Dave Stevenson , Jacopo Mondi , Tomi Valkeinen , Jai Luthra , Mehdi Djait , Mattijs Korpershoek Subject: [PATCH v3 17/29] media: bcm2835-unicam: Use v4l2_subdev_get_frame_desc() Date: Mon, 24 Aug 2026 15:14:39 +0300 Message-ID: <20260824121451.3348583-18-sakari.ailus@linux.intel.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260824121451.3348583-1-sakari.ailus@linux.intel.com> References: <20260824121451.3348583-1-sakari.ailus@linux.intel.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Call v4l2_subdev_get_frame_desc() to obtain the frame descriptor. This is preferred over calling the get_frame_desc() pad operation directly. Signed-off-by: Sakari Ailus --- .../media/platform/broadcom/bcm2835-unicam.c | 22 +++++++++---------- 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/media/platform/broadcom/bcm2835-unicam.c b/drivers/media/platform/broadcom/bcm2835-unicam.c index 14bb916dd7b1..2322d3df3915 100644 --- a/drivers/media/platform/broadcom/bcm2835-unicam.c +++ b/drivers/media/platform/broadcom/bcm2835-unicam.c @@ -27,6 +27,7 @@ * output interface and V4L2 subdevice driver. */ +#include #include #include #include @@ -888,7 +889,6 @@ static int unicam_get_image_vc_dt(struct unicam_device *unicam, struct v4l2_subdev_state *state, u8 *vc, u8 *dt) { - struct v4l2_mbus_frame_desc fd; u32 stream; int ret; @@ -898,17 +898,15 @@ static int unicam_get_image_vc_dt(struct unicam_device *unicam, if (ret) return ret; - ret = v4l2_subdev_call(unicam->sensor.subdev, pad, get_frame_desc, - unicam->sensor.pad->index, &fd); - if (ret) - return ret; - - /* Only CSI-2 supports DTs. */ - if (fd.type != V4L2_MBUS_FRAME_DESC_TYPE_CSI2) - return -EINVAL; + struct v4l2_mbus_frame_desc *fd __free(v4l2_subdev_free_frame_desc) = + v4l2_subdev_get_frame_desc(unicam->sensor.subdev, + unicam->sensor.pad->index, + V4L2_MBUS_FRAME_DESC_TYPE_CSI2); + if (IS_ERR(fd)) + return PTR_ERR(fd); - for (unsigned int i = 0; i < fd.num_entries; ++i) { - const struct v4l2_mbus_frame_desc_entry *fde = &fd.entry[i]; + for (unsigned int i = 0; i < fd->num_entries; ++i) { + const struct v4l2_mbus_frame_desc_entry *fde = &fd->entry[i]; if (fde->stream == stream) { *vc = fde->bus.csi2.vc; @@ -927,7 +925,7 @@ static void unicam_start_rx(struct unicam_device *unicam, const struct unicam_format_info *fmtinfo; const struct v4l2_mbus_framefmt *fmt; unsigned int line_int_freq; - u8 vc, dt; + u8 vc = 0, dt = 0; u32 val; int ret; -- 2.47.3