All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: Biju <biju.das.au@gmail.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org,
	wsa+renesas@sang-engineering.com
Subject: Re: [PATCH v7 6/9] dt-bindings: pwm: Document RZ/G3E GPT support
Date: Mon, 24 Aug 2026 13:04:53 +0000	[thread overview]
Message-ID: <20260824130453.D03C01F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260824125523.131762-7-biju.das.jz@bp.renesas.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Add `#pwm-cells` to the `required` list. The binding omits this mandatory property for PWM providers.
--

--- Patch [6]: [PATCH v7 6/9] dt-bindings: pwm: Document RZ/G3E GPT support ---
commit 9a7d174b7aaab1e8640a8415696ce9830442c765
Author: Biju Das <biju.das.jz@bp.renesas.com>

dt-bindings: pwm: Document RZ/G3E GPT support
    
This commit documents the device tree bindings for the General PWM Timer
(GPT) on the Renesas RZ/G3E SoC. It details properties for the 16-channel
32-bit timer, including interrupts, clocks, resets, and power domains.

> diff --git a/Documentation/devicetree/bindings/pwm/renesas,rzg3e-gpt.yaml b/Documentation/devicetree/bindings/pwm/renesas,rzg3e-gpt.yaml
> new file mode 100644
> index 0000000000000..cb4ffab5f47fe
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pwm/renesas,rzg3e-gpt.yaml

[ ... ]

> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - interrupt-names
> +  - clocks
> +  - clock-names
> +  - power-domains
> +  - resets
> +  - reset-names

[Severity: Medium]
Since this hardware is a PWM provider and defines #pwm-cells in its
properties, should #pwm-cells be added to this required list?

Leaving it out allows incomplete device tree nodes to pass schema validation.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260824125523.131762-1-biju.das.jz@bp.renesas.com?part=6

  reply	other threads:[~2026-08-24 13:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-24 12:55 [PATCH v7 0/9] Add Renesas RZ/G3E GPT support Biju
2026-08-24 12:55 ` [PATCH v7 1/9] pwm: rzg2l-gpt: Fix macro used for period/duty cycle conversion Biju
2026-08-24 12:55 ` [PATCH v7 2/9] pwm: rzg2l-gpt: Convert to waveform callbacks Biju
2026-08-24 12:55 ` [PATCH v7 3/9] pwm: rzg2l-gpt: Add info variable to struct rzg2l_gpt_chip Biju
2026-08-24 12:55 ` [PATCH v7 4/9] pwm: rzg2l-gpt: Add prescale_mult variable to struct rzg2l_gpt_info Biju
2026-08-24 12:55 ` [PATCH v7 5/9] pwm: rzg2l-gpt: Add calculate_prescale() callback " Biju
2026-08-24 12:55 ` [PATCH v7 6/9] dt-bindings: pwm: Document RZ/G3E GPT support Biju
2026-08-24 13:04   ` sashiko-bot [this message]
2026-08-25 13:10     ` Biju Das
2026-08-24 12:55 ` [PATCH v7 7/9] pwm: rzg2l-gpt: Add RZ/G3E support Biju
2026-08-24 12:55 ` [PATCH v7 8/9] dt-bindings: pwm: rzg2l-gpt: Document renesas,poegs property Biju
2026-08-24 12:55 ` [PATCH v7 9/9] pwm: rzg2l-gpt: Add support for gpt linking with poeg Biju
2026-08-25 11:50 ` [PATCH v7 0/9] Add Renesas RZ/G3E GPT support Biju Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260824130453.D03C01F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=biju.das.au@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.