From: Mariano Baragiola <mbaragiola@linux.com>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
netdev@vger.kernel.org
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, horms@kernel.org, kuniyu@google.com,
littlesmilingcloud@gmail.com,
Mariano Baragiola <mbaragiola@linux.com>
Subject: Re: [PATCH] udp: resubmit encapsulation packets on all multicast listeners
Date: Mon, 24 Aug 2026 10:14:51 -0300 [thread overview]
Message-ID: <20260824131451.33372-1-mbaragiola@linux.com> (raw)
In-Reply-To: <willemdebruijn.kernel.13d69ffd770f1@gmail.com>
Thanks for checking this.
I fetched current net and confirmed that 3cb8d4b9bfeb is now present, so the primary-path issue is fixed there.
I also checked the SO_BINDTODEVICE case. Although different bound devices can bypass the port-use equality check, multicast delivery requires the socket's bound device to match the packet's ingress device. Those sockets therefore cannot become multiple matching listeners for the same multicast packet. FOU/GUE sockets also do not enable SO_REUSEADDR or SO_REUSEPORT.
The secondary clone path is therefore not reachable for the positive encapsulation return. I will withdraw this patch rather than repost it.
For completeness, I found the original issue while comparing the multicast receive path with the unicast and GSO paths, then confirmed it with a focused FOU probe against clean and patched kernels. The clean kernel dropped the multicast encapsulated packets; the patched kernel resubmitted them to the IP protocol handler.
Thanks again for the review.
prev parent reply other threads:[~2026-08-24 13:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-15 14:11 [PATCH] udp: resubmit encapsulation packets on all multicast listeners Mariano Baragiola
2026-08-17 23:29 ` Jakub Kicinski
2026-08-22 19:08 ` Willem de Bruijn
2026-08-24 13:14 ` Mariano Baragiola [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260824131451.33372-1-mbaragiola@linux.com \
--to=mbaragiola@linux.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=littlesmilingcloud@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.