From: Tom Rini <trini@konsulko.com>
To: Suraj Kakade <suraj.hanumantkakade@amd.com>
Cc: u-boot@lists.u-boot-project.org, michal.simek@amd.com,
git@amd.com, padmarao.begari@amd.com,
Rasmus Villemoes <rv@rasmusvillemoes.dk>,
Simon Glass <sjg@chromium.org>,
Jonathan Humphreys <j-humphreys@ti.com>
Subject: Re: [PATCH RFC] scripts: pass dtc cpp flags via a GCC response file
Date: Mon, 24 Aug 2026 09:09:37 -0600 [thread overview]
Message-ID: <20260824150937.GD523975@bill-the-cat> (raw)
In-Reply-To: <20260824044729.708287-1-suraj.hanumantkakade@amd.com>
[-- Attachment #1: Type: text/plain, Size: 943 bytes --]
On Mon, Aug 24, 2026 at 10:17:18AM +0530, Suraj Kakade wrote:
> cmd_dtc inlines dtc_cpp_flags (including every upstream dtsi -I
> path) in the HOSTCC command. With a long $(srctree) that command is
> too large for /bin/sh -c and Make fails with "Argument list too
> long" while building a .dtb.
>
> Write the flags to a per-target .dtc.flags.tmp file and pass @file to
> HOSTCC/CPP so the shell command stays short.
>
> This change requires GNU Make >= 4.0, since $(file ...) is not
> supported by Make 3.x.
>
> Fixes: d31ff219a833 ("Makefile.lib: find capsule ESL dtsi file with CONFIG_OF_UPSTREAM")
> Fixes: 1e7883f6325a ("dtbo: Fix dtbo generation rules")
> Signed-off-by: Suraj Kakade <suraj.hanumantkakade@amd.com>
The linux kernel, and so Kbuild, says that 4.0 is the minimum version of
GNU make required, so that is true for us as well, so this is fine.
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-08-24 15:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-24 4:47 [PATCH RFC] scripts: pass dtc cpp flags via a GCC response file Suraj Kakade
2026-08-24 15:09 ` Tom Rini [this message]
2026-08-24 15:29 ` Michal Simek
2026-08-24 16:51 ` Tom Rini
2026-08-25 5:53 ` Michal Simek
2026-08-25 13:48 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260824150937.GD523975@bill-the-cat \
--to=trini@konsulko.com \
--cc=git@amd.com \
--cc=j-humphreys@ti.com \
--cc=michal.simek@amd.com \
--cc=padmarao.begari@amd.com \
--cc=rv@rasmusvillemoes.dk \
--cc=sjg@chromium.org \
--cc=suraj.hanumantkakade@amd.com \
--cc=u-boot@lists.u-boot-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.