All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avinesh Kumar <avinesh.kumar@suse.com>
To: fstests@vger.kernel.org
Cc: wqu@suse.com
Subject: [PATCH] generic/798: exclude nfs from cachestat dirty page reporting test
Date: Mon, 24 Aug 2026 17:11:06 +0200	[thread overview]
Message-ID: <20260824151107.209027-1-avinesh.kumar@suse.com> (raw)

From: Avinesh Kumar <avinesh.kumar@suse.com>

generic/798 checks cachestat() page cache dirty state between write and
fsync operations.

On NFS, the client flushes dirty pages to the server during close() to
enforce its close-to-open consistency model. Because the test uses separate
xfs_io invocations, the file is closed after writing, leaving pages already
clean by the time the subsequent cachestat command executes, causing the
test to fail.

- output mismatch (see /opt/xfstests/results//generic/798.out.bad)
    --- tests/generic/798.out	2026-08-20 05:25:39.000000000 -0400
    +++ /opt/xfstests/results//generic/798.out.bad	2026-08-21 12:30:39.831381108 -0400
    @@ -1,16 +1,16 @@
     QA output created by 798
     === Test with 1 pages ===
    -Cached: 1, Dirty: 1, Writeback: 0, Evicted: 0, Recently Evicted: 0
    +Cached: 1, Dirty: 0, Writeback: 0, Evicted: 0, Recently Evicted: 0
     Cached: 1, Dirty: 0, Writeback: 0, Evicted: 0, Recently Evicted: 0
     === Test with 2 pages ===
    -Cached: 2, Dirty: 2, Writeback: 0, Evicted: 0, Recently Evicted: 0
    ...

Exclude 'nfs' from running this test.

Signed-off-by: Avinesh Kumar <avinesh.kumar@suse.com>
---
 tests/generic/798 | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/tests/generic/798 b/tests/generic/798
index 0fe37646..80b2acc9 100755
--- a/tests/generic/798
+++ b/tests/generic/798
@@ -16,6 +16,12 @@ _require_scratch
 _exclude_scratch_mount_option "dax"
 _exclude_scratch_mount_option "sync"
 
+# NFS flushes dirty data back to the server on close() as part of its
+# close-to-open cache consistency model, so a page written and closed in
+# one xfs_io invocation is no longer dirty by the time cachestat runs in
+# a later invocation.
+_exclude_fs nfs
+
 pagesize=$(_get_page_size)
 
 _scratch_mkfs > /dev/null
-- 
2.55.0


             reply	other threads:[~2026-08-24 15:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-24 15:11 Avinesh Kumar [this message]
2026-08-24 16:15 ` [PATCH] generic/798: exclude nfs from cachestat dirty page reporting test Darrick J. Wong
2026-08-26 14:39   ` Avinesh Kumar
2026-08-26 15:01   ` [PATCH v2] generic/798: chain xfs_io commands into a single invocation Avinesh Kumar
2026-08-26 15:20     ` Darrick J. Wong
2026-08-26 15:54       ` [PATCH v3] " Avinesh Kumar
2026-08-26 16:15         ` Darrick J. Wong
2026-08-26 17:00         ` Zorro Lang
2026-08-26 22:13         ` Qu Wenruo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260824151107.209027-1-avinesh.kumar@suse.com \
    --to=avinesh.kumar@suse.com \
    --cc=fstests@vger.kernel.org \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.