From: Jia Yao <jia.yao@intel.com>
To: stable@vger.kernel.org
Cc: "Jia Yao" <jia.yao@intel.com>,
"Gwan-gyeong Mun" <gwan-gyeong.mun@intel.com>,
"Matthew Auld" <matthew.auld@intel.com>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>
Subject: [PATCH 2/3] drm/xe/guc_ads: allocate UM queues in VRAM on dGFX
Date: Mon, 24 Aug 2026 16:52:07 +0000 [thread overview]
Message-ID: <20260824165208.498797-2-jia.yao@intel.com> (raw)
In-Reply-To: <20260824165208.498797-1-jia.yao@intel.com>
On iGPU, the UM queue BO is allocated in system memory. On dGFX, the BO
was previously created in system memory and later reallocated in
xe_guc_realloc_post_hwconfig(). Allocate the UM queue BO directly in
VRAM on dGFX, where it is ultimately required.
Fixes: 9c57bc08652a ("drm/xe/lnl: Drop force_probe requirement")
Cc: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: <stable@vger.kernel.org> # v6.12+
Signed-off-by: Jia Yao <jia.yao@intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Link: https://patch.msgid.link/20260804165057.129529-3-jia.yao@intel.com
(cherry picked from commit ace076ef0a854ab5940bacc539bf66afd61d118c)
Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
(cherry picked from commit f342810a141f8a7e8b3786a6e4b6c0695a078a74)
---
drivers/gpu/drm/xe/xe_guc.c | 6 ------
drivers/gpu/drm/xe/xe_guc_ads.c | 8 +++++---
2 files changed, 5 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_guc.c b/drivers/gpu/drm/xe/xe_guc.c
index cc5741f751b9..ae0c88da422b 100644
--- a/drivers/gpu/drm/xe/xe_guc.c
+++ b/drivers/gpu/drm/xe/xe_guc.c
@@ -700,12 +700,6 @@ static int xe_guc_realloc_post_hwconfig(struct xe_guc *guc)
if (ret)
return ret;
- if (guc->ads.um_queue_bo) {
- ret = xe_managed_bo_reinit_in_vram(xe, tile, &guc->ads.um_queue_bo);
- if (ret)
- return ret;
- }
-
return 0;
}
diff --git a/drivers/gpu/drm/xe/xe_guc_ads.c b/drivers/gpu/drm/xe/xe_guc_ads.c
index 806c2618a7cd..4c3e21b5e60e 100644
--- a/drivers/gpu/drm/xe/xe_guc_ads.c
+++ b/drivers/gpu/drm/xe/xe_guc_ads.c
@@ -392,15 +392,17 @@ int xe_guc_ads_init(struct xe_guc_ads *ads)
/*
* Allocate a separate BO for the HW fault ring (UM queues).
*
- * Round the size up to the next power of two so that
+ * Round the size up to the next power of two so that on iGPU
* (system memory, no IOMMU) the TTM pool issues a single
* alloc_pages(order=N) call, maximising the chance of getting
* a physically contiguous block. GuC requires contiguous DPA.
*/
- size_t um_size = roundup_pow_of_two(GUC_UM_QUEUE_SIZE *
+ size_t um_size = IS_DGFX(xe) ?
+ GUC_UM_QUEUE_SIZE * GUC_UM_HW_QUEUE_MAX :
+ roundup_pow_of_two(GUC_UM_QUEUE_SIZE *
GUC_UM_HW_QUEUE_MAX);
- u32 um_flags = XE_BO_FLAG_SYSTEM |
+ u32 um_flags = XE_BO_FLAG_VRAM_IF_DGFX(tile) |
XE_BO_FLAG_GGTT |
XE_BO_FLAG_GGTT_INVALIDATE |
XE_BO_FLAG_PINNED_NORESTORE;
--
2.43.0
next prev parent reply other threads:[~2026-08-24 16:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-20 11:13 FAILED: patch "[PATCH] drm/xe/guc_ads: allocate UM queues in a separate BO" failed to apply to 6.18-stable tree gregkh
2026-08-20 16:08 ` [PATCH 6.18.y] drm/xe/guc_ads: allocate UM queues in a separate BO Jia Yao
2026-08-24 16:52 ` [PATCH 1/3] " Jia Yao
2026-08-24 16:52 ` Jia Yao [this message]
2026-08-24 16:52 ` [PATCH 3/3] drm/xe/guc_ads: use uncached mapping for UM queue BO Jia Yao
2026-08-24 17:02 ` [PATCH 1/3] drm/xe/guc_ads: allocate UM queues in a separate BO Greg KH
2026-08-24 17:12 ` Yao, Jia
2026-08-25 3:45 ` Yao, Jia
2026-08-25 3:42 ` [PATCH 6.18.y " Jia Yao
2026-08-25 3:42 ` [PATCH 6.18.y 2/3] drm/xe/guc_ads: allocate UM queues in VRAM on dGFX Jia Yao
2026-08-25 8:27 ` Greg KH
2026-08-25 3:42 ` [PATCH 6.18.y 3/3] drm/xe/guc_ads: use uncached mapping for UM queue BO Jia Yao
2026-08-25 8:28 ` Greg KH
2026-08-25 23:27 ` Yao, Jia
2026-08-25 8:27 ` [PATCH 6.18.y 1/3] drm/xe/guc_ads: allocate UM queues in a separate BO Greg KH
2026-08-25 23:30 ` Jia Yao
2026-08-25 23:30 ` [PATCH 6.18.y 2/3] drm/xe/guc_ads: allocate UM queues in VRAM on dGFX Jia Yao
2026-08-25 23:30 ` [PATCH 6.18.y 3/3] drm/xe/guc_ads: use uncached mapping for UM queue BO Jia Yao
2026-08-27 5:17 ` [PATCH 6.18.y 1/3] drm/xe/guc_ads: allocate UM queues in a separate BO Sasha Levin
-- strict thread matches above, loose matches on Subject: below --
2026-08-20 11:13 FAILED: patch "[PATCH] drm/xe/guc_ads: use uncached mapping for UM queue BO" failed to apply to 6.12-stable tree gregkh
2026-08-24 16:48 ` [PATCH 1/3] drm/xe/guc_ads: allocate UM queues in a separate BO Jia Yao
2026-08-24 16:48 ` [PATCH 2/3] drm/xe/guc_ads: allocate UM queues in VRAM on dGFX Jia Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260824165208.498797-2-jia.yao@intel.com \
--to=jia.yao@intel.com \
--cc=gwan-gyeong.mun@intel.com \
--cc=matthew.auld@intel.com \
--cc=stable@vger.kernel.org \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.