All of lore.kernel.org
 help / color / mirror / Atom feed
From: Max Kellermann <max.kellermann@ionos.com>
To: idryomov@gmail.com, amarkuze@redhat.com, xiubo.li@clyso.com,
	ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Max Kellermann <max.kellermann@ionos.com>
Subject: [PATCH v5 07/11] fs/ceph: remove i_truncate_mutex, use i_fragtree_mutex for both
Date: Mon, 24 Aug 2026 20:41:55 +0200	[thread overview]
Message-ID: <20260824184159.240821-8-max.kellermann@ionos.com> (raw)
In-Reply-To: <20260824184159.240821-1-max.kellermann@ionos.com>

`i_fragtree_mutex` is only used for directories and `i_truncate_mutex`
is only used for regular files.  Since these two fields will never be
both be used on any given object, let's merge them into one.

(This is a minimal diff that defines a preprocessor macro, to avoid
refactoring all code lines using these two mutexes.)

This reduces the size of `struct ceph_inode_info` by 8 bytes.

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
---
 fs/ceph/inode.c | 1 -
 fs/ceph/super.h | 7 ++++++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/fs/ceph/inode.c b/fs/ceph/inode.c
index ce793ff934d0..a7cf9a7df756 100644
--- a/fs/ceph/inode.c
+++ b/fs/ceph/inode.c
@@ -677,7 +677,6 @@ struct inode *ceph_alloc_inode(struct super_block *sb)
 	for (i = 0; i < CEPH_FILE_MODE_BITS; i++)
 		ci->i_nr_by_mode[i] = 0;
 
-	mutex_init(&ci->i_truncate_mutex);
 	ci->i_truncate_seq = 0;
 	ci->i_truncate_size = 0;
 	ci->i_truncate_pending = 0;
diff --git a/fs/ceph/super.h b/fs/ceph/super.h
index 05452bc7eac1..beb7009f793c 100644
--- a/fs/ceph/super.h
+++ b/fs/ceph/super.h
@@ -466,7 +466,12 @@ struct ceph_inode_info {
 	unsigned long i_last_wr;
 	int i_nr_by_mode[CEPH_FILE_MODE_BITS];  /* open file counts */
 
-	struct mutex i_truncate_mutex;
+/* since i_fragtree_mutex is only used for directories and
+ * i_truncate_mutex is only used for regular files, we use the same
+ * field for both
+ */
+#define i_truncate_mutex i_fragtree_mutex
+
 	u64 i_truncate_size;       /*  and the size we last truncated down to */
 	u32 i_truncate_seq;        /* last truncate to smaller size */
 	int i_truncate_pending;    /*  still need to call vmtruncate */
-- 
2.47.3


  parent reply	other threads:[~2026-08-24 18:42 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-24 18:41 [PATCH v5 00/11] fs/ceph: optimize struct layouts Max Kellermann
2026-08-24 18:41 ` [PATCH v5 01/11] fs/ceph/super: remove unused field `i_cap_migration_resv` Max Kellermann
2026-08-24 18:41 ` [PATCH v5 02/11] fs/ceph/super: make field `i_truncate_pagecache_size` optional Max Kellermann
2026-08-24 18:41 ` [PATCH v5 03/11] fs/ceph/super.h: convert ceph_inode_xattr fields to `bool` Max Kellermann
2026-08-24 18:41 ` [PATCH v5 04/11] fs/ceph/super.h: convert ceph_cap_snap.writing " Max Kellermann
2026-08-24 18:41 ` [PATCH v5 05/11] fs/ceph: consistently use `u32` for `time_warp_seq` Max Kellermann
2026-08-24 18:41 ` [PATCH v5 06/11] fs/ceph/super: reorder fields to eliminate padding holes Max Kellermann
2026-08-24 18:41 ` Max Kellermann [this message]
2026-08-24 18:41 ` [PATCH v5 08/11] fs/ceph/super.h: add `const` to helpers Max Kellermann
2026-08-24 18:41 ` [PATCH v5 09/11] fs/ceph/super.h: add helper ceph_in_snap() Max Kellermann
2026-08-24 18:41 ` [PATCH v5 10/11] fs/ceph: use ceph_vino() etc. instead of accessing i_vino directly Max Kellermann
2026-08-24 18:41 ` [PATCH v5 11/11] fs/ceph: remove redundant inode number from ceph_inode_info Max Kellermann
2026-08-25 12:16 ` [PATCH v5 00/11] fs/ceph: optimize struct layouts Alex Markuze

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260824184159.240821-8-max.kellermann@ionos.com \
    --to=max.kellermann@ionos.com \
    --cc=amarkuze@redhat.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=idryomov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xiubo.li@clyso.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.