From: Jeff King <peff@peff.net>
To: Karthik Nayak <karthik.188@gmail.com>
Cc: git@vger.kernel.org, ps@pks.im, gitster@pobox.com, jltobler@gmail.com
Subject: Re: [PATCH v2 4/4] reftable/stack: avoid reloading the stack when already locked
Date: Mon, 24 Aug 2026 18:52:02 -0400 [thread overview]
Message-ID: <20260824225202.GA190620@coredump.intra.peff.net> (raw)
In-Reply-To: <20260824-740-optimize-reloading-the-reftable-stack-v2-4-9c9de2eb0af7@gmail.com>
On Mon, Aug 24, 2026 at 11:31:02AM +0200, Karthik Nayak wrote:
> Benchmarking with a fixed, non-symbolic target OID in the 'refs/tags/'
> namespace (since it triggers a stack reload when checking if reflog
> exists for the given tag name), shows a consistent 15-20% improvement
> with these patches:
>
> refcount master patch speedup
> -------- ------- ------- -------
> 2,000 18.5 ms 16.6 ms 1.11x
> 20,000 120.7 ms 102.8 ms 1.17x
> 50,000 296.5 ms 247.1 ms 1.20x
Much nicer. :)
I'm not very familiar with the reftable code, so you can take my review
with a huge grain of salt. But I think the idea is sound, and I didn't
see anything obviously wrong. Thanks for working on this.
-Peff
prev parent reply other threads:[~2026-08-24 22:52 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-19 13:19 [PATCH 0/3] reftable/stack: avoid reloading the stack when locked Karthik Nayak
2026-08-19 13:19 ` [PATCH 1/3] reftable/stack: remove `REFTABLE_STACK_NEW_ADDITION_RELOAD` Karthik Nayak
2026-08-19 16:28 ` Justin Tobler
2026-08-20 21:15 ` Karthik Nayak
2026-08-20 5:51 ` Patrick Steinhardt
2026-08-20 21:20 ` Karthik Nayak
2026-08-20 21:23 ` Karthik Nayak
2026-08-19 13:19 ` [PATCH 2/3] reftable/stack: move list lock to `struct reftable_stack` Karthik Nayak
2026-08-19 16:39 ` Justin Tobler
2026-08-19 17:17 ` Junio C Hamano
2026-08-23 15:28 ` Karthik Nayak
2026-08-19 13:19 ` [PATCH 3/3] reftable/stack: avoid reloading the stack when already locked Karthik Nayak
2026-08-19 16:49 ` Justin Tobler
2026-08-23 15:39 ` Karthik Nayak
2026-08-20 7:53 ` Jeff King
2026-08-23 17:39 ` Karthik Nayak
2026-08-24 4:59 ` Jeff King
2026-08-24 9:30 ` [PATCH v2 0/4] reftable/stack: avoid reloading the stack when locked Karthik Nayak
2026-08-24 9:30 ` [PATCH v2 1/4] reftable/stack: remove `REFTABLE_STACK_NEW_ADDITION_RELOAD` Karthik Nayak
2026-08-24 9:31 ` [PATCH v2 2/4] reftable/stack: rename reftable_stack_new_addition() Karthik Nayak
2026-08-24 9:31 ` [PATCH v2 3/4] reftable/stack: move list lock to `struct reftable_stack` Karthik Nayak
2026-08-24 9:31 ` [PATCH v2 4/4] reftable/stack: avoid reloading the stack when already locked Karthik Nayak
2026-08-24 22:52 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260824225202.GA190620@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jltobler@gmail.com \
--cc=karthik.188@gmail.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.