From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 016B0C5DF81 for ; Tue, 25 Aug 2026 04:05:51 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wyiPq-0006PF-Ub; Tue, 25 Aug 2026 00:05:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wyiPo-0006LX-Qo for qemu-devel@nongnu.org; Tue, 25 Aug 2026 00:05:36 -0400 Received: from mail-pg1-x533.google.com ([2607:f8b0:4864:20::533]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wyiPm-0007eB-4A for qemu-devel@nongnu.org; Tue, 25 Aug 2026 00:05:36 -0400 Received: by mail-pg1-x533.google.com with SMTP id 41be03b00d2f7-ca97d139d5fso3752011a12.0 for ; Mon, 24 Aug 2026 21:05:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787630732; x=1788235532; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=aobazBPH903Nn7eCzJVoO7AB8KnEtMzG35AgTewbhFg=; b=ia6OqR71sQgA+I/bhwIw9YHtXoEnl3gRBexfM9eGs9hV1cpjWeXb16RqR0D0+2aKcj w/QDz4gWwkrCMZ2QMxzTn2H1zzaicbvX6Nt+AmLWOWifniLoOOz5q2jASR0Mf82dabOb yWWFpyY2SQTQh1/997YZ4ahyLIUatb2JL+ZpdAgtl6NlNCC7rgEdD9QTuZ8zEPXNCXqB K9faUkHZTx1um35JFt2FnY1BxUpAz+drks9EsTrGeyL71/XCksAzMiL/+jzjo0oSsetc GdElLO2eiZJSty+zf8cHPgcq89B7hUrFW8suV95SI0/ZI244Zwielf0cr7KtBJDTKpZO pO4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787630732; x=1788235532; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=aobazBPH903Nn7eCzJVoO7AB8KnEtMzG35AgTewbhFg=; b=R8GLk1926HN8KGBjBaoB03jQUEwlbLhPhoWcWeiuWqTGz//5Wif+olpEiMeNJ3eb6z mQczk+v9VkEbLbt1msutB2zLgpmwhBraSdhWjy4kbKvo2MvgSKEIfcq/44ASIiO3Rxkx LFat7W7bj3vR3B45xawhQEps+WSnXBlXtWZIgAGvX1BwGjK+3BGKh4Zw0ZCUfjhrm/Il SpbFnYMR7GRBSC5zH6cuIapIflLRbUBWVTuPASc1Rv/K1k2gRp8nh+d6vvv5SYZqEgbi KT8pOM4Iwl+sZf/hIvnmmaFsf6PNAJHHtWvDilZ9SPU/LVtZHRCtg8DKDak2uT5PXszA AcLw== X-Gm-Message-State: AFuF++nPhiduznSBo41919Qt7kwNz3+pgOhHlu1jRVDsnq77PzivI43N rfP3LK0fRA8TyAyZJ6Fd+TQO9ZPjJbBtPrSMuWU3vq4dHaJJOjb590es7FMyZtub X-Gm-Gg: AR+sD13PUnsjw8fGVTI14iAfKS8Q8TGktErX2neenf8jrMKClQ1z/xPfrfbDGVxeNHB rcuewblIml7zpvTuvIprzTIMTz5RQG429g4sqsZkLcWARMm5++WQNFmWn3Lj8wr+KPa2vrBY6cP lYAalGYKmxIHWqcYEux+zjzPqbSP4RfE10kBZmMs2mPHtX6//11EW67OmnoYJOhRxxblwZPLZb6 XQL5XpIB3bDGlSy1juPEjzKBqfF5nGFE2HGNDVob20HGq4aTT73QJkoEJ00kYiMILZyWd8+aAsv /Ro7E/XUCMu0LjU+YYVkBG6pp2Fr6iIxqnDbXOYo7Q1KP4TboA8wBoPH3e/HYaUzIpOQPCvMKDQ bV/HXpXgPWyp66AXQxLm/gEGF2cYsOhoh1WFnQPKLbWr2WwhSa63IzhzGLT0TMmlgWuRC2z55xA Gb308vZ63/9Gz5L8gsZZhuzHShHPWKqM+oNsADRRKNK66lezK6Zv55qoCpohweV1MOguHZ0gdNU qcbEQcqJXvm9UrhaEbG67zEuBZV7p6DfA== X-Received: by 2002:a05:6a20:a110:b0:3c3:bbe6:95c9 with SMTP id adf61e73a8af0-3cd301795c8mr57364255637.16.1787630732578; Mon, 24 Aug 2026 21:05:32 -0700 (PDT) Received: from lima-default.tail89d63.ts.net ([159.196.41.205]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327f909adc8sm34104212eec.2.2026.08.24.21.05.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2026 21:05:32 -0700 (PDT) From: stephensportia@gmail.com To: qemu-devel@nongnu.org Cc: Palmer Dabbelt , Peter Maydell , Jamin Lin , qemu-ppc@nongnu.org, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Steven Lee , Andrew Jeffery , Harsh Prateek Bora , Subbaraya Sundeep , Troy Lee , "Edgar E. Iglesias" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Alistair Francis , Strahinja Jankovic , qemu-arm@nongnu.org, Tyrone Ting , Nicholas Piggin , Aditya Gupta , Kane Chen , Francisco Iglesias , Joel Stanley , Hao Wu , Glenn Miles , qemu-riscv@nongnu.org, Jean-Christophe Dubois , Portia Stephens Subject: [PATCH 3/4] hw/arm/strongarm: Fix dropped upper byte of ssi transfer Date: Tue, 25 Aug 2026 14:04:51 +1000 Message-ID: <20260825040452.1322251-4-stephensportia@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260825040452.1322251-1-stephensportia@gmail.com> References: <20260825040452.1322251-1-stephensportia@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::533; envelope-from=stephensportia@gmail.com; helo=mail-pg1-x533.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org From: Portia Stephens The strongarm model intends to transfer a 16-bit value over SSI. There is no machine using this model with a peripheral attached so it is impossible to know what the intended SSI peripheral is. There is no in-tree peripheral support for 16-bit transfer, update to use 8-bit transfer. Signed-off-by: Portia Stephens --- hw/arm/strongarm.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/arm/strongarm.c b/hw/arm/strongarm.c index e400f0a185..2df895c75b 100644 --- a/hw/arm/strongarm.c +++ b/hw/arm/strongarm.c @@ -1512,11 +1512,14 @@ static void strongarm_ssp_write(void *opaque, hwaddr addr, * there directly to the slave, no need to buffer it. */ if (s->sscr[0] & SSCR0_SSE) { - uint32_t readval; + uint32_t readval = 0; if (s->sscr[1] & SSCR1_LBM) { readval = value; } else { - readval = ssi_transfer8(s->bus, value); + if (SSCR0_DSS(s->sscr[0]) > 8) { + readval |= ssi_transfer8(s->bus, (value >> 8) & 0xff) << 8; + } + readval |= ssi_transfer8(s->bus, value & 0xff); } if (s->rx_level < 0x08) { -- 2.43.0