Re: [LTP] ima_selinux.sh: test2 assumes CONFIG_IMA_DISABLE_HTABLE is configured

[Petr Vorel <pvorel@suse.cz>]

Hi Mimi,

> Hi Mimi,

> On August 21, 2026, Mimi Zohar wrote:
> > ima_selinux.sh: test2 assumes CONFIG_IMA_DISABLE_HTABLE is configured

> > +		if ! tst_check_kconfigs "CONFIG_IMA_DISABLE_HTABLE=y"; then
> > +			tst_res TPASS "Duplicate \"selinux-state\" record missing (CONFIG_IMA_DISABLE_HTABLE not set)"

I would suggest the same, it makes sense to use TCONF to make it visible that
it's not an error but OTOH it was not actually tested due
CONFIG_IMA_DISABLE_HTABLE not set. If you don't mind, I'd change TPASS to TCONF
before merge (or feel free to send v2 with this change yourself with my
Reviewed-by: Petr Vorel <pvorel@suse.cz>
).

Thanks for the fix!

Kind regards,
Petr

> Could this path report TCONF instead? Without duplicate records, test2 cannot
> compare the current enforcing state with a fresh measurement and returns
> before checking the remaining state fields. TPASS turns this untested
> configuration into a successful test result.

> Verdict - Needs revision

> ---
> Note:

> The agent can sometimes produce false positives although often its
> findings are genuine. If you find issues with the review, please
> comment this email or ignore the suggestions.

> Regards,
> LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp