From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: cem@kernel.org, hch@lst.de, stable@vger.kernel.org,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 4/5] xfs: report nonexistent parents as a filesystem corruption
Date: Tue, 25 Aug 2026 08:46:37 +0200 [thread overview]
Message-ID: <20260825064637.GD24532@lst.de> (raw)
In-Reply-To: <178760941165.944364.4932010221437452578.stgit@frogsfrogsfrogs>
On Mon, Aug 24, 2026 at 10:36:59PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> LOLLM noticed that when the directory tree scrubber tries to walk up a
> parent pointer but the parent inumber doesn't point to an allocated
> inode, we allow the EINVAL/ENOENT error code to bubble up to userspace.
> That's not right, we should be reporting that as a cross-referencing
> error so that someone runs the parent pointer checker.
Test case?
Either way, the fix does looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2026-08-25 6:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-25 5:34 [PATCHSET 2/2] xfs: LLM-inspired bug fixes, part 8 Darrick J. Wong
2026-08-25 5:36 ` [PATCH 1/5] xfs: always set xfs_healthmon::first_event when inserting at front of list Darrick J. Wong
2026-08-25 6:40 ` Christoph Hellwig
2026-08-25 18:33 ` Darrick J. Wong
2026-08-26 4:48 ` Christoph Hellwig
2026-08-26 4:54 ` Darrick J. Wong
2026-08-26 5:10 ` Christoph Hellwig
2026-08-25 5:36 ` [PATCH 2/5] xfs: check healthmon outbuffer space correctly Darrick J. Wong
2026-08-25 6:44 ` Christoph Hellwig
2026-08-25 18:36 ` Darrick J. Wong
2026-08-25 5:36 ` [PATCH 3/5] xfs: bump lost_prev_errors if we lose even the healthmon lost event Darrick J. Wong
2026-08-25 6:45 ` Christoph Hellwig
2026-08-25 5:36 ` [PATCH 4/5] xfs: report nonexistent parents as a filesystem corruption Darrick J. Wong
2026-08-25 6:46 ` Christoph Hellwig [this message]
2026-08-25 5:37 ` [PATCH 5/5] xfs: destroy seen inode bitmap when we fail to add a dirpath Darrick J. Wong
2026-08-25 6:48 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260825064637.GD24532@lst.de \
--to=hch@lst.de \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.