All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Enlin Mu <enlin.mu@linux.dev>
Cc: peterz@infradead.org, tglx@kernel.org, boqun@kernel.org,
	lyude@redhat.com, joelagnelf@nvidia.com,
	linux-kernel@vger.kernel.org, enlin.mu@unisoc.com
Subject: Re: [PATCH v2] softirq: Remove redundant h->action from preempt_count mismatch error
Date: Tue, 25 Aug 2026 08:53:40 +0200	[thread overview]
Message-ID: <20260825065340.PBy31xfe@linutronix.de> (raw)
In-Reply-To: <20260825011509.8505-1-enlin.mu@linux.dev>

On 2026-08-25 09:15:09 [+0800], Enlin Mu wrote:
> When a preempt_count mismatch is detected in handle_softirqs(), the
> error message currently prints the softirq action handler (h->action).
> 
> However, as Thomas Gleixner pointed out, the action handler for a given
> softirq vector is always a known, fixed function (e.g., run_timer_softirq
> for TIMER_SOFTIRQ). Printing it provides zero diagnostic value. The real
> issue typically lies in the functions invoked *within* that handler, not
> the handler entry point itself.
> 
> Therefore, as suggested by Sebastian Andrzej Siewior, remove h->action
> from the print statement entirely to clean up the error message.
> 
> Suggested-by: Thomas Gleixner <tglx@linutronix.de>
> Suggested-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Signed-off-by: Enlin Mu <enlin.mu@unisoc.com>
> Signed-off-by: Enlin Mu <enlin.mu@linux.dev>

Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

Sebastian

  reply	other threads:[~2026-08-25  6:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-25  1:15 [PATCH v2] softirq: Remove redundant h->action from preempt_count mismatch error Enlin Mu
2026-08-25  6:53 ` Sebastian Andrzej Siewior [this message]
2026-08-25 13:08 ` Bradley Morgan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260825065340.PBy31xfe@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=boqun@kernel.org \
    --cc=enlin.mu@linux.dev \
    --cc=enlin.mu@unisoc.com \
    --cc=joelagnelf@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lyude@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.