All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Peng Fan <peng.fan@oss.nxp.com>
Cc: Peng Fan <peng.fan@nxp.com>,
	u-boot@lists.u-boot-project.org, Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH 5/6] common: kconfig: raise SYS_CBSIZE default to 1024 for FSL_LSCH2/LSCH3
Date: Tue, 25 Aug 2026 11:19:38 +0300	[thread overview]
Message-ID: <20260825081938.b74bey6zpuewig7l@skbuf> (raw)
In-Reply-To: <ao1L1_1E_UAufqWa@nxa18884-linux-1.ap.freescale.net>

On Tue, Aug 25, 2026 at 04:01:27PM +0800, Peng Fan wrote:
> On Mon, Aug 24, 2026 at 03:28:24PM +0300, Vladimir Oltean wrote:
> >The 512-byte console input buffer limit for Layerscape SoCs originates
> >from copy-pasted boilerplate in the original LS2085A board support added
> >in commit f749db3a75ec ("ARMv8/ls2085a_emu: Add LS2085A emulator and
> >simulator board support"). No rationale was given for the 512-byte
> >choice; every subsequent FSL_LSCH2 and FSL_LSCH3 common header
> >(ls1043a, ls1046a, ls1088a, lx2160a, ...) inherited it by convention.
> >
> >When CONFIG_SYS_CBSIZE was moved to Kconfig in commit d31466b382dd
> >("Convert CONFIG_SYS_CBSIZE to Kconfig"), the existing 512-byte values
> >were transcribed mechanically into Kconfig defaults, cementing the
> >limit without re-examining its validity.
> >
> >The practical consequence is that environment variables holding
> >multi-step boot scripts are silently truncated at 510 usable characters
> >on all Layerscape boards, making it impossible to store commands such
> >as combined TFTP+flash sequences in a single variable.
> >
> >The same problem was already identified and fixed for i.MX6 and i.MX7
> >in commit f7b237b81e5a ("MLK-24380 imx6: Enlarge the console I/O buffer
> nit:
> 
> This is a downstream commit.
> 
> Regards
> Peng

Correct, I failed to update the commit message when rebasing.

Would you prefer replacing the commit sha1sum reference with just
"downstream", or just remove the justification altogether?

  reply	other threads:[~2026-08-25  8:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-24 12:28 [PATCH 0/6] Fixes and usability improvements for Layerscape QDS Vladimir Oltean
2026-08-24 12:28 ` [PATCH 1/6] configs: layerscape qds: disable ENV_RELOC_GD_ENV_ADDR for NOR boot Vladimir Oltean
2026-08-24 12:28 ` [PATCH 2/6] configs: ls2088aqds_tfa: fix NOR flash write failure Vladimir Oltean
2026-08-24 12:28 ` [PATCH 3/6] configs: layerscape qds: enable OF_LIBFDT_OVERLAY Vladimir Oltean
2026-08-24 12:28 ` [PATCH 4/6] configs: layerscape: drop CONFIG_SYS_PBSIZE=532 override Vladimir Oltean
2026-08-24 12:28 ` [PATCH 5/6] common: kconfig: raise SYS_CBSIZE default to 1024 for FSL_LSCH2/LSCH3 Vladimir Oltean
2026-08-25  8:01   ` Peng Fan
2026-08-25  8:19     ` Vladimir Oltean [this message]
2026-08-25 14:20       ` Tom Rini
2026-08-24 12:28 ` [PATCH 6/6] configs: ls104{3,6}aqds_tfa: enable PCIe Ethernet Vladimir Oltean
2026-08-24 13:20 ` [PATCH 0/6] Fixes and usability improvements for Layerscape QDS Vincent Jardin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260825081938.b74bey6zpuewig7l@skbuf \
    --to=vladimir.oltean@nxp.com \
    --cc=peng.fan@nxp.com \
    --cc=peng.fan@oss.nxp.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.u-boot-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.