Re: [PATCH v6 03/12] ARM: dts: aspeed: anacapa: Add EVT2 devicetree inheriting EVT1

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Redundant redefinition of inherited properties in the `evt2.dts` file.
--

--- Patch [3]: [PATCH v6 03/12] ARM: dts: aspeed: anacapa: Add EVT2 devicetree inheriting EVT1 ---
commit 6b89a922e36e90ce204fd77dd1e9b16cb96a0684
Author: Colin Huang <u8813345@gmail.com>

ARM: dts: aspeed: anacapa: Add EVT2 devicetree inheriting EVT1

Add a development-phase devicetree for the Facebook Anacapa BMC EVT2
hardware revision and update the Anacapa wrapper DTS to reference it.

> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa-evt2.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa-evt2.dts
> new file mode 100644
> index 0000000000000..075ac39f369f7
> --- /dev/null
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-anacapa-evt2.dts
> @@ -0,0 +1,178 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +
> +/dts-v1/;
> +#include "aspeed-bmc-facebook-anacapa-evt1.dts"
> +
> +/ {
> +	compatible = "facebook,anacapa-bmc-evt2", "aspeed,ast2600";
> +	model = "Facebook Anacapa BMC";

[Severity: Low]
This isn't a bug, but since this file includes
aspeed-bmc-facebook-anacapa-evt1.dts, is redefining the model string here
redundant? It appears to be identical to the inherited value from evt1.dts.

> +};
> +
> +&sgpiom0 {
> +	bus-frequency = <2000000>;

[Severity: Low]
This isn't a bug, but does redefining bus-frequency create a minor
maintainability hazard? This property seems to exactly match the one
inherited from the evt1.dts file.

[ ... ]

> +	"AMC_FAIL", "HPM_CPLD_RISCV_RST",
> +	"S0_ON", "";
> +
> +	ngpios = <128>;
> +
> +	status = "okay";

[Severity: Low]
This isn't a bug, but are ngpios and status also redundantly redefined? 
These exactly match the properties already inherited via Devicetree's node
merging from evt1.dts.

> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260825-anacapa-devlop-phase-devicetree-v6-0-9059a2a279ce@gmail.com?part=3