From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f42.google.com (mail-oa1-f42.google.com [209.85.160.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 219B133E37A for ; Tue, 25 Aug 2026 16:01:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787673714; cv=none; b=cQKWTkU0+XAmnPPnK0/eKJumEAllSgDFwTRhbueRRPuruLEnJ9tS1aXjxCqikIT+v6TczGMBNM2XO1sfZ9oCsYdOhdGjQg5lSQoxsM7PtqRLS9HoEXKuaH7MrhmHlZTlYvSe/82FtBGbJUtd9gwrOc3LiV0O1bqXRBVKjo5JqM8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787673714; c=relaxed/simple; bh=BsTPxyygLXUKMXJAMfGekLm53saVsq5rT05dTlu4Xjk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=NxPn4v29HajHg0z2XuyB8GtvcpvP9rSb5axoYRI5uQhgvqFC7KbfFILbLC95YDv7PiFUkfmEMk3J5bOg4gGrYFgzklK+9R4pGrgKG2JoXPk+RUZhECNFKoUsLUjOePP1bD7ppUxSgIS3TXEbSO+ZMKPXcy3alBBL4G7Qf1qTGqs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XVEOtA9R; arc=none smtp.client-ip=209.85.160.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XVEOtA9R" Received: by mail-oa1-f42.google.com with SMTP id 586e51a60fabf-446f87b6de1so6706432fac.3 for ; Tue, 25 Aug 2026 09:01:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787673712; x=1788278512; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=71qtE/tuNjStbed1ClM4oY0bkXkCzbaUZmwhucnlGc0=; b=XVEOtA9RLWsqaZMnMvWCKJ6t5U+F7UkW9IcYUtljztI3rh5+c89Zi5n53A7MYqR4zA nJWUDTAcpuXoT5zZ7F501pTbjGRn4T2pnv/hHLLVGjsRhIVvIvrYBOEmiQbME5INNiTy 075HrkLbREHSP4piQKj5YUjBSqKFxalkzWHO2LRjU8G0+AngV8LfApxgPkdbbjqNV2vD eLmlyg/SI7bcFwsiZp7NgP4KL/lc2UV3XWF9QvLp+PSKrKaGGQs876Qo2IvdwkH8tWpZ ql6FNmkq4hLe0CxwEqIKfu+o42MhoL2WKoVwXytw8GeSiWzNNtHKeuuGoOyf0mjIXeed Klcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787673712; x=1788278512; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=71qtE/tuNjStbed1ClM4oY0bkXkCzbaUZmwhucnlGc0=; b=hL8bDpdEiTcqdvNx+yZEOTZdLKp71lX0aq1QxHVw1jlMdNDYWuvK98+m7C6RUatmfb zCZGwt6+4KjOPShh0VkZAWTateCdr8BAzV89Rt9sUsanMlNzcjVq/BNcBT9QWDXzC6V0 +lpahNFww4so0sqM+4wdYYauH1j5x3tiYemUGvZJoXJ/cQOFdlCimadkzAqFwFIqAbGF bLcf/K3/UIL98TDPm49L3sFr7wpIGenDwauXqHVx7lnXQ9oLv8MAWGsn6MMOl3KQE7s2 eQKQDn09dZs7KG66OAybXRswRXkPDJLKvJFgo6jHeWoPm6yUSuIrZOQjrUIQFia+xh5m rxTg== X-Gm-Message-State: AFuF++lkl5sxRAoYYfW5/ztD7Oio0QFUImI7+X59wQpwF7mWq30V7AnT sJnfmea+nbU7qKOeEEDjKVBRB31j/vfPAtCyEIK+E7vCMJ0RVzzjS7SObxalfixfsUTboayV X-Gm-Gg: AR+sD11FR4b5psKoIoeixvMcX6rKmbKo6fQJjVbiQbFuLZS/iW57MBpMv3+4+A9p+w3 NHOlwpuM452wZNRgU7cNDaVYXOA4a2OddI34db7ofWp4IxichXnYbh+gpyHAxw2/hbtRB3ofJVy ODNqRNXKL6ijVQz6OjO7iHUSj1/P1U1P/NFAya6ndm5D707zpcKZzJXfKpkBU+lYr1B9+U43XOW wVmvSFgtmN17VZgi96MU+KRi5r4wVa1Oi5od2XNm4/vIwWuQq4bjxP/VgWAecwlPPEQHRcjVj9Z d+anHnaP6AG+GlO+3lAsamBimiNWesOoKyG7y+urtiPxF0Uploj0bxcMbYYOSDoi2tk2lHKCLiD 8jBFAOlIKn6GIA51cBeE0mozpyPzCqxxqjDM5+OZWeen/VtSujWuoq60hoULGvTr1yFXk0KzL0b R9pQYQDbL87voVbBp6VcnUH8ulxTw5hng0+P3OXx67uk3j7JAHgrpFfhH/fScKKS7X0oHmrBCyb DmeIXDjQRO1U/aI7w== X-Received: by 2002:a05:6820:2e83:b0:6b1:44e2:9d00 with SMTP id 006d021491bc7-6b15942226bmr22680778eaf.33.1787673711744; Tue, 25 Aug 2026 09:01:51 -0700 (PDT) Received: from localhost.localdomain ([103.210.91.47]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-141a8f20036sm387703c88.5.2026.08.25.09.01.46 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 25 Aug 2026 09:01:50 -0700 (PDT) From: Khawar Ahemad To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, jhs@mojatatu.com, jiri@resnulli.us, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, ahemadkhawar123@gmail.com Subject: [PATCH net-next] net/sched: act_sample: reset truncation settings on action replace Date: Tue, 25 Aug 2026 21:31:43 +0530 Message-ID: <20260825160143.86866-1-ahemadkhawar123@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When replacing an existing sample action, if TCA_SAMPLE_TRUNC_SIZE is not passed in the netlink request, s->truncate and s->trunc_size retain their previous values from the prior configuration. As a result, a user cannot disable packet truncation when replacing a sample action unless the action is fully deleted and recreated. In addition, the hardware offload state and netlink dump continue to report truncation as active. Fix this by explicitly resetting s->truncate to false and s->trunc_size to 0 when TCA_SAMPLE_TRUNC_SIZE is omitted during tcf_sample_init(). Fixes: 5c56784d852a ("net/sched: act_sample: add support for packet truncation") Signed-off-by: Khawar Ahemad --- net/sched/act_sample.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/sched/act_sample.c b/net/sched/act_sample.c index 2ceb4d141b..2bdc7a0eb6 100644 --- a/net/sched/act_sample.c +++ b/net/sched/act_sample.c @@ -116,6 +116,9 @@ static int tcf_sample_init(struct net *net, struct nlattr *nla, if (tb[TCA_SAMPLE_TRUNC_SIZE]) { s->truncate = true; s->trunc_size = nla_get_u32(tb[TCA_SAMPLE_TRUNC_SIZE]); + } else { + s->truncate = false; + s->trunc_size = 0; } spin_unlock_bh(&s->tcf_lock); -- 2.54.0 (Apple Git-157)