[Buildroot] [PATCH v3 1/3] support/scripts/check-host-rpath: fix shellcheck issues

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Fixes:

In ./support/scripts/check-host-rpath line 21:
    while read file; do
          ^--^ SC2162 (info): read without -r will mangle backslashes.

In ./support/scripts/check-host-rpath line 62:
    while read lib; do
          ^--^ SC2162 (info): read without -r will mangle backslashes.

In ./support/scripts/check-host-rpath line 90:
    while read rpath; do
          ^--^ SC2162 (info): read without -r will mangle backslashes.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
Changes since v2:
- New in v3
---
 .checkpackageignore              | 1 -
 support/scripts/check-host-rpath | 6 +++---
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/.checkpackageignore b/.checkpackageignore
index c3ec943075..3cf8cabece 100644
--- a/.checkpackageignore
+++ b/.checkpackageignore
@@ -997,7 +997,6 @@ support/libtool/buildroot-libtool-v2.4.patch lib_patch.ApplyOrder lib_patch.Sob
 support/misc/relocate-sdk.sh Shellcheck
 support/scripts/apply-patches.sh Shellcheck
 support/scripts/check-bin-arch Shellcheck
-support/scripts/check-host-rpath Shellcheck
 support/scripts/expunge-gconv-modules Shellcheck
 support/scripts/fix-configure-powerpc64.sh lib_shellscript.EmptyLastLine
 support/scripts/generate-gitlab-ci-yml Shellcheck
diff --git a/support/scripts/check-host-rpath b/support/scripts/check-host-rpath
index 41aa0aa1ed..7b48af42ca 100755
--- a/support/scripts/check-host-rpath
+++ b/support/scripts/check-host-rpath
@@ -18,7 +18,7 @@ main() {
     hostdir="$( sed -r -e 's:/+:/:g; s:/$::;' <<<"${hostdir}" )"
 
     ret=0
-    while read file; do
+    while read -r file; do
         is_elf "${file}" || continue
         elf_needs_rpath "${file}" "${hostdir}" || continue
         check_elf_has_rpath "${file}" "${hostdir}" "${perpackagedir}" && continue
@@ -59,7 +59,7 @@ elf_needs_rpath() {
     local hostdir="${2}"
     local lib
 
-    while read lib; do
+    while read -r lib; do
         [ -e "${hostdir}/lib/${lib}" ] && return 0
     done < <( readelf -d "${file}" 2>/dev/null                             \
               |sed -r -e '/^.* \(NEEDED\) .*Shared library: \[(.+)\]$/!d;' \
@@ -87,7 +87,7 @@ check_elf_has_rpath() {
     local perpackagedir="${3}"
     local rpath dir
 
-    while read rpath; do
+    while read -r rpath; do
         for dir in ${rpath//:/ }; do
             # Remove duplicate and trailing '/' for proper match
             dir="$( sed -r -e 's:/+:/:g; s:/$::;' <<<"${dir}" )"
-- 
2.55.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot