From: Greg KH <gregkh@linuxfoundation.org>
To: Dmitry Priz <dimahtms@gmail.com>
Cc: dtwlin@gmail.com, johan@kernel.org, elder@kernel.org,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: uart: convert from IDR to XArray
Date: Tue, 25 Aug 2026 17:35:20 +0200 [thread overview]
Message-ID: <2026082527-garland-buffer-306a@gregkh> (raw)
In-Reply-To: <20260810141043.76948-1-dimahtms@gmail.com>
On Mon, Aug 10, 2026 at 05:10:43PM +0300, Dmitry Priz wrote:
> IDR is deprecated in favor of XArray, which manages its own
> internal locking and provides a more consistent allocation API.
Which is fine, but:
> Convert tty_minors from an IDR to an allocating XArray. Update
> the error check in gb_uart_probe() from -ENOSPC to -EBUSY, since
> that is the error xa_alloc() returns when the allocation range
> is exhausted, unlike idr_alloc() which returned -ENOSPC.
This isn't needed at all. idr is just fine for a minor number
allocation, an xarray is total overkill.
Sorry, but this keeps coming up on the list, what tool made you want to
do this conversion?
> Build-tested and verified via boot in QEMU: the module loads,
> registers with the greybus core, and unloads cleanly.
But you don't actually test it such that this codepath gets used, right?
thanks,
greg k-h
prev parent reply other threads:[~2026-08-25 15:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-10 14:10 [PATCH] staging: greybus: uart: convert from IDR to XArray Dmitry Priz
2026-08-25 15:35 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026082527-garland-buffer-306a@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dimahtms@gmail.com \
--cc=dtwlin@gmail.com \
--cc=elder@kernel.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.