Re: [PATCH v4 09/10] dtc: dt-check-style: Add warning for redundant white-spaces

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] The regular expression `r'(\s\s+|\t){'` uses an unescaped `{` character immediately after a capturing group. In Python 3.11+, the `re` module enforces strict parsing and treats this as a malformed repetition operator, raising `re.error`. This unconditionally crashes the `dt-check-style` script upon execution.
- [Low] The redundant whitespace checks do not validate continuation lines of multi-line properties, causing them to silently miss styling violations.
--

commit 2e1d4b87b1d575d09206e54554a02623ac0f7700
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

dtc: dt-check-style: Add warning for redundant white-spaces

Show warnings of too many spaces around '=', before '{' and ';' characters,
or using tabs for these. Both in-tree DTS and DT bindings have many warnings
for the first case, thus keep this one only for 'strict' mode.

> diff --git a/scripts/dtc/dt-check-style b/scripts/dtc/dt-check-style
> index dd3828b146385..e67ba1e5164a7 100755
> --- a/scripts/dtc/dt-check-style
> +++ b/scripts/dtc/dt-check-style
> @@ -349,6 +349,36 @@ def check_trailing_whitespace(ctx):
>              yield (dl.lineno, 'trailing whitespace')
>  
>  
> +def check_redundant_whitespace(ctx):
> +    """No whitespace between brackets or other code elements.
> +    See also check_value_whitespace() for more checks."""
> +    for dl in ctx.lines:

[Severity: Low]
Does this code silently miss styling violations on multi-line properties?

Because the loop only iterates over ctx.lines, it appears to bypass nested 
continuation lines (dl.continuations). If a violation, such as extra spaces
before a semicolon, occurs on a continuation line, it won't be checked.

> +        if dl.linetype in (LineType.COMMENT, LineType.COMMENT_BODY,
> +                           LineType.COMMENT_END, LineType.COMMENT_START,
> +                           LineType.PREPROCESSOR):
> +            continue
> +        if re.search(r'(\s\s+|\t){', dl.code):

[Severity: High]
Does this unescaped curly brace crash the script in newer Python versions?

In Python 3.11+, the re module enforces strict parsing and treats an
unescaped { immediately after a capturing group as a malformed repetition
operator, raising re.error. This will break the dt_binding_check build
process unconditionally for users on newer Python versions.

> +            yield (dl.lineno, 'extra whitespace before {')
> +        if re.search(r':(\s\s+|\t)', dl.code):
> +            yield (dl.lineno, 'extra whitespace after :')
> +        if re.search(r'\s+;', dl.code):
> +            yield (dl.lineno, 'extra whitespace before ;')
> +
> +
> +def check_redundant_whitespace_strict(ctx):
> +    """No whitespace between brackets or other code elements.
> +    See also check_value_whitespace() for more checks."""
> +    for dl in ctx.lines:

[Severity: Low]
Is there a similar issue here with skipping continuation lines? 

Like check_redundant_whitespace, this strict check loop ignores
continuation lines, meaning violations on multi-line properties will
be missed here as well.

> +        if dl.linetype in (LineType.COMMENT, LineType.COMMENT_BODY,
> +                           LineType.COMMENT_END, LineType.COMMENT_START,
> +                           LineType.PREPROCESSOR):
> +            continue

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260826-n-dts-style-checker-continued-v4-0-022e60091965@oss.qualcomm.com?part=9