From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1465EC61DBE for ; Wed, 26 Aug 2026 10:42:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 51D0110E040; Wed, 26 Aug 2026 10:42:09 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=igalia.com header.i=@igalia.com header.b="hWxisL0V"; dkim-atps=neutral Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) by gabe.freedesktop.org (Postfix) with ESMTPS id C4F4389D30; Wed, 26 Aug 2026 10:42:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: Date:Subject:Cc:To:From:From:Reply-To; bh=NGMuIiK+XsvQypbXlrNrUKxRlPXbYl1b27mEi1oUfXA=; b=hWxisL0Vi+yS740ng/0Rp7ZWpt mE8wJ/7b3db9fbAnGg3H0HMJqGfxuyHKj9DLdyOl6t4HEeZIjbVGfpUpiMibxG8VUIU4mK1DfOOxX gvCkOUeF+F0LITjDh46FfiCmi8zhYr/o8QbB4+gxcQXqJhv66XeZyO6yUtqfuKfNEOAAvIOkKZo1/ DCSZvVlFhZI2fOrWn2H4u7rGeKTiDkmWG1wSYwdAJbrjU6Q0JRlJmajj/vHL75FC1D78INs8xcO6M LPu38f3bixpFuvqZio+GosTORAKNFEWw15Oi0I6T+2eiaimv9Njun/UGDyxm6/J+yG5enLPh9DMZl 65Lszs3g==; Received: from 154.red-79-147-121.dynamicip.rima-tde.net ([79.147.121.154] helo=killbill) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1wzB4k-009Uut-7s; Wed, 26 Aug 2026 12:41:46 +0200 From: Melissa Wen To: airlied@gmail.com, alexander.deucher@amd.com, christian.koenig@amd.com, daniels@collabora.com, harry.wentland@amd.com, leandro.ribeiro@collabora.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, pekka.paalanen@collabora.com, simona@ffwll.ch, siqueira@igalia.com, sunpeng.li@amd.com, tzimmermann@suse.de Cc: Alex Hung , Daniel Wheeler , kernel-dev@igalia.com, Lyude Paul , =?UTF-8?q?Viktor=20J=C3=A4gersk=C3=BCpper?= , =?UTF-8?q?Timur=20Krist=C3=B3f?= , Mikhail Gavrilov , Xaver Hugl , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH v4 0/3] drm/atomic-state-helper: fixes for blend-mode-prop warning Date: Wed, 26 Aug 2026 12:37:04 +0200 Message-ID: <20260826104143.39077-1-mwen@igalia.com> X-Mailer: git-send-email 2.53.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" PREMULTI was the default DRM blend mode until 9813e158d13d ("drm/drm_blend: allow blend mode property without PREMULTI") introduced the possibility of exposing the blend mode property without PREMULTI being supported. However, __drm_atomic_helper_plane_state_init() still resets pixel_blend_mode to PREMULTI (hardcoded), ignoring the supported mode in this property. In the same series, 860e748bddcc ("drm: ensure blend mode supported if pixel format with alpha exposed") starts warning drivers that supports alpha formats in a given planes but doesn't support blend mode property, which includes AMD primary and cursor planes. For AMD DCN families, overlay and primary planes support the three blend modes, and therefore PREMULTI is still the default mode. So the warning can be fixed by just creating blend mode properties for primary planes too. PREMULTI is the default/unique mode for cursor planes in DCN and DCE driver. However, looks like PIXEL_NONE is the unique blend mode supported by DCE-generation driver. I don't have the hardware to check it out, but looking at the code I understand that, even if the hardware can do PREMULTI or COVERAGE, the way it programs registers doesn't make these other blend modes actually available. Bearing this in mind, this series is organized as follow: - Patch 1 fixes the pixel_blend_mode reset when the blend mode property is advertised without PREMULTI support. It's needed for AMD DCE-generation (patch 3) and I think with this we can also remove a workaround in nouveau nv50_wndw_default_state() caused by the hardcoded PREMULTI default value [1]. - Patch 2 fixes the missing-blend-mode-property warning for DCN primary plane and for DCN+DCE cursor plane. The alpha property keeps only on overlay planes because looks like this is not supported by AMD primary planes and it doesn't affect the blend mode warning we are targetting. Enabling alpha properties to primary was also causing -EINVAL on IGT alpha tests because it started testing primary planes and disabling it (which is not allowed by the AMD display driver). - Patch 3 fixes the warning for DCE primary plane, but I detached this solution from the previous patch because I don't have hardware to validate if my assumption about PIXEL_NONE-only is correct. Also, I added PREMULTI to the list of supported blend mode to avoid uAPI regressions since it was the required/default mode for many years and, without overlay plane, PIXEL_NONE and PREMULTI are equivalent for primary on top of a black blackground. [1] https://lore.kernel.org/dri-devel/20260720215058.398210-3-lyude@redhat.com/ [v1]: https://lore.kernel.org/dri-devel/20260722183240.626522-1-mwen@igalia.com/ Changes: - new patch for pixel_blend_mode default value other than PREMULTI. - remove DCE11 which supports per_pixel_alpha but doesn't support DCN_UNIVERSAL_PLANE. - new patch for the primary plane blend mode on DCE-generations [v2]: https://lore.kernel.org/dri-devel/20260804140758.107683-1-mwen@igalia.com/ Changes: - keep alpha property only for overlay planes (looks like primary plane doesn't actually support it) - alpha prop in primary planes causes IGT test failures with RX 7900 XT on a 4k60 HP U27 as reported by Daniel Wheeler. - improve readability of if conditions (Alex H) - add Leandro's r-b tags. [v3]: https://lore.kernel.org/dri-devel/20260813143605.106104-1-mwen@igalia.com/ Changes: - add Daniel's, Mikhail's and Viktor's tested-by tag, accordingly - add Alex H r-b tag - add PREMULTI to the DCE list of supported blend modes to avoid uAPI regression reported by Viktor. Best Regards, Melissa Melissa Wen (3): drm/atomic-state-helper: set pixel_blend_mode to prop default on reset drm/amd/display: fix missing blend-mode-prop warning for DCN drm/amd/display: advertise PIXEL_NONE and PREMULTI blend mode for DCE .../amd/display/amdgpu_dm/amdgpu_dm_plane.c | 31 +++++++++++++++++-- drivers/gpu/drm/drm_atomic_state_helper.c | 7 +++++ 2 files changed, 35 insertions(+), 3 deletions(-) -- 2.53.0