From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 67891C61DBE for ; Wed, 26 Aug 2026 10:52:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OYoOKcuHiCwiuKgupmBPpz05zhp+WOI+nxM0vSHvpwI=; b=N9MpmpQcfpqhId QMibt+OCBa/I+BWpvGl0oe/WiX8T343j4JqHbqbUle2dXBcqDNf3IaisJ12+akLGDGDu5EVU/2z/J Fcv1xZh8lgRcwiNQjvbFbZ/JvTrt88BbkB2GzQfXlB5GLVql0qytmCw0OYAdCklNL+OkUUeYX0ty+ 254cfEOpFcxOIMrdS3wTbC/Daeic0W1nxyF6paGaMJKZ7Tc7xrhSZ9Xcy0grGm5ievG/Rw7xaw7F5 l7TXQWDfi/QYDb+glpc6PHQMVvctMJB554UG1JR7KPHVv/5789LVmWnDMbDdryRR41HHAQTJHuy4H a1npISZdJp77XGmB+Xxw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wzBFM-00000002K1G-0UEW; Wed, 26 Aug 2026 10:52:44 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wzBFL-00000002K1A-0lwx for linux-i3c@lists.infradead.org; Wed, 26 Aug 2026 10:52:43 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 9AB49601E9; Wed, 26 Aug 2026 10:52:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E2BF91F000E9; Wed, 26 Aug 2026 10:52:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787741562; bh=abZ99My9Qae/qtii2IQ4mJ0HjFfZtD/2RL9o4UAtJ5w=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=SWAfIOsBePrtq4vmnGb9PifQxA/N0Up2Cyc8qWJCkAE5mD5drTpQijA2FZs+IHrCK FpeXHgrhF3ZKdXdANUoDXUSZckt0Jf27C98URk2Y0tR5z+LX0D6fHWRoR5yC8H3Kha 7e0EEnW1ceBLAKZZTWUFLnU8uSRCZ+YFCq9JMu2VhHprzgcSPmMdDZC53x+8idOLDG jH/NBCKKqZ/jX9X/5CfA5r4pxMZmgu89LKpBECePK5RtIIU+kCjcg950/LnpiDshWi XorfAOIYtsc+K3WHYyzurp2Zh3XaU9wkBl72FCExhy2OgX17vV9nX8yuvWKGcJGupW SuRmWdSJfcuEQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v16 1/8] i3c: master: Add APIs for I3C hub support To: "Lakshay Piplani" Cc: robh@kernel.org, conor+dt@kernel.org, "Alexandre Belloni" , Frank.Li@kernel.org, linux-i3c@lists.infradead.org, devicetree@vger.kernel.org In-Reply-To: <20260826103819.1614843-2-lakshay.piplani@nxp.com> References: <20260826103819.1614843-1-lakshay.piplani@nxp.com> <20260826103819.1614843-2-lakshay.piplani@nxp.com> Date: Wed, 26 Aug 2026 10:52:41 +0000 Message-Id: <20260826105241.E2BF91F000E9@smtp.kernel.org> X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6CgpQcmUtZXhpc3RpbmcgaXNzdWVzOgot IFtIaWdoXSBGYWlsdXJlIGluIGkzY19idXNfaW5pdCgpIGNhdXNlcyBpM2NfbWFzdGVyZGV2X3Jl bGVhc2UoKSB0byBlcnJvbmVvdXNseSByZW1vdmUgSUQgMCBmcm9tIHRoZSBJRFIuCi0tCgpjb21t aXQgMWYwODllMzE0MWY1YTYzNWRmMzNkMjI3M2Q3ZGUyMTE0YjJmNmVmNQpBdXRob3I6IEFtYW4g S3VtYXIgUGFuZGV5IDxhbWFuLmt1bWFycGFuZGV5QG54cC5jb20+CgogICAgaTNjOiBtYXN0ZXI6 IEFkZCBBUElzIGZvciBJM0MgaHViIHN1cHBvcnQKICAgIAogICAgQWRkIENDQyBoZWxwZXJzIHRv IGNoZWNrIENDQyBzdXBwb3J0IGFuZCBzZW5kIENDQyBjb21tYW5kcywgYWRkcmVzcyBzbG90CiAg ICBoZWxwZXJzIHRvIHF1ZXJ5IGFuZCB1cGRhdGUgSTNDIGJ1cyBhZGRyZXNzIHNsb3Qgc3RhdGUs IHJlZ2lzdGVyaW5nIHZpcnR1YWwKICAgIG1hc3RlcnMgd2l0aCBhbiBleHBsaWNpdCBmaXJtd2Fy ZSBub2RlLCBhbmQgZXhwb3NpbmcgdGhlIGJ1cyBtYWludGVuYW5jZQogICAgbG9jayBoZWxwZXJz LgoKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9pM2MvbWFzdGVyLmMgYi9kcml2ZXJzL2kzYy9tYXN0 ZXIuYwo+IGluZGV4IGYxYmUzOGE2NDBjYTEuLjAzZmI0MWYwNzg2YzUgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9pM2MvbWFzdGVyLmMKPiArKysgYi9kcml2ZXJzL2kzYy9tYXN0ZXIuYwoKWyAuLi4g XQoKPiBAQCAtMzE5NSwzNCArMzI2NywzMSBAQCBzdGF0aWMgaW50IGkzY19tYXN0ZXJfY2hlY2tf b3BzKGNvbnN0IHN0cnVjdCBpM2NfbWFzdGVyX2NvbnRyb2xsZXJfb3BzICpvcHMpCj4gIH0KPiAg Cj4gIC8qKgo+IC0gKiBpM2NfbWFzdGVyX3JlZ2lzdGVyKCkgLSByZWdpc3RlciBhbiBJM0MgbWFz dGVyCj4gKyAqIGkzY19tYXN0ZXJfcmVnaXN0ZXJfZndub2RlKCkgLSByZWdpc3RlciBhbiBJM0Mg bWFzdGVyIHdpdGggYSBjdXN0b20gZndub2RlCj4gICAqIEBtYXN0ZXI6IG1hc3RlciB1c2VkIHRv IHNlbmQgZnJhbWVzIG9uIHRoZSBidXMKPiAtICogQHBhcmVudDogdGhlIHBhcmVudCBkZXZpY2Ug KHRoZSBvbmUgdGhhdCBwcm92aWRlcyB0aGlzIEkzQyBtYXN0ZXIKPiAtICoJICAgIGNvbnRyb2xs ZXIpCj4gKyAqIEBwYXJlbnQ6IHRoZSBwYXJlbnQgZGV2aWNlIHByb3ZpZGluZyB0aGlzIEkzQyBt YXN0ZXIgY29udHJvbGxlcgo+ICsgKiBAZndub2RlOiBmaXJtd2FyZSBub2RlIGRlc2NyaWJpbmcg dGhpcyBJM0MgYnVzLCBvciBOVUxMCj4gICAqIEBvcHM6IHRoZSBtYXN0ZXIgY29udHJvbGxlciBv cGVyYXRpb25zCj4gLSAqIEBzZWNvbmRhcnk6IHRydWUgaWYgeW91IGFyZSByZWdpc3RlcmluZyBh IHNlY29uZGFyeSBtYXN0ZXIuIFdpbGwgcmV0dXJuCj4gLSAqCSAgICAgICAtRU9QTk9UU1VQUCBp ZiBzZXQgdG8gdHJ1ZSBzaW5jZSBzZWNvbmRhcnkgbWFzdGVycyBhcmUgbm90IHlldAo+IC0gKgkg ICAgICAgc3VwcG9ydGVkCj4gKyAqIEBzZWNvbmRhcnk6IHRydWUgaWYgcmVnaXN0ZXJpbmcgYSBz ZWNvbmRhcnkgbWFzdGVyCgpbIC4uLiBdCgo+IEBAIC0zMzUyLDYgKzM0MjcsMzkgQEAgaW50IGkz Y19tYXN0ZXJfcmVnaXN0ZXIoc3RydWN0IGkzY19tYXN0ZXJfY29udHJvbGxlciAqbWFzdGVyLAo+ ICAKPiAgCXJldHVybiByZXQ7Cj4gIH0KPiArRVhQT1JUX1NZTUJPTF9HUEwoaTNjX21hc3Rlcl9y ZWdpc3Rlcl9md25vZGUpOwoKW1NldmVyaXR5OiBIaWdoXQpUaGlzIGlzIGEgcHJlLWV4aXN0aW5n IGlzc3VlLCBidXQgY2FuIGEgZmFpbHVyZSBpbiBpM2NfYnVzX2luaXQoKSBjYXVzZQppM2NfbWFz dGVyZGV2X3JlbGVhc2UoKSB0byBlcnJvbmVvdXNseSByZW1vdmUgSUQgMCBmcm9tIHRoZSBJRFI/ CgpJZiBpZHJfYWxsb2MoKSBmYWlscyBpbiBpM2NfYnVzX2luaXQoKSwgaTNjYnVzLT5pZCByZW1h aW5zIDAuIFRoZSBlcnJvcgpwYXRoIGluIGkzY19tYXN0ZXJfcmVnaXN0ZXJfZndub2RlKCkgYnJh bmNoZXMgdG8gZXJyX3B1dF9kZXYsIGNhbGxpbmcKcHV0X2RldmljZSgpLCB3aGljaCBpbnZva2Vz IGkzY19tYXN0ZXJkZXZfcmVsZWFzZSgpIGFuZCB1bmNvbmRpdGlvbmFsbHkKY2FsbHMgaTNjX2J1 c19jbGVhbnVwKCkuCgpUaGlzIGV4ZWN1dGVzIGlkcl9yZW1vdmUoJmkzY19idXNfaWRyLCAwKSwg cmVtb3Zpbmcgd2hhdGV2ZXIgdmFsaWQgYnVzCmhhcHBlbnMgdG8gb3duIElEIDAuIFRoaXMgY29y cnVwdHMgdGhlIElEUiwgYnJlYWtpbmcgYnVzIGxvb2t1cHMgZm9yIGJ1cyAwCmFuZCBwb3RlbnRp YWxseSBsZWFkaW5nIHRvIGEgdXNlLWFmdGVyLWZyZWUgb3IgYSBkb3VibGUgYWxsb2NhdGlvbiBv ZiBJRCAwCmxhdGVyLgoKLS0gClNhc2hpa28gQUkgcmV2aWV3IMK3IGh0dHBzOi8vc2FzaGlrby5k ZXYvIy9wYXRjaHNldC8yMDI2MDgyNjEwMzgxOS4xNjE0ODQzLTEtbGFrc2hheS5waXBsYW5pQG54 cC5jb20/cGFydD0xCgotLSAKbGludXgtaTNjIG1haWxpbmcgbGlzdApsaW51eC1pM2NAbGlzdHMu aW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2xpbnV4LWkzYwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95CF83E3156 for ; Wed, 26 Aug 2026 10:52:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787741569; cv=none; b=d2DG3yexGbJyHfhHnTGDvalzWz2+uzIavkw9FNtV2o8z6jS4EUi/DByP0+iR6X6HIVsDlkytoGyZK3HZvdvRLqX2d2alk2J6rIb6zeC05RP4VtfvbGDHjaXhv2n3h6Mm3BPXGJCM+/j9reth527X2LDWgU5x9uUUkPI7h5kSKXM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787741569; c=relaxed/simple; bh=H/P0/OKywne6byVHECm6KCdWcF+LcQSCv0bo6NlHHYw=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=cZV64rQ/DgiaLZbkL0YRqzqz/aWe6bQfFLvPVWSPnSAt5Q/tPVFTZmdDUnN2gWmaMEwzSI5ItiMZdKhlLl1rn/6YQXOme+oywSyJqutpl6QSrygz8q+1Xa5domdL5dyRizHFjYNtVB1yJlhlDJYTRhJKq3piWaCubdZbU3QmiHI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SWAfIOsB; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SWAfIOsB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E2BF91F000E9; Wed, 26 Aug 2026 10:52:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787741562; bh=abZ99My9Qae/qtii2IQ4mJ0HjFfZtD/2RL9o4UAtJ5w=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=SWAfIOsBePrtq4vmnGb9PifQxA/N0Up2Cyc8qWJCkAE5mD5drTpQijA2FZs+IHrCK FpeXHgrhF3ZKdXdANUoDXUSZckt0Jf27C98URk2Y0tR5z+LX0D6fHWRoR5yC8H3Kha 7e0EEnW1ceBLAKZZTWUFLnU8uSRCZ+YFCq9JMu2VhHprzgcSPmMdDZC53x+8idOLDG jH/NBCKKqZ/jX9X/5CfA5r4pxMZmgu89LKpBECePK5RtIIU+kCjcg950/LnpiDshWi XorfAOIYtsc+K3WHYyzurp2Zh3XaU9wkBl72FCExhy2OgX17vV9nX8yuvWKGcJGupW SuRmWdSJfcuEQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v16 1/8] i3c: master: Add APIs for I3C hub support Reply-To: sashiko-reviews@lists.linux.dev To: "Lakshay Piplani" Cc: robh@kernel.org, conor+dt@kernel.org, "Alexandre Belloni" , Frank.Li@kernel.org, linux-i3c@lists.infradead.org, devicetree@vger.kernel.org In-Reply-To: <20260826103819.1614843-2-lakshay.piplani@nxp.com> References: <20260826103819.1614843-1-lakshay.piplani@nxp.com> <20260826103819.1614843-2-lakshay.piplani@nxp.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Wed, 26 Aug 2026 10:52:41 +0000 Message-Id: <20260826105241.E2BF91F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: Pre-existing issues: - [High] Failure in i3c_bus_init() causes i3c_masterdev_release() to errone= ously remove ID 0 from the IDR. -- commit 1f089e3141f5a635df33d2273d7de2114b2f6ef5 Author: Aman Kumar Pandey i3c: master: Add APIs for I3C hub support =20 Add CCC helpers to check CCC support and send CCC commands, address slot helpers to query and update I3C bus address slot state, registering vir= tual masters with an explicit firmware node, and exposing the bus maintenance lock helpers. > diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c > index f1be38a640ca1..03fb41f0786c5 100644 > --- a/drivers/i3c/master.c > +++ b/drivers/i3c/master.c [ ... ] > @@ -3195,34 +3267,31 @@ static int i3c_master_check_ops(const struct i3c_= master_controller_ops *ops) > } > =20 > /** > - * i3c_master_register() - register an I3C master > + * i3c_master_register_fwnode() - register an I3C master with a custom f= wnode > * @master: master used to send frames on the bus > - * @parent: the parent device (the one that provides this I3C master > - * controller) > + * @parent: the parent device providing this I3C master controller > + * @fwnode: firmware node describing this I3C bus, or NULL > * @ops: the master controller operations > - * @secondary: true if you are registering a secondary master. Will retu= rn > - * -EOPNOTSUPP if set to true since secondary masters are not yet > - * supported > + * @secondary: true if registering a secondary master [ ... ] > @@ -3352,6 +3427,39 @@ int i3c_master_register(struct i3c_master_controll= er *master, > =20 > return ret; > } > +EXPORT_SYMBOL_GPL(i3c_master_register_fwnode); [Severity: High] This is a pre-existing issue, but can a failure in i3c_bus_init() cause i3c_masterdev_release() to erroneously remove ID 0 from the IDR? If idr_alloc() fails in i3c_bus_init(), i3cbus->id remains 0. The error path in i3c_master_register_fwnode() branches to err_put_dev, calling put_device(), which invokes i3c_masterdev_release() and unconditionally calls i3c_bus_cleanup(). This executes idr_remove(&i3c_bus_idr, 0), removing whatever valid bus happens to own ID 0. This corrupts the IDR, breaking bus lookups for bus 0 and potentially leading to a use-after-free or a double allocation of ID 0 later. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260826103819.1614= 843-1-lakshay.piplani@nxp.com?part=3D1