From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Kendall Willis <k-willis@ti.com>, Tony Lindgren <tony@atomide.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Peter Hurley <peter@hurleysoftware.com>,
s-kochidanadu@ti.com, a-kaur@ti.com, s-tripathi1@ti.com,
vishalm@ti.com, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2] serial: 8250_omap: fix wake irq cleared during suspend
Date: Wed, 26 Aug 2026 16:53:07 +0200 [thread overview]
Message-ID: <20260826145307.4GWTzB5f@linutronix.de> (raw)
In-Reply-To: <20260825-uart-wakeirq-fix-v2-1-0b9fba03d9b6@ti.com>
On 2026-08-25 17:06:07 [-0500], Kendall Willis wrote:
> The wake irq was cleared in shutdown(), which runs during the suspend
> sequence, making it impossible to wake the system via UART.
> Move wake irq setup to probe() and teardown to remove() so the irq
> remains armed during suspend when the UART is a wakeup source.
The omap-serial has the same problem, doesn't it?
I would still like to see an ACK from Tony here.
> Cc: stable@vger.kernel.org
> Fixes: 61929cf0169d ("tty: serial: Add 8250-core based omap driver")
> Signed-off-by: Kendall Willis <k-willis@ti.com>
Sebastian
next prev parent reply other threads:[~2026-08-26 14:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-25 22:06 [PATCH v2] serial: 8250_omap: fix wake irq cleared during suspend Kendall Willis
2026-08-25 22:17 ` sashiko-bot
2026-08-26 14:53 ` Sebastian Andrzej Siewior [this message]
2026-08-28 7:07 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260826145307.4GWTzB5f@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=a-kaur@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=k-willis@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=peter@hurleysoftware.com \
--cc=s-kochidanadu@ti.com \
--cc=s-tripathi1@ti.com \
--cc=stable@vger.kernel.org \
--cc=tony@atomide.com \
--cc=vishalm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.