From: Heiko Carstens <hca@linux.ibm.com>
To: Ilya Leoshkevich <iii@linux.ibm.com>
Cc: Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
David Laight <david.laight.linux@gmail.com>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] s390: Warn if kernel command line contains non-printable EBCDIC characters
Date: Wed, 26 Aug 2026 17:38:20 +0200 [thread overview]
Message-ID: <20260826153820.21444D43-hca@linux.ibm.com> (raw)
In-Reply-To: <20260826150702.949956-1-iii@linux.ibm.com>
On Wed, Aug 26, 2026 at 05:06:00PM +0200, Ilya Leoshkevich wrote:
> +static inline bool has_nonprintable_char(const char *str)
> +{
> + for (int i = 0; str[i]; i++) {
> + unsigned char c = (unsigned char)str[i];
What is the cast good for? Maybe this could be removed when applying.
Anyway, thanks!
Reviewed-by: Heiko Carstens <hca@linux.ibm.com>
prev parent reply other threads:[~2026-08-26 15:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-26 15:06 [PATCH v2] s390: Warn if kernel command line contains non-printable EBCDIC characters Ilya Leoshkevich
2026-08-26 15:18 ` sashiko-bot
2026-08-26 15:38 ` Heiko Carstens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260826153820.21444D43-hca@linux.ibm.com \
--to=hca@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=david.laight.linux@gmail.com \
--cc=gor@linux.ibm.com \
--cc=iii@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.