From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 77D34C5DF97 for ; Wed, 26 Aug 2026 10:58:57 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wzBKc-0003lz-1M; Wed, 26 Aug 2026 06:58:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wzBKa-0003lT-NF; Wed, 26 Aug 2026 06:58:08 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wzBKY-0006HQ-GR; Wed, 26 Aug 2026 06:58:08 -0400 Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67QAWrAA2616596; Wed, 26 Aug 2026 10:58:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=c9vIrgBNirW0PKt9lkqcElPAnBqSqd Kk7rIzOlvmZ18=; b=VuQ5YPZoiWyoGJ8V80qzGEimOK3oDiV+NputBF2iOGmm3c k3AEATQTdRgEdWvGdAnYuLD6qBJU2FVYMya5+Hu310akRk92INTwwpZLzTJSx7OG SYZJnguYjbfl0gR1POlsHWOjSzgj4ViSNIpSCrfjz21hFcIcG/xVyTSyidBhImvV oQDzCIA5igwxuGhrngaFnPx1IgaaW6sM4YMpFLr90cjgHbWiK5UR5OKkRyIsfiVj zW5hM2irbVaoUYbpfdS9y8LSHBaJc8Ow+PNq7DjQM7A/C5349T0KR8ExZKFhvmRJ lRK5gYBL8In03zCCkpsU8zBjONsvi9EZLrHse9AQ== Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4g726ep2rb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 26 Aug 2026 10:58:03 +0000 (GMT) Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 67QAuGJE003496; Wed, 26 Aug 2026 10:58:02 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 4g7p3q9qxq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 26 Aug 2026 10:58:02 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 67QAvxmW46596548 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 26 Aug 2026 10:57:59 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EDC972004B; Wed, 26 Aug 2026 10:57:58 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CC70020040; Wed, 26 Aug 2026 10:57:55 +0000 (GMT) Received: from fedora (unknown [9.5.7.39]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTPS; Wed, 26 Aug 2026 10:57:55 +0000 (GMT) Date: Wed, 26 Aug 2026 16:27:58 +0530 From: Amit Machhiwal To: Chinmay Rath Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, harshpb@linux.ibm.com, milesg@linux.ibm.com, npiggin@gmail.com, richard.henderson@linaro.org, vishalc@linux.ibm.com, tshah@linux.ibm.com, shivangu@linux.ibm.com, ojaswin@linux.ibm.com, aboorvad@linux.ibm.com, amachhiw@linux.ibm.com, shivani@linux.ibm.com, mkchauras@gmail.com, uverma@linux.ibm.com, nikhilks@linux.ibm.com Subject: Re: [PATCH v2 04/37] target/ppc: Move vector merge instructions to decodetree Message-ID: <20260826162734.f4434402-55-amachhiw@linux.ibm.com> Mail-Followup-To: Chinmay Rath , qemu-devel@nongnu.org, qemu-ppc@nongnu.org, harshpb@linux.ibm.com, milesg@linux.ibm.com, npiggin@gmail.com, richard.henderson@linaro.org, vishalc@linux.ibm.com, tshah@linux.ibm.com, shivangu@linux.ibm.com, ojaswin@linux.ibm.com, aboorvad@linux.ibm.com, shivani@linux.ibm.com, mkchauras@gmail.com, uverma@linux.ibm.com, nikhilks@linux.ibm.com References: <20260826050923.74756-1-rathc@linux.ibm.com> <20260826050923.74756-5-rathc@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260826050923.74756-5-rathc@linux.ibm.com> X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Authority-Analysis: v=2.4 cv=TfimcxQh c=1 sm=1 tr=0 ts=6a8ec6bc cx=c_pps a=bLidbwmWQ0KltjZqbj+ezA==:117 a=bLidbwmWQ0KltjZqbj+ezA==:17 a=kj9zAlcOel0A:10 a=Sv0fKeRqtYgA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=V8glGbnc2Ofi9Qvn3v5h:22 a=VnNF1IyMAAAA:8 a=l9WBXa9OT_98UvwR8SIA:9 a=CjuIK1q_8ugA:10 X-Proofpoint-Spam-Info: AW1haW4tMjYwODI2MDA4NyBTYWx0ZWRfX1k0FNWsDLK34 /6g1wmh2ptwLQV0Q7jl3ZJPOem+EVYSV/Js5dEcckiaPLCm3GHZu4U3/H93x64+ZGGPbJmDTmJL ZI+e2hLCiwO1naZrFnNdjrm99KGiees= X-Proofpoint-GUID: gcQcoX8gVrq806sksi00bdfYlRmb36Ci X-Proofpoint-ORIG-GUID: ck5RavwqExQbkrpr_5Bz1ZPgNRxZoy7w X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI2MDA4NyBTYWx0ZWRfX4u71/+R+28cM C9E+PkXjryRPmZTxaWlfgvYUAlYV+8j0qrigb7QzTOd54ChIL495C04vlVwhXB99Jl6H9F+SxYk 72HfoAc1DR5PHOKwXTd3vea8I7iBdPoYO/T0Ira/2xqq/I1NTpULbNsc6LRTzaKY3vWDl7Yg9Yo RiWaedbwHIqr4DxTQcCszWsbDWn6N8iuoHu/1a2TfFxVyAqoO4FJok+rYiv/PujmtyOff4+JGqC v914AbyAXKIUieWtHvxqB05pJXA6Ij4CX9YUvTeF1J4kOms9wK/qpft3rW+3fMa2SW6jC/8/OEs 3NbMN9iKoAWizT8wTeBmUHy10oxgbL7z6LDwylD37Yygz6rK7OpQW6mrq4Q95KWhVagTUlA/Bi8 6B21Qy/Rz815Ig/wT0J+VbBeqgUtLeVj9ZDAkCJ5kyH/Dz9cLgG04yYduQOUvRsXaNpbFgHn0CW cLJ5k5ojc5N7FmPlLfg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-26_03,2026-08-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 bulkscore=0 malwarescore=0 priorityscore=1501 lowpriorityscore=0 clxscore=1015 phishscore=0 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608260087 Received-SPF: pass client-ip=148.163.158.5; envelope-from=amachhiw@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 2026/08/26 10:38 AM, Chinmay Rath wrote: > From: Aboorva Devarajan > > Move below instructions to decodetree specification: > > vmrg{hb, hh, hw, lb, lh, lw} : VX-form > > The individual gen_vmrg* functions generated by GEN_VXFORM are > replaced by a shared do_vmrg() helper dispatching to the existing > gen_helper_VMRG* TCG helpers via the TRANS_FLAGS() macro, which > also handles the ALTIVEC facility check. > > The changes were verified by validating that the tcg ops generated by > those instructions remain the same, which were captured with the '-d > in_asm,op' flag. > > Signed-off-by: Aboorva Devarajan > Reviewed-by: Nikhil Kumar Singh > Reviewed-by: Glenn Miles > Signed-off-by: Chinmay Rath > --- > target/ppc/helper.h | 12 ++++++------ > target/ppc/insn32.decode | 9 +++++++++ > target/ppc/int_helper.c | 12 ++++++------ > target/ppc/translate/vmx-impl.c.inc | 25 +++++++++++++++++++------ > target/ppc/translate/vmx-ops.c.inc | 6 ------ > 5 files changed, 40 insertions(+), 24 deletions(-) Reviewed-by: Amit Machhiwal > > diff --git a/target/ppc/helper.h b/target/ppc/helper.h > index 46ad78d1d4..6db917935c 100644 > --- a/target/ppc/helper.h > +++ b/target/ppc/helper.h > @@ -173,12 +173,12 @@ DEF_HELPER_4(vcmpeqfp_dot, void, env, avr, avr, avr) > DEF_HELPER_4(vcmpgefp_dot, void, env, avr, avr, avr) > DEF_HELPER_4(vcmpgtfp_dot, void, env, avr, avr, avr) > DEF_HELPER_4(vcmpbfp_dot, void, env, avr, avr, avr) > -DEF_HELPER_FLAGS_3(vmrglb, TCG_CALL_NO_RWG, void, avr, avr, avr) > -DEF_HELPER_FLAGS_3(vmrglh, TCG_CALL_NO_RWG, void, avr, avr, avr) > -DEF_HELPER_FLAGS_3(vmrglw, TCG_CALL_NO_RWG, void, avr, avr, avr) > -DEF_HELPER_FLAGS_3(vmrghb, TCG_CALL_NO_RWG, void, avr, avr, avr) > -DEF_HELPER_FLAGS_3(vmrghh, TCG_CALL_NO_RWG, void, avr, avr, avr) > -DEF_HELPER_FLAGS_3(vmrghw, TCG_CALL_NO_RWG, void, avr, avr, avr) > +DEF_HELPER_FLAGS_3(VMRGLB, TCG_CALL_NO_RWG, void, avr, avr, avr) > +DEF_HELPER_FLAGS_3(VMRGLH, TCG_CALL_NO_RWG, void, avr, avr, avr) > +DEF_HELPER_FLAGS_3(VMRGLW, TCG_CALL_NO_RWG, void, avr, avr, avr) > +DEF_HELPER_FLAGS_3(VMRGHB, TCG_CALL_NO_RWG, void, avr, avr, avr) > +DEF_HELPER_FLAGS_3(VMRGHH, TCG_CALL_NO_RWG, void, avr, avr, avr) > +DEF_HELPER_FLAGS_3(VMRGHW, TCG_CALL_NO_RWG, void, avr, avr, avr) > DEF_HELPER_FLAGS_3(VMULESB, TCG_CALL_NO_RWG, void, avr, avr, avr) > DEF_HELPER_FLAGS_3(VMULESH, TCG_CALL_NO_RWG, void, avr, avr, avr) > DEF_HELPER_FLAGS_3(VMULESW, TCG_CALL_NO_RWG, void, avr, avr, avr) > diff --git a/target/ppc/insn32.decode b/target/ppc/insn32.decode > index 6b1cf9a0a9..8aca8a00c0 100644 > --- a/target/ppc/insn32.decode > +++ b/target/ppc/insn32.decode > @@ -795,6 +795,15 @@ VNOR 000100 ..... ..... ..... 10100000100 @VX > VXOR 000100 ..... ..... ..... 10011000100 @VX > VEQV 000100 ..... ..... ..... 11010000100 @VX > > +## Vector Merge Instructions > + > +VMRGHB 000100 ..... ..... ..... 00000001100 @VX > +VMRGHH 000100 ..... ..... ..... 00001001100 @VX > +VMRGHW 000100 ..... ..... ..... 00010001100 @VX > +VMRGLB 000100 ..... ..... ..... 00100001100 @VX > +VMRGLH 000100 ..... ..... ..... 00101001100 @VX > +VMRGLW 000100 ..... ..... ..... 00110001100 @VX > + > ## Vector Integer Average Instructions > > VAVGSB 000100 ..... ..... ..... 10100000010 @VX > diff --git a/target/ppc/int_helper.c b/target/ppc/int_helper.c > index ef4b2e75d6..a3adf746bd 100644 > --- a/target/ppc/int_helper.c > +++ b/target/ppc/int_helper.c > @@ -950,7 +950,7 @@ void helper_VMLADDUHM(ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b, ppc_avr_t *c, > } > > #define VMRG_DO(name, element, access, ofs) \ > - void helper_v##name(ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b) \ > + void helper_V##name(ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b) \ > { \ > ppc_avr_t result; \ > int i, half = ARRAY_SIZE(r->element) / 2; \ > @@ -963,11 +963,11 @@ void helper_VMLADDUHM(ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b, ppc_avr_t *c, > } > > #define VMRG(suffix, element, access) \ > - VMRG_DO(mrgl##suffix, element, access, half) \ > - VMRG_DO(mrgh##suffix, element, access, 0) > -VMRG(b, u8, VsrB) > -VMRG(h, u16, VsrH) > -VMRG(w, u32, VsrW) > + VMRG_DO(MRGL##suffix, element, access, half) \ > + VMRG_DO(MRGH##suffix, element, access, 0) > +VMRG(B, u8, VsrB) > +VMRG(H, u16, VsrH) > +VMRG(W, u32, VsrW) > #undef VMRG_DO > #undef VMRG > > diff --git a/target/ppc/translate/vmx-impl.c.inc b/target/ppc/translate/vmx-impl.c.inc > index 92d6e8c603..00b359f031 100644 > --- a/target/ppc/translate/vmx-impl.c.inc > +++ b/target/ppc/translate/vmx-impl.c.inc > @@ -350,12 +350,25 @@ GEN_VXFORM_V(vsububm, MO_8, tcg_gen_gvec_sub, 0, 16); > GEN_VXFORM_V(vsubuhm, MO_16, tcg_gen_gvec_sub, 0, 17); > GEN_VXFORM_V(vsubuwm, MO_32, tcg_gen_gvec_sub, 0, 18); > GEN_VXFORM_V(vsubudm, MO_64, tcg_gen_gvec_sub, 0, 19); > -GEN_VXFORM(vmrghb, 6, 0); > -GEN_VXFORM(vmrghh, 6, 1); > -GEN_VXFORM(vmrghw, 6, 2); > -GEN_VXFORM(vmrglb, 6, 4); > -GEN_VXFORM(vmrglh, 6, 5); > -GEN_VXFORM(vmrglw, 6, 6); > + > +static bool do_vmrg(DisasContext *ctx, arg_VX *a, > + void (*helper)(TCGv_ptr, TCGv_ptr, TCGv_ptr)) > +{ > + TCGv_ptr ra, rb, rd; > + REQUIRE_VECTOR(ctx); > + ra = gen_avr_ptr(a->vra); > + rb = gen_avr_ptr(a->vrb); > + rd = gen_avr_ptr(a->vrt); > + helper(rd, ra, rb); > + return true; > +} > + > +TRANS_FLAGS(ALTIVEC, VMRGHB, do_vmrg, gen_helper_VMRGHB); > +TRANS_FLAGS(ALTIVEC, VMRGHH, do_vmrg, gen_helper_VMRGHH); > +TRANS_FLAGS(ALTIVEC, VMRGHW, do_vmrg, gen_helper_VMRGHW); > +TRANS_FLAGS(ALTIVEC, VMRGLB, do_vmrg, gen_helper_VMRGLB); > +TRANS_FLAGS(ALTIVEC, VMRGLH, do_vmrg, gen_helper_VMRGLH); > +TRANS_FLAGS(ALTIVEC, VMRGLW, do_vmrg, gen_helper_VMRGLW); > > static void trans_vmrgew(DisasContext *ctx) > { > diff --git a/target/ppc/translate/vmx-ops.c.inc b/target/ppc/translate/vmx-ops.c.inc > index e28958a126..b8f77d3d2c 100644 > --- a/target/ppc/translate/vmx-ops.c.inc > +++ b/target/ppc/translate/vmx-ops.c.inc > @@ -33,12 +33,6 @@ GEN_VXFORM_DUAL(vsubuhm, bcdsub, 0, 17, PPC_ALTIVEC, PPC_NONE), > GEN_VXFORM_DUAL(vsubuwm, bcdus, 0, 18, PPC_ALTIVEC, PPC2_ISA300), > GEN_VXFORM_DUAL(vsubudm, bcds, 0, 19, PPC2_ALTIVEC_207, PPC2_ISA300), > GEN_VXFORM_300(bcds, 0, 27), > -GEN_VXFORM(vmrghb, 6, 0), > -GEN_VXFORM(vmrghh, 6, 1), > -GEN_VXFORM(vmrghw, 6, 2), > -GEN_VXFORM(vmrglb, 6, 4), > -GEN_VXFORM(vmrglh, 6, 5), > -GEN_VXFORM(vmrglw, 6, 6), > GEN_VXFORM_300(vextublx, 6, 24), > GEN_VXFORM_300(vextuhlx, 6, 25), > GEN_VXFORM_DUAL(vmrgow, vextuwlx, 6, 26, PPC_NONE, PPC2_ALTIVEC_207), > -- > 2.55.0 >