Re: [PATCH v3 12/13] drm/vino: allow the driver to be built

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] Selecting CRYPTO_RSA without inheriting its dependency on CRYPTO causes unmet direct dependency warnings.
- [Low] The Kconfig selects non-existent config symbols: RUST_CRYPTO_AKCIPHER, RUST_CRYPTO_LIB_AES, and RUST_CRYPTO_LIB_SHA256.
--

commit 580f8ac72cc85f194a430cb59459a83ca73e95c1
Author: Mike Lothian <mike@fireburn.co.uk>

drm/vino: allow the driver to be built

This commit adds the Kconfig entry, Makefile rule, and MAINTAINERS record
for the DRM driver for DisplayLink DL3 devices, allowing the driver to be
built as a module.

> diff --git a/drivers/gpu/drm/vino/Kconfig b/drivers/gpu/drm/vino/Kconfig
> new file mode 100644
> index 0000000000000..fcc761b4654b7
> --- /dev/null
> +++ b/drivers/gpu/drm/vino/Kconfig
> @@ -0,0 +1,42 @@
> +# SPDX-License-Identifier: GPL-2.0
> +config DRM_VINO
> +	tristate "DisplayLink DL3 (Vino) open driver"
> +	depends on USB
> +	depends on DRM
> +	depends on RUST
> +	# RUST_DRM_GEM_SHMEM_HELPER depends on MMU; inherit that dependency here so the
> +	# select below cannot generate an unmet-direct-dependency warning on nommu.
> +	depends on MMU
> +	select DRM_KMS_HELPER
> +	select RUST_DRM_GEM_SHMEM_HELPER
> +	select CRYPTO_RSA

[Severity: Low]
Will this select statement cause unmet direct dependency warnings if the
CRYPTO core is disabled?

Selecting CRYPTO_RSA without inheriting its dependency on CRYPTO can cause
Kconfig warnings and potential build failures (linking errors for missing
crypto core functions) if CRYPTO_RSA is forcibly enabled while the CRYPTO
core is disabled.

> +	select RUST_CRYPTO_AKCIPHER
> +	select RUST_CRYPTO_LIB_AES
> +	select RUST_CRYPTO_LIB_SHA256

[Severity: Low]
Are these Kconfig symbols actually defined in the kernel tree?

It appears that RUST_CRYPTO_AKCIPHER, RUST_CRYPTO_LIB_AES, and
RUST_CRYPTO_LIB_SHA256 do not exist anywhere in Kconfig. Selecting
non-existent symbols has no effect, which can lead to silent build failures
(like missing Rust bindings for crypto) because the intended dependencies
are not actually enabled.

> +	select FW_LOADER
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260826163913.7052-1-mike@fireburn.co.uk?part=12