From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B93C4C61DBD for ; Wed, 26 Aug 2026 17:19:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=m+ThvNHvr9peK3biyrIX96zuT2lrrsUU3R4GMryD+KY=; b=qe7xhYHbfQWXso tXHG0Oiq94oKHysTUe5Qf0O/w49SFZ6rwhwjTu4dMXPKVu0iBvnu6syeFdW1GqCJYCUuDDEhUchtR EAcRkwoOATKxyl/2hgPGTUVV8UqRkGzxrXzhVxH3EBjEDMvtkmPmaYs+cc9SnonYhrOOvjX8WFEmt zlArLl9R1ClmbaP14BDQLp/toLk+S45/iGKt1Qw6NZqRcNUCws/sqjyCnb6sPxsgX4QXTQRDHCJsC kg5MnBFSdMjpvgzFwQB5ubQCaFO0vPfxwjkV692mgZ36rsYdJwurp05RrBFSUK33UPzzhg+dKknzf KJajtROUTYkU5f6r63wg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wzHHh-00000002o2K-1u2F; Wed, 26 Aug 2026 17:19:33 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wzHHf-00000002o28-2Qpk for linux-phy@lists.infradead.org; Wed, 26 Aug 2026 17:19:31 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id A596160A73; Wed, 26 Aug 2026 17:19:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC6141F000E9; Wed, 26 Aug 2026 17:19:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787764770; bh=uHyXm+BOanKliWB60UDmv5iBUXK3VdSPhikNVeJoSKQ=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=embOOI2NaN+/5tkxCWkhV5f66NLcYjywaeUggagb5pPRNKCe2Jcjv/Qsh5Ouu5rvE byODlW1deBgotffMIUCujvmIbOZy3lNpQyM5fcnkczGHsWPmUOssluhsRBVPghaQ5V Gz8WXeEd91UDWsdubQle+1zCxoj015I5tcYtn8T6rquX1wDu1zRq9NOhNHDS9B31Rx BwwjY6Un+XhSxT/hygPCRxgg2xK7GztVsUdGW6hjyA3oyyyJDVG1XFQ5c3kgfEncVc tdUEUL9D3ssZWbtfToWTH5IPDi5jhotmzKU7e4oHLcTtBBYZZzyK0OBsPspy1QfRQG LboAjkauSy7mA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v6 5/5] usb: dwc3: qcom: Modify interrupt handling for eUSB2 Phy targets To: "Krishna Kurapati" Cc: conor+dt@kernel.org, olteanv@gmail.com, neil.armstrong@linaro.org, linux-phy@lists.infradead.org, vkoul@kernel.org, robh@kernel.org, devicetree@vger.kernel.org In-Reply-To: <20260826-eusb2-interrupt-v6-v6-5-ae2601cfa80c@oss.qualcomm.com> References: <20260826-eusb2-interrupt-v6-v6-0-ae2601cfa80c@oss.qualcomm.com> <20260826-eusb2-interrupt-v6-v6-5-ae2601cfa80c@oss.qualcomm.com> Date: Wed, 26 Aug 2026 17:19:29 +0000 Message-Id: <20260826171929.DC6141F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MiBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6CgpOZXcgaXNzdWVzOgotIFtNZWRpdW1d IFRoZSBkcml2ZXIgcGVyZm9ybXMgYSBmcmFnaWxlIHJlc291cmNlIGxvb2t1cCBmb3IgdGhlIFVT QjIgUEhZIGJ5IGhhcmRjb2RpbmcgaW5kZXggMCBpbnN0ZWFkIG9mIHJlc29sdmluZyBpdCBieSBp dHMgZGVmaW5lZCBuYW1lLgoKUHJlLWV4aXN0aW5nIGlzc3VlczoKLSBbSGlnaF0gVGhlIGxlZ2Fj eSB3cmFwcGVyIGRyaXZlciAoYGR3YzMtcWNvbS1sZWdhY3kuY2ApIGNvbXBsZXRlbHkgbWlzc2Vz IHRoZSBuZXcgZVVTQjIgcmVtb3RlIHdha2V1cCBpbnRlcnJ1cHQgbG9naWMsIGJyZWFraW5nIHJl bW90ZSB3YWtldXAgb24gdXBzdHJlYW0gZVVTQjIgcGxhdGZvcm1zIHV0aWxpemluZyB0aGUgbGVn YWN5IGJpbmRpbmcuCi0tCgpjb21taXQgZmI5Njg4NWZlNjJiZGI4NDBiYmFjOWQ4YmUyZmUyNzVh M2U5NDVhZQpBdXRob3I6IEtyaXNobmEgS3VyYXBhdGkgPGtyaXNobmEua3VyYXBhdGlAb3NzLnF1 YWxjb21tLmNvbT4KCnVzYjogZHdjMzogcWNvbTogTW9kaWZ5IGludGVycnVwdCBoYW5kbGluZyBm b3IgZVVTQjIgUGh5IHRhcmdldHMKClRoaXMgY29tbWl0IG1vZGlmaWVzIHRoZSBkd2MzIHFjb20g ZHJpdmVyIHRvIGhhbmRsZSB3YWtldXAgaW50ZXJydXB0cwpkaWZmZXJlbnRseSBmb3IgZVVTQjIg UEhZIHRhcmdldHMgYmFzZWQgb24gY29ubmVjdGVkIGRldmljZSBzcGVlZC4gSXQgY2hlY2tzCmZv ciBhbiBlVVNCMiBQSFkgYW5kIGNvbmZpZ3VyZXMgRFAvRE0gaW50ZXJydXB0IGxpbmUgc3RhdGVz IGFjY29yZGluZ2x5LgoKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy91c2IvZHdjMy9kd2MzLXFjb20u YyBiL2RyaXZlcnMvdXNiL2R3YzMvZHdjMy1xY29tLmMKPiBpbmRleCBmNDNmNzNhYzM2ZmYxLi45 YmE3ZWEzMWI1MjRmIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvdXNiL2R3YzMvZHdjMy1xY29tLmMK PiArKysgYi9kcml2ZXJzL3VzYi9kd2MzL2R3YzMtcWNvbS5jClsgLi4uIF0KPiAtc3RhdGljIHZv aWQgZHdjM19xY29tX2VuYWJsZV9wb3J0X2ludGVycnVwdHMoc3RydWN0IGR3YzNfcWNvbV9wb3J0 ICpwb3J0KQo+ICtzdGF0aWMgdm9pZCBkd2MzX3Fjb21fZW5hYmxlX3BvcnRfaW50ZXJydXB0cyhz dHJ1Y3QgZHdjM19xY29tICpxY29tLCBpbnQgcG9ydF9pbmRleCkKPiAgewo+ICsJc3RydWN0IGR3 YzNfcWNvbV9wb3J0ICpwb3J0ID0gJnFjb20tPnBvcnRzW3BvcnRfaW5kZXhdOwo+ICsKPiAgCWR3 YzNfcWNvbV9lbmFibGVfd2FrZXVwX2lycShwb3J0LT5xdXNiMl9waHlfaXJxLCAwKTsKPiAgCj4g IAkvKgo+ICAJICogQ29uZmlndXJlIERQL0RNIGxpbmUgaW50ZXJydXB0cyBiYXNlZCBvbiB0aGUg VVNCMiBkZXZpY2UgYXR0YWNoZWQgdG8KPiAtCSAqIHRoZSByb290IGh1YiBwb3J0LiBXaGVuIEhT L0ZTIGRldmljZSBpcyBjb25uZWN0ZWQsIGNvbmZpZ3VyZSB0aGUgRFAgbGluZQo+IC0JICogYXMg ZmFsbGluZyBlZGdlIHRvIGRldGVjdCBib3RoIGRpc2Nvbm5lY3QgYW5kIHJlbW90ZSB3YWtldXAg c2NlbmFyaW9zLiBXaGVuCj4gLQkgKiBMUyBkZXZpY2UgaXMgY29ubmVjdGVkLCBjb25maWd1cmUg RE0gbGluZSBhcyBmYWxsaW5nIGVkZ2UgdG8gZGV0ZWN0IGJvdGgKPiAtCSAqIGRpc2Nvbm5lY3Qg YW5kIHJlbW90ZSB3YWtldXAuIFdoZW4gbm8gZGV2aWNlIGlzIGNvbm5lY3RlZCwgY29uZmlndXJl IGJvdGgKPiAtCSAqIERQIGFuZCBETSBsaW5lcyBhcyByaXNpbmcgZWRnZSB0byBkZXRlY3QgSFMv SFMvTFMgZGV2aWNlIGNvbm5lY3Qgc2NlbmFyaW8uCj4gKwkgKiB0aGUgcm9vdCBodWIgcG9ydC4g Rm9yIG5vbi1lVVNCMiB0YXJnZXRzLCB3aGVuIEhTL0ZTIGRldmljZSBpcyBjb25uZWN0ZWQsCj4g KwkgKiBjb25maWd1cmUgdGhlIERQIGxpbmUgYXMgZmFsbGluZyBlZGdlIHRvIGRldGVjdCBkaXNj b25uZWN0IGFuZCByZW1vdGUKPiArCSAqIHdha2V1cC4gV2hlbiBMUyBkZXZpY2UgaXMgY29ubmVj dGVkLCBjb25maWd1cmUgdGhlIERNIGxpbmUgYXMgZmFsbGluZyBlZGdlCj4gKwkgKiBmb3IgdGhl IHNhbWUuIEZvciBlVVNCMiB0YXJnZXRzLCB0aGUgbGluZXMgYXJlIHN3YXBwZWQgYW5kIHJpc2lu ZyBlZGdlIGlzCj4gKwkgKiB1c2VkOiBEUCBsaW5lIGZvciBMUyBhbmQgRE0gbGluZSBmb3IgSFMv RlMgZGV2aWNlIGRldGVjdGlvbi4gV2hlbiBubwo+ICsJICogZGV2aWNlIGlzIGNvbm5lY3RlZCwg Y29uZmlndXJlIGJvdGggRFAgYW5kIERNIGxpbmVzIGFzIHJpc2luZyBlZGdlIHRvCj4gKwkgKiBk ZXRlY3QgSFMvRlMvTFMgZGV2aWNlIGNvbm5lY3Qgc2NlbmFyaW8uCj4gIAkgKi8KPiAgCj4gIAlp ZiAocG9ydC0+dXNiMl9zcGVlZCA9PSBVU0JfU1BFRURfTE9XKSB7Cj4gLQkJZHdjM19xY29tX2Vu YWJsZV93YWtldXBfaXJxKHBvcnQtPmRtX2hzX3BoeV9pcnEsCj4gLQkJCQkJICAgIElSUV9UWVBF X0VER0VfRkFMTElORyk7Cj4gKwkJaWYgKHFjb20tPmhhc19ldXNiMl9waHkpCj4gKwkJCWR3YzNf cWNvbV9lbmFibGVfd2FrZXVwX2lycShwb3J0LT5kcF9oc19waHlfaXJxLAo+ICsJCQkJCQkgICAg SVJRX1RZUEVfRURHRV9SSVNJTkcpOwo+ICsJCWVsc2UKPiArCQkJZHdjM19xY29tX2VuYWJsZV93 YWtldXBfaXJxKHBvcnQtPmRtX2hzX3BoeV9pcnEsCj4gKwkJCQkJCSAgICBJUlFfVFlQRV9FREdF X0ZBTExJTkcpOwoKW1NldmVyaXR5OiBIaWdoXQpUaGlzIGlzIGEgcHJlLWV4aXN0aW5nIGlzc3Vl LCBidXQgZG9lcyB0aGUgbGVnYWN5IHdyYXBwZXIgZHJpdmVyIAooZHJpdmVycy91c2IvZHdjMy9k d2MzLXFjb20tbGVnYWN5LmMpIGNvbXBsZXRlbHkgbWlzcyB0aGlzIG5ldyBlVVNCMiByZW1vdGUK d2FrZXVwIGludGVycnVwdCBsb2dpYz8KClRoZSBkZXZpY2UgdHJlZSBmb3IgdGhlIFF1YWxjb21t IFNBUjIxMzBQIFNvQyBhY3RpdmVseSB1c2VzIHRoZSBsZWdhY3kgd3JhcHBlcgpiaW5kaW5nIChj b21wYXRpYmxlID0gInFjb20sc2FyMjEzMHAtZHdjMyIsICJxY29tLGR3YzMiKSBhbG9uZyB3aXRo IGFuIGVVU0IyClBIWS4gV2hlbiB0aGlzIFNvQyBzdXNwZW5kcyB0aGUgVVNCIGNvbnRyb2xsZXIs IGR3YzNfcWNvbV9lbmFibGVfcG9ydF9pbnRlcnJ1cHRzCmluIHRoZSBsZWdhY3kgZHJpdmVyIGNv bmZpZ3VyZXMgdGhlIGludGVycnVwdCBwb2xhcml0eSBpbmNvcnJlY3RseSAoYXMgZmFsbGluZwpl ZGdlIGluc3RlYWQgb2YgcmlzaW5nIGVkZ2UpIGJlY2F1c2UgaXQgbGFja3MgdGhlIGVVU0IyIGNo ZWNrcyBpbnRyb2R1Y2VkIGhlcmUuCgpJcyBhbiB1cGRhdGUgcmVxdWlyZWQgaW4gdGhlIGxlZ2Fj eSB3cmFwcGVyIHNvIHRoYXQgdXBzdHJlYW0gZVVTQjIgcGxhdGZvcm1zCnV0aWxpemluZyB0aGUg bGVnYWN5IGJpbmRpbmcgY2FuIGNvcnJlY3RseSBkZXRlY3QgcmVtb3RlIHdha2V1cCBldmVudHM/ CgpbIC4uLiBdCj4gQEAgLTY4Myw2ICs3MDUsMTcgQEAgc3RhdGljIGludCBkd2MzX3Fjb21fcHJv YmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiAgCWlmIChpZ25vcmVfcGlwZV9jbGsp Cj4gIAkJZHdjM19xY29tX3NlbGVjdF91dG1pX2NsayhxY29tKTsKPiAgCj4gKwlwaHkgPSBkZXZt X29mX3BoeV9nZXRfYnlfaW5kZXgoZGV2LCBkZXYtPm9mX25vZGUsIDApOwoKW1NldmVyaXR5OiBN ZWRpdW1dCldpbGwgdGhpcyBicmVhayBpZiB0aGUgVVNCMyBQSFkgaXMgcGxhY2VkIGZpcnN0IGlu IHRoZSBwaHlzIHByb3BlcnR5IGFycmF5PwoKSWYgaW5kZXggMCByZXRyaWV2ZXMgdGhlIFVTQjMg UEhZIGluc3RlYWQsIHBoeV9nZXRfdHlwZSgpIHdpbGwgcmV0dXJuClBIWV9UWVBFX1VTQjMgcmF0 aGVyIHRoYW4gUEhZX1RZUEVfRVVTQjIsIGZhbHNlbHkgZXZhbHVhdGluZyBoYXNfZXVzYjJfcGh5 CnRvIGZhbHNlLiBUaGUgRFQgYmluZGluZyBzY2hlbWEgKHNucHMsZHdjMy1jb21tb24ueWFtbCkg ZG9lcyBub3QgZW5mb3JjZQp0aGUgb3JkZXJpbmcgb2YgdGhlIHBoeXMgYXJyYXksIGJ1dCByYXRo ZXIgcmVsaWVzIG9uIHRoZSBwaHktbmFtZXMgcHJvcGVydHkKKGVudW06IFt1c2IyLXBoeSwgdXNi My1waHldKS4KCldvdWxkIGl0IGJlIG1vcmUgcm9idXN0IHRvIHVzZSBkZXZtX3BoeV9nZXQoZGV2 LCAidXNiMi1waHkiKSB0byByZXNvbHZlIHRoZQpQSFkgYnkgaXRzIGRlZmluZWQgbmFtZSBpbnN0 ZWFkIG9mIGhhcmRjb2RpbmcgaW5kZXggMD8KCj4gKwlpZiAoSVNfRVJSKHBoeSkpIHsKPiArCQlp ZiAoUFRSX0VSUihwaHkpICE9IC1FTk9ERVYpIHsKPiArCQkJcmV0ID0gZGV2X2Vycl9wcm9iZShk ZXYsIFBUUl9FUlIocGh5KSwKPiArCQkJCQkgICAgImZhaWxlZCB0byBnZXQgdXNiMiBwaHlcbiIp Owo+ICsJCQlnb3RvIGNsa19kaXNhYmxlOwo+ICsJCX0KPiArCQlwaHkgPSBOVUxMOwo+ICsJfQo+ ICsJcWNvbS0+aGFzX2V1c2IyX3BoeSA9IHBoeSAmJiAocGh5X2dldF90eXBlKHBoeSkgPT0gUEhZ X1RZUEVfRVVTQjIpOwo+ICsKPiAgCXFjb20tPm1vZGUgPSB1c2JfZ2V0X2RyX21vZGUoZGV2KTsK Ci0tIApTYXNoaWtvIEFJIHJldmlldyDCtyBodHRwczovL3Nhc2hpa28uZGV2LyMvcGF0Y2hzZXQv MjAyNjA4MjYtZXVzYjItaW50ZXJydXB0LXY2LXY2LTAtYWUyNjAxY2ZhODBjQG9zcy5xdWFsY29t bS5jb20/cGFydD01CgotLSAKbGludXgtcGh5IG1haWxpbmcgbGlzdApsaW51eC1waHlAbGlzdHMu aW5mcmFkZWFkLm9yZwpodHRwczovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5m by9saW51eC1waHkK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DD41345CAE for ; Wed, 26 Aug 2026 17:19:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787764786; cv=none; b=jUUUvRZdAvKLOTSt3GAwUpWRz+3oA0UBglcrO8IglzKmYsskslbh/FWGxDARmbSKQrGujHb+iXAlijzm1S2QI9UIhtSJxSNY7N5NWKzeVmG3vKUlj9shOQQDWgKUu9yotKon7JqYeHPZ6v9Rm/Te73vR9YOJh4QzkljNx5rYe9w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787764786; c=relaxed/simple; bh=Y7Y8kQbD2L+Jj1iw5z/w1+LstEisR5Q+eRDdSuMwk8M=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=rDjlrwq5LffTUYvvGeGK7rviJtp5wHJdZ8XcTme+PuCKhxkjuB7OOio2KcBooIGcqFGdR9w8ehas4po4KsrrnI02BtJPexU/JzwdDv2SDc36uTaxczETUZT64uS7z0qF1zprN8QHIeYQG5m2GCiqHZSor1wS+Uyu1lg/BNdXpag= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=embOOI2N; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="embOOI2N" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC6141F000E9; Wed, 26 Aug 2026 17:19:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787764770; bh=uHyXm+BOanKliWB60UDmv5iBUXK3VdSPhikNVeJoSKQ=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=embOOI2NaN+/5tkxCWkhV5f66NLcYjywaeUggagb5pPRNKCe2Jcjv/Qsh5Ouu5rvE byODlW1deBgotffMIUCujvmIbOZy3lNpQyM5fcnkczGHsWPmUOssluhsRBVPghaQ5V Gz8WXeEd91UDWsdubQle+1zCxoj015I5tcYtn8T6rquX1wDu1zRq9NOhNHDS9B31Rx BwwjY6Un+XhSxT/hygPCRxgg2xK7GztVsUdGW6hjyA3oyyyJDVG1XFQ5c3kgfEncVc tdUEUL9D3ssZWbtfToWTH5IPDi5jhotmzKU7e4oHLcTtBBYZZzyK0OBsPspy1QfRQG LboAjkauSy7mA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v6 5/5] usb: dwc3: qcom: Modify interrupt handling for eUSB2 Phy targets Reply-To: sashiko-reviews@lists.linux.dev To: "Krishna Kurapati" Cc: conor+dt@kernel.org, olteanv@gmail.com, neil.armstrong@linaro.org, linux-phy@lists.infradead.org, vkoul@kernel.org, robh@kernel.org, devicetree@vger.kernel.org In-Reply-To: <20260826-eusb2-interrupt-v6-v6-5-ae2601cfa80c@oss.qualcomm.com> References: <20260826-eusb2-interrupt-v6-v6-0-ae2601cfa80c@oss.qualcomm.com> <20260826-eusb2-interrupt-v6-v6-5-ae2601cfa80c@oss.qualcomm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Wed, 26 Aug 2026 17:19:29 +0000 Message-Id: <20260826171929.DC6141F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 2 potential issue(= s) to consider: New issues: - [Medium] The driver performs a fragile resource lookup for the USB2 PHY b= y hardcoding index 0 instead of resolving it by its defined name. Pre-existing issues: - [High] The legacy wrapper driver (`dwc3-qcom-legacy.c`) completely misses= the new eUSB2 remote wakeup interrupt logic, breaking remote wakeup on ups= tream eUSB2 platforms utilizing the legacy binding. -- commit fb96885fe62bdb840bbac9d8be2fe275a3e945ae Author: Krishna Kurapati usb: dwc3: qcom: Modify interrupt handling for eUSB2 Phy targets This commit modifies the dwc3 qcom driver to handle wakeup interrupts differently for eUSB2 PHY targets based on connected device speed. It checks for an eUSB2 PHY and configures DP/DM interrupt line states accordingly. > diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c > index f43f73ac36ff1..9ba7ea31b524f 100644 > --- a/drivers/usb/dwc3/dwc3-qcom.c > +++ b/drivers/usb/dwc3/dwc3-qcom.c [ ... ] > -static void dwc3_qcom_enable_port_interrupts(struct dwc3_qcom_port *port) > +static void dwc3_qcom_enable_port_interrupts(struct dwc3_qcom *qcom, int= port_index) > { > + struct dwc3_qcom_port *port =3D &qcom->ports[port_index]; > + > dwc3_qcom_enable_wakeup_irq(port->qusb2_phy_irq, 0); > =20 > /* > * Configure DP/DM line interrupts based on the USB2 device attached to > - * the root hub port. When HS/FS device is connected, configure the DP = line > - * as falling edge to detect both disconnect and remote wakeup scenario= s. When > - * LS device is connected, configure DM line as falling edge to detect = both > - * disconnect and remote wakeup. When no device is connected, configure= both > - * DP and DM lines as rising edge to detect HS/HS/LS device connect sce= nario. > + * the root hub port. For non-eUSB2 targets, when HS/FS device is conne= cted, > + * configure the DP line as falling edge to detect disconnect and remote > + * wakeup. When LS device is connected, configure the DM line as fallin= g edge > + * for the same. For eUSB2 targets, the lines are swapped and rising ed= ge is > + * used: DP line for LS and DM line for HS/FS device detection. When no > + * device is connected, configure both DP and DM lines as rising edge to > + * detect HS/FS/LS device connect scenario. > */ > =20 > if (port->usb2_speed =3D=3D USB_SPEED_LOW) { > - dwc3_qcom_enable_wakeup_irq(port->dm_hs_phy_irq, > - IRQ_TYPE_EDGE_FALLING); > + if (qcom->has_eusb2_phy) > + dwc3_qcom_enable_wakeup_irq(port->dp_hs_phy_irq, > + IRQ_TYPE_EDGE_RISING); > + else > + dwc3_qcom_enable_wakeup_irq(port->dm_hs_phy_irq, > + IRQ_TYPE_EDGE_FALLING); [Severity: High] This is a pre-existing issue, but does the legacy wrapper driver=20 (drivers/usb/dwc3/dwc3-qcom-legacy.c) completely miss this new eUSB2 remote wakeup interrupt logic? The device tree for the Qualcomm SAR2130P SoC actively uses the legacy wrap= per binding (compatible =3D "qcom,sar2130p-dwc3", "qcom,dwc3") along with an eU= SB2 PHY. When this SoC suspends the USB controller, dwc3_qcom_enable_port_inter= rupts in the legacy driver configures the interrupt polarity incorrectly (as fall= ing edge instead of rising edge) because it lacks the eUSB2 checks introduced h= ere. Is an update required in the legacy wrapper so that upstream eUSB2 platforms utilizing the legacy binding can correctly detect remote wakeup events? [ ... ] > @@ -683,6 +705,17 @@ static int dwc3_qcom_probe(struct platform_device *p= dev) > if (ignore_pipe_clk) > dwc3_qcom_select_utmi_clk(qcom); > =20 > + phy =3D devm_of_phy_get_by_index(dev, dev->of_node, 0); [Severity: Medium] Will this break if the USB3 PHY is placed first in the phys property array? If index 0 retrieves the USB3 PHY instead, phy_get_type() will return PHY_TYPE_USB3 rather than PHY_TYPE_EUSB2, falsely evaluating has_eusb2_phy to false. The DT binding schema (snps,dwc3-common.yaml) does not enforce the ordering of the phys array, but rather relies on the phy-names property (enum: [usb2-phy, usb3-phy]). Would it be more robust to use devm_phy_get(dev, "usb2-phy") to resolve the PHY by its defined name instead of hardcoding index 0? > + if (IS_ERR(phy)) { > + if (PTR_ERR(phy) !=3D -ENODEV) { > + ret =3D dev_err_probe(dev, PTR_ERR(phy), > + "failed to get usb2 phy\n"); > + goto clk_disable; > + } > + phy =3D NULL; > + } > + qcom->has_eusb2_phy =3D phy && (phy_get_type(phy) =3D=3D PHY_TYPE_EUSB2= ); > + > qcom->mode =3D usb_get_dr_mode(dev); --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260826-eusb2-inte= rrupt-v6-v6-0-ae2601cfa80c@oss.qualcomm.com?part=3D5