Re: [PATCH v2 4/8] KVM: VMX: Rename posted interrupt prefixes from "vmx" to "vt"

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incomplete refactoring: The common helper function `vmx_needs_pi_wakeup` was not renamed to `vt_needs_pi_wakeup`.
--

commit 3f6ac2d22873c9d6eb23bb3aab8ab0ad05bd4863
Author: Sean Christopherson <seanjc@google.com>

KVM: VMX: Rename posted interrupt prefixes from "vmx" to "vt"

This commit renames posted interrupt APIs that are shared between VMX and TDX
to use the "vt" prefix instead of "vmx". This is a non-functional change.

> diff --git a/arch/x86/kvm/vmx/posted_intr.c b/arch/x86/kvm/vmx/posted_intr.c
> index 24221ba553be1..359ef3e6ebbe4 100644
> --- a/arch/x86/kvm/vmx/posted_intr.c
> +++ b/arch/x86/kvm/vmx/posted_intr.c
[ ... ]
> @@ -219,10 +219,10 @@ static bool vmx_needs_pi_wakeup(struct kvm_vcpu *vcpu)
>  	 * back to the pi_wakeup_handler() function.
>  	 */
>  	return (vmx_can_use_ipiv(vcpu) && !is_td_vcpu(vcpu)) ||
> -		vmx_can_use_vtd_pi(vcpu->kvm);
> +		vt_can_use_vtd_pi(vcpu->kvm);
>  }

[Severity: Low]
This isn't a bug, but does vmx_needs_pi_wakeup() also need to be renamed to
vt_needs_pi_wakeup()?

The "vmx_" prefix is left on a function that is actively shared with TDX
(it checks is_td_vcpu()) and is used by the common vt_vcpu_pi_put() API
below, missing the stated goal of the patch to rename all common posted
interrupt APIs.

>  
> -void vmx_vcpu_pi_put(struct kvm_vcpu *vcpu)
> +void vt_vcpu_pi_put(struct kvm_vcpu *vcpu)
>  {
>  	struct pi_desc *pi_desc = vcpu_to_pi_desc(vcpu);

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260826171246.777729-1-seanjc@google.com?part=4