Re: [PATCH v2 1/5] iio: light: stk3310: lower-case the i2c device ID names

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Removing the upper-case I2C device IDs breaks backwards compatibility for devices instantiated from userspace via sysfs.
--

commit 7889e08011ff4fb9c503926c95b3280c1405b42a
Author: Jorijn van der Graaf <jorijnvdgraaf@catcrafts.net>

iio: light: stk3310: lower-case the i2c device ID names

This commit replaces the upper-case I2C device IDs with lower-case versions
to match conventional devicetree compatible suffixes. This allows clients
without a firmware node to correctly match the driver, but it prevents sysfs
clients instantiated under the previous capital names from binding.

> diff --git a/drivers/iio/light/stk3310.c b/drivers/iio/light/stk3310.c
> --- a/drivers/iio/light/stk3310.c
> +++ b/drivers/iio/light/stk3310.c
> @@ -766,10 +766,10 @@ static DEFINE_SIMPLE_DEV_PM_OPS(stk3310_pm_ops, stk3310_suspend,
>  				stk3310_resume);
>  
>  static const struct i2c_device_id stk3310_i2c_id[] = {
> -	{ .name = "STK3013" },
> -	{ .name = "STK3310" },
> -	{ .name = "STK3311" },
> -	{ .name = "STK3335" },

[Severity: Medium]
Does removing the upper-case I2C device IDs break backwards compatibility for
devices instantiated from userspace via sysfs?

Userspace scripts that previously instantiated the device using a command
like "echo STK3310 0x48 > new_device" will fail to bind to the driver, as
the device name will no longer match the I2C device ID table.

Should the upper-case IDs be retained alongside the new lower-case IDs to
preserve ABI backwards compatibility?

> +	{ .name = "stk3013" },
> +	{ .name = "stk3310" },
> +	{ .name = "stk3311" },
> +	{ .name = "stk3335" },
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(i2c, stk3310_i2c_id);

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260826175409.326131-1-jorijnvdgraaf@catcrafts.net?part=1