Re: [PATCH 1/2] mm/damon/core: initialize damos_quota_goal->last_psi_total

[SJ Park <sj@kernel.org>]

On Wed, 26 Aug 2026 21:50:34 -0700 SJ Park <sj@kernel.org> wrote:

> On Thu, 27 Aug 2026 04:45:47 +0000 sashiko-bot@kernel.org wrote:
[...]
> > [Severity: High]
> > This is a pre-existing issue, but does this switch statement omit the
> > DAMOS_QUOTA_NODE_ELIGIBLE_MEM_BP metric?
> > 
> > When a user configures a DAMOS quota goal using the
> > DAMOS_QUOTA_NODE_ELIGIBLE_MEM_BP metric via sysfs, a new quota goal is
> > allocated in damos_new_quota_goal() via kmalloc_obj(), where the memory is
> > not zeroed. 
> > 
> > Because DAMOS_QUOTA_NODE_ELIGIBLE_MEM_BP is missing from the switch statement
> > in damos_commit_quota_goal_union(), its nid field is not copied over during
> > parameter updates. This leaves the node ID uninitialized and potentially
> > causes eligible memory queries to evaluate using garbage data, completely
> > breaking the metric's functionality.
> 
> Good catch.  I will separately work on this.

Actually the fix will be quite straightforward.  I will add that as a part of
the next version of this series.


Thanks,
SJ

[...]