From: Alex Markuze <amarkuze@redhat.com>
To: Max Kellermann <max.kellermann@ionos.com>
Cc: ceph-devel@vger.kernel.org
Subject: Re: [v2] ceph: don't unregister an MDS session before removing its caps
Date: Thu, 27 Aug 2026 09:11:05 +0000 [thread overview]
Message-ID: <20260827091105.2740625-1-amarkuze@redhat.com> (raw)
In-Reply-To: <20260824183042.234264-1-max.kellermann@ionos.com>
Hi Max,
NACK. Please send a v3.
1. fs/ceph/mds_client.c:5942: Address-change path overwrites CLOSED and reconnects a session CLOSE will purge
Max, the CLOSED skip at the top of `check_new_map()` is a single
load under `mdsc->mutex`.
After retaking `mdsc->mutex` in the address-change block, if the
session is CLOSED, leave it alone (no `ceph_con_close()`, no
`RESTARTING`, no reconnect).
2. fs/ceph/mds_client.c:6016: Closed-session export targets can miss their only reconnect
`check_new_map()` now skips any export-target rank whose registered
session is `CEPH_MDS_SESSION_CLOSED`.
When a registered session is only being kept alive for cap
teardown, do not just `continue` out of the reconnect path.
--
Alex Markuze
prev parent reply other threads:[~2026-08-27 9:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-24 18:30 [PATCH v2] ceph: don't unregister an MDS session before removing its caps Max Kellermann
2026-08-27 9:11 ` Alex Markuze [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260827091105.2740625-1-amarkuze@redhat.com \
--to=amarkuze@redhat.com \
--cc=ceph-devel@vger.kernel.org \
--cc=max.kellermann@ionos.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.