From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 523F03E3152 for ; Thu, 27 Aug 2026 08:30:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787819424; cv=none; b=vGnHujJvYHGU0A7X/pM6o7kDUThDhkO/U3aU9gSvKk6SOBzJFUUcYkK6trtf+EpOHgI57IwNJn1prRncrrzW/x+sePhD/8dlK51TbkYLpyHupa3agqU7xiMQ+KD26a9qppnPQ5oxNfqciE9LDHOhxRBbDnBbpS2L13h/WnrUIiM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787819424; c=relaxed/simple; bh=yJpyF+5Tc3G8tE31WpMqXfWM3y43ClMVTYl+eMZsTmI=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=OkoY2lkckZ7+8xLtPUnAozJE/MoTkmrK33LMxBOix/FiV/YBNiWUj53u6eTVbgmCVXPq34IHpKy1lvsh/k5uw54UCJRtNOR4Gqv7mKGNEDVEgtL9KICFPv+eQNTe4cxdZluS5RYu3YsVdQIr8dLVEaX1j25xSz+JPA/PigpWo2k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aJamGOWR; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aJamGOWR" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4956869750eso11959605e9.2 for ; Thu, 27 Aug 2026 01:30:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787819421; x=1788424221; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Gv10IZgS+I8/TcY7gcREpSsUvzMsxKqW3sbwG8Jb3QY=; b=aJamGOWR4RskmKAgdzroTT/6XZdn0jLXN4eI42AFneeGhUeKClD8v+xJHo6cd5//dR l+7TljvSWDuY2EkxK7lCpsSrJbgYwL9U7KqMIDJ4IH7QYhvaVE/3Gb/lzDwSVHjgr0pu nBm86C3Bg69rJtasMMPnQgTISlRCTkJ0O6l1sOvee7utl6ZiIrNh6LxGsqMaHE66u6rN AEPpTQoKZSnri660Aqi9iWkuaIVfG/kJwvOd7VKTc7Dic3OkMayKLuXFThQ4bCRN4qZf PNQcWp0xRtx18Z1Cs+wQAlxRcMFLCLMTQMnwQz5yukSyzYipkXQkcDT+XGnyPgSma9Zm BNGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787819421; x=1788424221; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Gv10IZgS+I8/TcY7gcREpSsUvzMsxKqW3sbwG8Jb3QY=; b=YY6hCsy6BJKkLBv8gBdKtFhNV5rMrJtgn/VpuSgXpa661THS7hPM7UBGlVmHNjxPva NlToD6oIOVp4p3SZBaHM0TBlUjIIsb5It5J2iY75xa0oX5PDWYt314iFJ7jY8zqgaAyP w3qLRdzZHl3nF8jYypJjSVAQzWrySA66w4MdEx6IX4obTUCYr0jqfm6Ic8Rdn4XBk9h9 YPrtLJc13khzAvX7q47Q6h+ufzsGg9xkwUFd7g0TC43wjLJGXNWqvjl3jPQwrqtnIiVU dFCmB248vKY/uEReunAHiJn2Ol6+gaEzzLHo96XWDwAZHGwtxlhj4tF/CL1lvKbWkEZk FjXQ== X-Forwarded-Encrypted: i=1; AHgh+RpNyp+atFXzJFJfmJlIYSLt9lTRGyJi+H9ydDeq+nDN0mh6DKq1477UsvN5ad/lgpeEvHWFXzEeN5k=@vger.kernel.org X-Gm-Message-State: AFuF++kySkXjMd+bbG+2nGdCgqk8vTFfio9wkBq86ivNlA4RhRaNk7B5 nRbEi9mM5frxbPfxHcX3JnbnUOSTF3AjZ7JwR7u7P+NjzW0nMuN8SMoY X-Gm-Gg: AR+sD13bYUT43yhFI0arw0XsQZ9JXbC2lvstja4s0YXDSuJ3hZvNpVwXS6ZcYwkS7et tXT75/pjqZbaXCxR0TOnuL//0DxDSC3UWpI6fxa95H68+P6/9SlVQXc6+JwX5uKfNpCf7fExQ7q VNAbXoCPQQ6bZ1PxvAdke8/5eq3zjWLUhTPnsHwwO0CGkzIi7JEd5lp0VKCYEp6eAvZvgESYPqh 3CLo4SLwdoEKMGjG5LdvcCtuTk9fWZamJBbyZiNHCwFhB3Td77lN6LoHImUrjvnO3a4beIb91RH e75qcrGAJpl46RrLH6mrRuLMGtvWMnXPS9CK0UZQ627njAoMG9eWFLVJvXFNmpNYU74h/5sCPBF FmIdb7Y3OTLvOIqe93hpfZWklo+AyQs6BB5oVP5n/+W22b185t62Y4UhKDQHBhBxb4TznSghCkl bAZRZMzg+OknMjiK7I5l3PS4QtuvnSOveZ9yTkGjjE5Ak+lx90SYQb3Drv1Us7JN/Rc/239j7eM l9jmOGfduupLI0ZnalIBn2NlEudFS5P50+CQrVd45z3kvqWqGBU8+cc33k+KuJQlA2WRXRMCzCE 3YaWoNLa9rQ0Fz32QcbSAkrWJaBVxH0Ltt59F2aIEsHKKsLx16H+y3pzRHgpQr0XTTQ4lX7ya3w 2Vc5JvVKF8x2GG8Usx4uAUnRq9QbYplHktiTFWQntm6DWY2y8kp7SbApU2UfIyn9v1SVO/i85zN WeVx0X X-Received: by 2002:a05:600c:a0d:b0:499:bdf1:7578 with SMTP id 5b1f17b1804b1-499dc6e9b00mr152209385e9.3.1787819421205; Thu, 27 Aug 2026 01:30:21 -0700 (PDT) Received: from localhost (90-182-112-124.rcp.o2.cz. [90.182.112.124]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499dd56826bsm53438315e9.4.2026.08.27.01.30.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Aug 2026 01:30:20 -0700 (PDT) Date: Thu, 27 Aug 2026 10:30:19 +0200 From: Joshua Crofts To: Janani Sunil Cc: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , "David Lechner" , Nuno =?ISO-8859-1?Q?S=E1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , "Jonathan Corbet" , Shuah Khan , Mark Brown , Marius Cristea , "Marcus Folkesson" , Kent Gustavsson , Conor Dooley , Daire McNamara , Paul Walmsley , "Palmer Dabbelt" , Albert Ou , "Alexandre Ghiti" , , , , , Janani Sunil , , Kent Gustavsson , Subject: Re: [PATCH v10 3/3] iio: dac: Add AD5529R DAC driver support Message-ID: <20260827103019.00002663@gmail.com> In-Reply-To: <20260827-ad5529r-driver-v10-3-38f2be07b824@analog.com> References: <20260827-ad5529r-driver-v10-0-38f2be07b824@analog.com> <20260827-ad5529r-driver-v10-3-38f2be07b824@analog.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 27 Aug 2026 09:34:48 +0200 Janani Sunil wrote: > +#include > +#include > +#include > +#include > +#include > +#include > +#include IIO specific headers should go after the generic headers, it's just convention. > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + ... > +static int ad5529r_write_raw(struct iio_dev *indio_dev, > + struct iio_chan_spec const *chan, > + int val, int val2, long mask) > +{ > + struct ad5529r_state *st = iio_priv(indio_dev); > + unsigned int reg_addr; > + > + switch (mask) { > + case IIO_CHAN_INFO_RAW: > + if (val < 0 || val > GENMASK(st->model_data->resolution - 1, 0)) There is a function for this - in_range(), in linux/minmax.h. > + return -EINVAL; > + > + reg_addr = AD5529R_REG_DAC_INPUT_A(chan->channel); > + > + return regmap_write(st->regmap_16bit, reg_addr, val); > + default: > + return -EINVAL; > + } > +} > + -- Kind regards, Joshua Crofts From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E112FC61DC2 for ; Thu, 27 Aug 2026 08:30:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3tBZPMRWXR7ivIe+s1QZ0UduCjXbRDcddhnyURwsMUo=; b=xFLdDJ2Wrf1DsY RBa4/ez/mbVCFjS3qPVSReSGaGDIqY+l6x26Q3lTPBPe6ReGkWrWvhhoxQxi1fYBfuN7JagiM/qN5 T8aGeFZHTOktOEA+FuetrsKGRG08GBeXefWsLN0u8e62z4XMfqu6ItR9Owtqqx9sM1yEzKrViJurm JCboYr6BsETi/2OJWrfs/iR9fBPSodNl/ogJ8VIH4kS8okRk+cfA+XPPc31gFS1oOYwdWNPJ6mg88 uzBuFT7cFesXVfjOkEe/yC1n0MwZ2FKFgG3PW7KLrC2g83YCMQzZwk+cFwQmDBKvj6X9HtpeWYPkU UZ5oQYFdFRc9iEmRBh0A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wzVVC-00000003dtF-0Dtp; Thu, 27 Aug 2026 08:30:26 +0000 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wzVV9-00000003dsV-3P1Y for linux-riscv@lists.infradead.org; Thu, 27 Aug 2026 08:30:24 +0000 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-4956869750eso11959615e9.2 for ; Thu, 27 Aug 2026 01:30:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787819421; x=1788424221; darn=lists.infradead.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Gv10IZgS+I8/TcY7gcREpSsUvzMsxKqW3sbwG8Jb3QY=; b=XODhaJxhGuVf7uHVMIZ9SHm0sCWlpnXeaAO0t9yPrpRd4P1jflUaQR141uGBZPfPFS aoGL25Memt4iMqreFko3jhxm3fyKo4tHEn+QU2a2UnoBxGnBZEbrZQb/0/ZxbDDSm1IU zb/hrYIwOJgH4z/iSgb7yxG8lfRpOLFM3EVlFnIL0Ld1+TagJ3BtLA9N0jwGoHsD1Jw5 U5puQkc+mEYMNPfWmAAd4Um3hvsluVzmMvNsAKSlRZgDPTxWH1Ef4+F7+cdks04dOs6+ zI8fhwKny8kzNGKdlYY/0iliHjmqwPjgUpBfA9JfeAW+c4Av3D04kiXsWjEgSodbYwuK shjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787819421; x=1788424221; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Gv10IZgS+I8/TcY7gcREpSsUvzMsxKqW3sbwG8Jb3QY=; b=iTFfxJbkE2CGs5aJmCxtnnRQdTbtUu88hvkwkiBUtcvlT30gkJKYUe8LVdVZAiPl+D GEIgMJolcymUNUyNZRa6HkmXE47XKRDzJdf/NqxWQqE8n3ZWZHD47ztZJI0f1OQxXEFy mRR02dUWO6wxuqAP5CAtkmVbOUuXFkajqRsuamYDM60pb3h84oH7LhRF/6++yzufIVh0 f/jHaMTsSSoVmFTr2KnOyYKyWu5txlQSenz2HOwGK05iYh2+dgNtuSS8EpHpEZkmyIZt vlTawF73htyYPx/DJkLTbVvgpWBGhsVEeLcRKPNjT2UbQSFYkMbeOAEhj2w4k3ay8fUp sT0w== X-Forwarded-Encrypted: i=1; AHgh+Rqwutw+Ddwq34/KJ3jKB634UX5Gu2NpAB+XY2PQs6HgFxFGiJveAZKie/o9vlFpA5mNM3Wg5/Kx9o98Mw==@lists.infradead.org X-Gm-Message-State: AFuF++nK2s0fPKyd11iwzdpisA6Sk+UMsKJZtETj8cpoLuf3yJLvQYWQ 9J9/fswTDRaqCCrW1zMIOfX7vJyOfhVfXHCAORMTj9Uu+DNBS0NCtv1P X-Gm-Gg: AR+sD11Y3bml6FQQw7xApxVVixQqNnLx3+jKcfrBsfFEXep5Pb+0FzDAD7fa5pfWaVE IGuKJ3RM+M92lfCFjh0xa9JQan97bFwtItINtouAE7/vhEF/PLwIqbLa99m1QTXJrmmauPs1Z7X 5r3GBwEOcm9Ykoz8jKC6GaBUfVg85Vp3/AEC4M9U46aZlQ+YX7Hd6VyvsFcYlXcd9JmlxFnvv6x 3X2ljd9FUcHBokPTuWcYP+LAW26AGAp+fiO2hXVsZxoiB8TeZLezQCD5Q6yOczYblYt7VwEVqYv LJjPJVfqJcUiVbhStH/TDHNgWD4XsHT4W7pEoCwSyGCKOREulbMnmRPq92dQKIHfKOwCMFlSp4h 8E0Mr0YVbrwkDqaF/8YR6IWukWicsu1PR2i3nXxAqzYnatC6ICIUvCIu2fburrcr2QvxK43Ppw5 +b5VbDIiDNJK+SELsTr1LaDedIx3tiM5vM4a9ggIQh18hhLPa3Kzhosm+TgRokEv8wBCtxw/+O5 Ne/dKpQMQmc2v4ruO7hJWp4EP6WBVEX8ipgzVJHZhKbVU1vhMdEbqjoMKYHBTSCO5B8GE8YMPLT stZnSL7zilbcDlBo35TibbZB1IIXCKFF6Ssx5Rv0XlH94YBPN8N9A0jgzvLF3/nAW5MTJyeG/nu ZFHvqhz5S1hotWdLOHzcILwF2ySd4vupf1S5OGpfWwPO1Ihf6BAfLRm0jMAMTFGEs1QrwBl48+v Ft9CZY X-Received: by 2002:a05:600c:a0d:b0:499:bdf1:7578 with SMTP id 5b1f17b1804b1-499dc6e9b00mr152209385e9.3.1787819421205; Thu, 27 Aug 2026 01:30:21 -0700 (PDT) Received: from localhost (90-182-112-124.rcp.o2.cz. [90.182.112.124]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499dd56826bsm53438315e9.4.2026.08.27.01.30.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Aug 2026 01:30:20 -0700 (PDT) Date: Thu, 27 Aug 2026 10:30:19 +0200 From: Joshua Crofts To: Janani Sunil Cc: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , "David Lechner" , Nuno =?ISO-8859-1?Q?S=E1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , "Jonathan Corbet" , Shuah Khan , Mark Brown , Marius Cristea , "Marcus Folkesson" , Kent Gustavsson , Conor Dooley , Daire McNamara , Paul Walmsley , "Palmer Dabbelt" , Albert Ou , "Alexandre Ghiti" , , , , , Janani Sunil , , Kent Gustavsson , Subject: Re: [PATCH v10 3/3] iio: dac: Add AD5529R DAC driver support Message-ID: <20260827103019.00002663@gmail.com> In-Reply-To: <20260827-ad5529r-driver-v10-3-38f2be07b824@analog.com> References: <20260827-ad5529r-driver-v10-0-38f2be07b824@analog.com> <20260827-ad5529r-driver-v10-3-38f2be07b824@analog.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260827_013023_871939_8AFB5459 X-CRM114-Status: GOOD ( 11.65 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Thu, 27 Aug 2026 09:34:48 +0200 Janani Sunil wrote: > +#include > +#include > +#include > +#include > +#include > +#include > +#include IIO specific headers should go after the generic headers, it's just convention. > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + ... > +static int ad5529r_write_raw(struct iio_dev *indio_dev, > + struct iio_chan_spec const *chan, > + int val, int val2, long mask) > +{ > + struct ad5529r_state *st = iio_priv(indio_dev); > + unsigned int reg_addr; > + > + switch (mask) { > + case IIO_CHAN_INFO_RAW: > + if (val < 0 || val > GENMASK(st->model_data->resolution - 1, 0)) There is a function for this - in_range(), in linux/minmax.h. > + return -EINVAL; > + > + reg_addr = AD5529R_REG_DAC_INPUT_A(chan->channel); > + > + return regmap_write(st->regmap_16bit, reg_addr, val); > + default: > + return -EINVAL; > + } > +} > + -- Kind regards, Joshua Crofts _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv