From: Heiko Carstens <hca@linux.ibm.com>
To: Vasily Gorbik <gor@linux.ibm.com>
Cc: Ilya Leoshkevich <iii@linux.ibm.com>, linux-s390@vger.kernel.org
Subject: Re: [PATCH 3/3] s390/boot: Bound command line facility ranges
Date: Thu, 27 Aug 2026 15:49:38 +0200 [thread overview]
Message-ID: <20260827134938.25110D0b-hca@linux.ibm.com> (raw)
In-Reply-To: <p03-03.gfb54656967a2.ttkffvj@ub.hpns>
On Thu, Aug 27, 2026 at 02:01:31PM +0200, Vasily Gorbik wrote:
> The facilities and debug-alternative command line parsers iterate over
> inclusive numeric ranges. If a range ends at ULONG_MAX, incrementing the
> current value wraps to zero and the loop never terminates. Large finite
> out-of-range values also cause unnecessary early boot iterations even
> though the bitmap helpers ignore them.
>
> Stop each loop at the size of the bitmap it modifies. This preserves all
> meaningful range values while guaranteeing termination.
>
> Fixes: b5e804598d59 ("s390: allow overriding facilities via command line")
> Fixes: 15c33a5bc9b8 ("s390/alternatives: Add debug functionality")
This is quite esoteric. Not sure if this justifies Fixes tags.
> Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
> ---
> arch/s390/boot/alternative.c | 5 +++--
> arch/s390/boot/ipl_parm.c | 2 +-
> 2 files changed, 4 insertions(+), 3 deletions(-)
Reviewed-by: Heiko Carstens <hca@linux.ibm.com>
next prev parent reply other threads:[~2026-08-27 13:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-27 12:01 [PATCH 0/3] s390/boot: Fix couple of early boot edge cases Vasily Gorbik
2026-08-27 12:01 ` [PATCH 1/3] s390/boot: Fix physical memory search range Vasily Gorbik
2026-08-27 12:06 ` sashiko-bot
2026-08-27 13:36 ` Heiko Carstens
2026-08-27 12:01 ` [PATCH 2/3] s390/boot: Avoid IPL parameter append past command line Vasily Gorbik
2026-08-27 12:06 ` sashiko-bot
2026-08-27 13:36 ` Heiko Carstens
2026-08-27 12:01 ` [PATCH 3/3] s390/boot: Bound command line facility ranges Vasily Gorbik
2026-08-27 12:09 ` sashiko-bot
2026-08-27 13:49 ` Heiko Carstens [this message]
2026-08-27 15:59 ` [PATCH 0/3] s390/boot: Fix couple of early boot edge cases Vasily Gorbik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260827134938.25110D0b-hca@linux.ibm.com \
--to=hca@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=iii@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.