All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Leo Yan" <leo.yan@arm.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v2] perf/core: Skip empty AUX records with only format flags
Date: Thu, 27 Aug 2026 14:28:22 +0000	[thread overview]
Message-ID: <20260827142823.6B7C01F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260827-perf_core_fix_zero_aux_records-v2-1-c41f2e7d056c@arm.com>

> perf_aux_output_end() emits a PERF_RECORD_AUX when the recorded size is
> nonzero or when any flag other than PERF_AUX_FLAG_OVERWRITE is set.
> 
> PMU format flags describe how an AUX payload is encoded. TRBE driver
> sets PERF_AUX_FLAG_CORESIGHT_FORMAT_RAW for raw trace buffers, causing
> an AUX record to be emitted even when no trace data.
> 
> This is noticeable when tracing a task with strace. Ptrace stops
> repeatedly end empty AUX transactions, producing many zero-sized
> PERF_RECORD_AUX records. For example:
> 
>   perf record -e cs_etm//u -m,128M -- strace ls
> 
>   perf script -D 2>&1 |
>      awk '/PERF_RECORD_AUX offset/ {
> [ ... ]
> 
> Fixes: 547b60988e63 ("perf: aux: Add flags for the buffer format")
> Reported-by: Tamas Petz <tamas.petz@arm.com>
> Reviewed-by: James Clark <james.clark@linaro.org>
> Signed-off-by: Leo Yan <leo.yan@arm.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260827-perf_core_fix_zero_aux_records-v2-1-c41f2e7d056c@arm.com?part=1


      reply	other threads:[~2026-08-27 14:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-27 14:23 [PATCH v2] perf/core: Skip empty AUX records with only format flags Leo Yan
2026-08-27 14:28 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260827142823.6B7C01F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=leo.yan@arm.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.