From: sashiko-bot@kernel.org
To: "Thierry Reding" <thierry.reding@kernel.org>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/4] dt-bindings: thermal: Add Tegra264 header
Date: Thu, 27 Aug 2026 15:14:28 +0000 [thread overview]
Message-ID: <20260827151428.972651F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260827-tegra264-fan-v1-2-3c55f0c748b1@nvidia.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Typo in the `#endif` include guard trailing comment.
--
commit 925e38b8ce54efbdda094d93d18bb0768571876d
Author: Thierry Reding <treding@nvidia.com>
dt-bindings: thermal: Add Tegra264 header
This header file defines the set of thermal zones exposed by the BPMP on
Tegra264.
> diff --git a/include/dt-bindings/thermal/nvidia,tegra264-bpmp.h b/include/dt-bindings/thermal/nvidia,tegra264-bpmp.h
> new file mode 100644
> index 0000000000000..b327396913856
> --- /dev/null
> +++ b/include/dt-bindings/thermal/nvidia,tegra264-bpmp.h
[ ... ]
> +#define TEGRA264_THERMAL_ZONE_SOC_012_MAX 9
> +#define TEGRA264_THERMAL_ZONE_SOC_345_MAX 10
> +#define TEGRA264_THERMAL_ZONE_TJ_AVG 11
> +
> +#endif /* DT_BINDINGS_THERMAL_NVIDIA_TEGAR264_BPMP_H */
[Severity: Low]
This isn't a bug, but there is a typo in the trailing comment for the
include guard. It reads TEGAR264 instead of TEGRA264.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260827-tegra264-fan-v1-0-3c55f0c748b1@nvidia.com?part=2
next prev parent reply other threads:[~2026-08-27 15:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-27 15:07 [PATCH 0/4] arm64: tegra: Add cooling device on Jetson AGX Thor DevKit Thierry Reding
2026-08-27 15:07 ` [PATCH 1/4] arm64: tegra: Add PWM fan on Jetson AGX Orin DevKit Thierry Reding
2026-08-27 15:18 ` sashiko-bot
2026-08-27 15:07 ` [PATCH 2/4] dt-bindings: thermal: Add Tegra264 header Thierry Reding
2026-08-27 15:14 ` sashiko-bot [this message]
2026-08-27 16:35 ` Conor Dooley
2026-08-27 17:17 ` Thierry Reding
2026-08-27 17:33 ` Conor Dooley
2026-08-31 7:13 ` Krzysztof Kozlowski
2026-08-27 15:07 ` [PATCH 3/4] arm64: tegra: Add thermal zones for Tegra264 Thierry Reding
2026-08-27 15:07 ` [PATCH 4/4] arm64: tegra: Add cooling device on Jetson AGX Thor DevKit Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260827151428.972651F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=thierry.reding@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.