Re: [PATCH] mm/damon/core: remove declaration of kdamond_fn()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Removing the forward declaration of `kdamond_fn` causes a build failure because it is referenced in `__damon_start` before its definition.
--

commit 38eba93e0517bb327a80a5c61f1f8b5a41ec274d
Author: Zenghui Yu (Huawei) <zenghui.yu@linux.dev>

mm/damon/core: remove declaration of kdamond_fn()

It was added by commit 2224d8485492 ("mm: introduce Data Access MONitor
(DAMON)") but is actually not needed.  Remove it.

> diff --git a/mm/damon/core.c b/mm/damon/core.c
> index 644daf5a16560..67d93b57a8947 100644
> --- a/mm/damon/core.c
> +++ b/mm/damon/core.c
> @@ -1922,8 +1922,6 @@ static unsigned long damon_apply_min_nr_regions(struct damon_ctx *ctx)
>  	return max_region_sz;
>  }
>  
> -static int kdamond_fn(void *data);
> -

[Severity: Low]
Does removing this forward declaration cause a build failure?

It looks like kdamond_fn is referenced shortly after in __damon_start(), but
its actual definition doesn't occur until much later in the file:

mm/damon/core.c:__damon_start() {
        ...
		ctx->kdamond = kthread_run(kdamond_fn, ctx, "kdamond.%d",
				nr_running_ctxs);
        ...
}

Will the compiler fail when compiling mm/damon/core.c because kdamond_fn is
used before it is defined?

>  /*
>   * __damon_start() - Starts monitoring with given context.
>   * @ctx:	monitoring context

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260827163953.83520-1-zenghui.yu@linux.dev?part=1