From: sashiko-bot@kernel.org
To: han.xu@oss.nxp.com
Cc: Frank.Li@kernel.org, imx@lists.linux.dev,
"Takahiro Kuwano" <takahiro.kuwano@infineon.com>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
"Richard Weinberger" <richard@nod.at>,
"Pratyush Yadav" <pratyush@kernel.org>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Michael Walle" <mwalle@kernel.org>
Subject: Re: [PATCH v2] mtd: spinand: add support for ISSI SPI NAND flash
Date: Thu, 27 Aug 2026 20:49:31 +0000 [thread overview]
Message-ID: <20260827204931.79B0E1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260827-spinand_issi-v2-1-88e04b19f4fa@nxp.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The model name string for the IS37/38SML04G8B chip is missing the 'B' suffix.
--
commit 867e3767a2e52431d703ca0fa7e8144775792a0a
Author: Bill Lee <blee@issi.com>
mtd: spinand: add support for ISSI SPI NAND flash
This commit adds a new manufacturer driver for ISSI SPI NAND devices. It
provides support for four 1Gb-4Gb chip models with different voltages and
stacking configurations.
Link: https://patch.msgid.link/20260825-spinand_issi-v1-1-d81bdd7c212d@nxp.com
> diff --git a/drivers/mtd/nand/spi/issi.c b/drivers/mtd/nand/spi/issi.c
> new file mode 100644
> index 0000000000000..122b3a6e2f62e
> --- /dev/null
> +++ b/drivers/mtd/nand/spi/issi.c
[ ... ]
> +static const struct spinand_info issi_spinand_table[] = {
[ ... ]
> + /* IS37/38SML04G8B 4Gb 3.3V */
> + SPINAND_INFO("IS37/38SML04G8",
[Severity: Medium]
Is the model name missing the 'B' suffix here?
The inline comment right above this line and the commit message indicate the
model is IS37/38SML04G8B, and other chips in this table correctly include
the suffix.
Could this mismatch between the code and the intended hardware name break
userspace tools or udev rules that rely on exact MTD model string matching?
> + SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0x34),
> + NAND_MEMORG(1, 2048, 128, 64, 2048, 40, 1, 1, 2),
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260827-spinand_issi-v2-1-88e04b19f4fa@nxp.com?part=1
prev parent reply other threads:[~2026-08-27 20:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-27 20:39 [PATCH v2] mtd: spinand: add support for ISSI SPI NAND flash han.xu
2026-08-27 20:39 ` han.xu
2026-08-27 20:49 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260827204931.79B0E1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=han.xu@oss.nxp.com \
--cc=imx@lists.linux.dev \
--cc=miquel.raynal@bootlin.com \
--cc=mwalle@kernel.org \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=sashiko-reviews@lists.linux.dev \
--cc=takahiro.kuwano@infineon.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.