From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3D0338DC60 for ; Thu, 27 Aug 2026 21:08:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787864904; cv=none; b=unhnkbXwbH0JvTjfnVZUlYCF88kqJzw1DdP49n3NF/7Ie8ZzhPDrrK2YremlNFMqy3n6c/JOkn28VZJiDzBGFu/llECwIIc+pWnG7JuTFu7p8eGy9zgu/T/D91zkFiiGlkcH9X9wUOK/tK5+zoWsRqpHE8TcXfPhHy8zNfIgNp8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787864904; c=relaxed/simple; bh=+xIX1eMAZoyAFbWbcnOY7u7uOA+U/uYBXIImHcni9IQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=krqwyyGpGrKZMf2q4g6pT+wI8ZT03TsImVIyLSh1l7+MKWvSsLEkyR/rTmpAWddA0OgZACrGa4NT6PsUoae2/FeSsiPz58trr4dm1aDxVD1HRuYT0e5wvwbW09/Yka3EXcgGlLKNnnPNYUqMnElwBuv3FpKmQdixai3mgWqflLU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=att3x2UI; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="att3x2UI" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-49b0dbfbf7bso1545215e9.2 for ; Thu, 27 Aug 2026 14:08:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787864901; x=1788469701; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+xIX1eMAZoyAFbWbcnOY7u7uOA+U/uYBXIImHcni9IQ=; b=att3x2UIVCOC8Iv5ajnga+INBMCP0BuAZ6k8NVH4W/WHb3RYsR3VWUqDAX7/lrHsik iFEdjlqWl7x/mzSTn+NET5NIx1O6UqzfpbkuvMV0VHwvgJLckztHXIkq4eLWVrlLamSN RE2fYHjzn1qrgptiiu6fkI7lphJqtH738u0HkpjJ44iUHmp16ZZM0yhkEPN5vTEoRIYD Z/5JBpTRTFpYfLv4JFBujNLX7tjYsjmVFov/L8wteC6611+/jx2l2zCMaMocF+R7jBxC EMLNDTE1JeLrQH0iCie01wn+2GM7IS+9/nLcVApUA9Tr67Y2tbeOiWfTQAhzmReSz3zt D1uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787864901; x=1788469701; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=+xIX1eMAZoyAFbWbcnOY7u7uOA+U/uYBXIImHcni9IQ=; b=GLo5wgaWZX0rAjd8T0xsEXu6Ah+E8iZpsgf65bsPqY3CwSbwvUVpIMKyLEydECHesA I9m4mgoWirKiBlPRKZe9WgaxpNG2Cn3GQH5Ui3hW7GMXRn25VlmuxJPI8zS4j7M+A6fN 7KCWBeX4Kf8yk3LHYXwRXs7lH9JRnra+MZExaqY2jrWkXAyWSK3tAtVuUAsOtFTtasrN 5aGCUxZLumq6kdC/XbsNDZaD1ZMr/lZ8WKZhIl0+Imzd2lkolm3sZhra4IZ8f+rELnoy BwWkD/mBMW6yRC8ZMw1scpikqDwvbxxjrv/YbkF+p1IEJYe0eV/tpt14IBush5cEASAX 3QhA== X-Forwarded-Encrypted: i=1; AHgh+RpXZVsoVcFZ8r0t1KMrdajymStsRIuMHBLNCrz5xgS/9n8p+rJYCRcRGXrOZMcB/BBitsSmMkfO2M8=@vger.kernel.org X-Gm-Message-State: AFuF++mGVRI+zswRjitWVDhB9IHyVsu9tX49csJp2uPokgmm7IiysCxA P901MHysTFrDbKz7OsCLEJYoJCNFUQx+8js1CqSLb8cGxd5ayRFjcTpczWe8jjfv X-Gm-Gg: AR+sD13azzwW0yp25O7+rENz012KuiheyYDzMqHsA3kWnTKfUFcgrmDPmiD1FdN2ir/ Y6KN1hac6+yDj0scSF47XJwY2IDhvL678d3V6yjY4xqBDdfoygzIi4w5wRS/2+18j4pwnCFwnGa QItlsSBHF5G8D6dfgMpKtI5ljvid2G9Bdc3KpFSwaXArnrMABuTO+BRJoYPQMmu9Icw01Eb2zzb LwtXJmjg6ilP7N3FodaIoOJcDaOy/kB7Dzq7d1wyZpJ8KC+7q3VEaq9m0quUnS+S53TcwF0vEM0 CflTz5iNuiQglBO/vUGHAEixCAraNfittPqumHqPn33Fev25fccVGjXH7gcoidAZ1ls85lu3/5Z 9kq2dLrPKU5fiIgEf4lJ6Di1tyKhHu+bmEn+jNMrsb7W5+qHUzKPLxUJK2Uoj1+gvC9McrSy0YZ 8BapX4rvYSOflI/6XerIOdE9j34nk4WNyC2lrANtYAdez9Q6NQXfVD1r+fuw1I9czySHoGGw== X-Received: by 2002:a05:600c:3b1a:b0:495:4d5c:903e with SMTP id 5b1f17b1804b1-49b91c2d8f3mr24218465e9.7.1787864900998; Thu, 27 Aug 2026 14:08:20 -0700 (PDT) Received: from m2.. ([37.142.156.156]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-49b4ad16262sm64764375e9.11.2026.08.27.14.08.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Aug 2026 14:08:20 -0700 (PDT) From: Michael Zaidman To: linusw@kernel.org Cc: jikos@kernel.org, bentiss@kernel.org, brgl@kernel.org, germain.hebert@ca.abb.com, rio@r26.me, brunoceg1@gmail.com, contact@christina-quast.de, linux-input@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 10/13] HID: ft260: uart: fix active-low RTS/CTS/DTR/DSR polarity Date: Fri, 28 Aug 2026 00:08:08 +0300 Message-ID: <20260827210809.19389-1-michael.zaidman@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Tue, 25 Aug 2026 at 10:16 +0200, Linus Walleij wrote: > Isn't this just fixing a patch earlier in the same series? > > Just fold it in with the patch adding this. It is, and I have no objection to folding it into the patch that adds TIOCMGET/TIOCMSET, but it costs an attribution I would rather not drop on my own. This patch is Rio's: From: Rio Liu, signed off by him and then by me. The layout of this series, including Rio authoring the polarity fix, is what I agreed with Jiri before posting. Folding it into my patch 8 turns that From: into a Co-developed-by: Rio Liu with his sign-off, which is honest but is a demotion from author to contributor. Jiri, Rio - either is fine by me, so tell me which you prefer and v2 will do that. > Note: GPIOlib has it's own polarity inversion handling, when > you rewrite the serial modem control to use the helpers, > the gpio table will include a flag for polarity inversion, and > then you just put it there. Understood. If the modem control moves to the mctrl-gpio helpers then the inversion belongs in the lookup table as GPIO_ACTIVE_LOW and this code goes away entirely. I'm looking into that on your patch 8 mail and will answer there. Worth noting that this drops Rio's patch rather than folds it - none of his lines would survive the rewrite - so the credit would have to move to the commit message body with a link to his fix. Thanks, Michael