Re: [RFC PATCH v1.2 3/4] mm/damon/core: copy nid for eligible_mem_bp damos quota goal commit

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The KUnit tests in `mm/damon/tests/core-kunit.h` were not updated to verify the bug fix for the `DAMOS_QUOTA_NODE_ELIGIBLE_MEM_BP` metric.
--

commit 2e3746fc6a44e14dd4bda23054c960b1e043e013
Author: SJ Park <sj@kernel.org>

mm/damon/core: copy nid for eligible_mem_bp damos quota goal commit

damos_commit_quota_goal_union() does not update the nid union field when the
goal metric is DAMOS_QUOTA_NODE_ELIGIBLE_MEM_BP. This commit adds the
missing update to ensure it does not use a garbage nid value.

Link: https://lore.kkernel.org/20260827045035.94611-1-sj@kernel.org

> diff --git a/mm/damon/core.c b/mm/damon/core.c
> index b0c8e22ab5404..086d2ac57259f 100644
> --- a/mm/damon/core.c
> +++ b/mm/damon/core.c
> @@ -1136,6 +1136,9 @@ static void damos_commit_quota_goal_union(
>  		dst->nid = src->nid;
>  		dst->memcg_id = src->memcg_id;
>  		break;
> +	case DAMOS_QUOTA_NODE_ELIGIBLE_MEM_BP:
> +		dst->nid = src->nid;
> +		break;

[Severity: Medium]
Since this case was added here, do we also need to update the corresponding
KUnit tests in mm/damon/tests/core-kunit.h?

Currently, damos_test_commit_quota_goal_for() is missing the case for
DAMOS_QUOTA_NODE_ELIGIBLE_MEM_BP:

mm/damon/tests/core-kunit.h:damos_test_commit_quota_goal_for() {
    ...
	switch (dst->metric) {
	case DAMOS_QUOTA_SOME_MEM_PSI_US:
		KUNIT_EXPECT_EQ(test, dst->last_psi_total, U64_MAX);
		break;
	case DAMOS_QUOTA_NODE_MEM_USED_BP:
	case DAMOS_QUOTA_NODE_MEM_FREE_BP:
		KUNIT_EXPECT_EQ(test, dst->nid, src->nid);
		break;
	case DAMOS_QUOTA_NODE_MEMCG_USED_BP:
	case DAMOS_QUOTA_NODE_MEMCG_FREE_BP:
		KUNIT_EXPECT_EQ(test, dst->nid, src->nid);
		KUNIT_EXPECT_EQ(test, dst->memcg_id, src->memcg_id);
		break;
	default:
		break;
	}
}

Should a test case for DAMOS_QUOTA_NODE_ELIGIBLE_MEM_BP also be added
to damos_test_commit_quota_goal() to ensure the fix is validated?

>  	default:
>  		break;
>  	}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260828014659.121058-1-sj@kernel.org?part=3