Re: [PATCH v13 4/6] dt-bindings: arm: qcom: Document Nord reference boards

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The root compatible binding omits the specific SoC compatible strings (qcom,sa8797p and qcom,iq10), forcing a 2-item array that breaks SoC-specific matching.
--

commit e7840dc716d1200acb611d432fcd24729d2913ba
Author: Shawn Guo <shengchao.guo@oss.qualcomm.com>

dt-bindings: arm: qcom: Document Nord reference boards

Nord is a new generation of SoC series from Qualcomm which includes SA8797P and
Dragonwing IQ10. This commit documents the SA8797P Ride and IQ10 Robotics
Reference Design (RRD) boards.

> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index ff8a35df7862d..198314ddaa84a 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -402,6 +402,12 @@ properties:
>                - xiaomi,sagit
>            - const: qcom,msm8998
>  
> +      - items:
> +          - enum:
> +              - qcom,iq10-rrd
> +              - qcom,sa8797p-ride
> +          - const: qcom,nord

[Severity: Medium]
Does this strict 2-item array intentionally omit the specific SoC compatible
strings (qcom,sa8797p and qcom,iq10)?

Standard Device Tree practice usually requires the exact SoC string to be
present in the root compatible array before the generic family fallback. By
enforcing a 2-item array, the schema requires the device tree to omit the
specific SoC strings.

This prevents SoC-level drivers (like cpufreq-dt-platdev or qcom_pd_mapper)
from matching the specific SoC or applying quirks without hardcoding every
single board compatible. Note that qcom,sa8797p is actively used as an SoC
identifier for IP blocks (e.g., qcom,sa8797p-geni-spi).

Could the binding be updated to include the specific SoC strings as an
intermediate fallback before qcom,nord?

> +
>        - description: Qualcomm Technologies, Inc. Robotics RB1
>          items:
>            - enum:

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260828034958.3165-1-shengchao.guo@oss.qualcomm.com?part=4