From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52754C61DC6 for ; Fri, 28 Aug 2026 08:56:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=E6YfjITekMwVuZ/sJmHNc9pcEdCt7LQPNpLJcWjlJ5E=; b=WvJHWMarOA95SD 6HDx0WypglT+NuiTnNzxe8DxuPNB+Jg0cdp0GO1CLnprKEEOdvAWo2VjyToL9WnmSXfZLE3EoX5wR s7GEIQhhf+pRzI5+lZh9bfw9tTbri3VfDDMSfqEuuLID8KlL8GRFxxH8PO2nWjeFSMJELrAAVFa8G tOVIOQycmqEK3vQhIgZaL7qNjma4uawmcEY4fv9cb9U4Q8GS8mZs+ZSOYZLJ7hoeqmjNwRz0J8ijL pB7oZZiMG1Z+fdDyzDOlrFm5lX3H5lu0pL6qGrJev0mmbzDcFASJQD/DHLQRSOGDoOR/K3rDl1FTM MgghnrOIR6cMnxTfuqlQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wzsO5-00000005NJm-07sm; Fri, 28 Aug 2026 08:56:37 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wzsO3-00000005NJW-49CK for linux-phy@lists.infradead.org; Fri, 28 Aug 2026 08:56:36 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 34C63601F7; Fri, 28 Aug 2026 08:56:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 922FD1F000E9; Fri, 28 Aug 2026 08:56:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787907394; bh=K91hK6EiEK54KMzCCrvx+T2/sDYj5zsj9Wh5luVu3vQ=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=Qf92CfQI1MjPl2FTOwyAR8uJbIR2Y7jlIQvMF1b8uMQtTfUz+rXRTfL8EVG9HWCjN TPlGNC7ebh03xFoWpW5eCihHXmjM3jjVhpszRtNOpwCp0EzyStLXBDXiLCbLe2mBnZ CYnz5wP25pbnvb9X4l2rpPIEQ8edANFUprWoy25+i7KYHREo29K7iBFmExkQLsssWY kNMSs33n8hI3ZElRiItPnrz3GKFI2LHOv6/fP0g4vrVcgkz08Hbl9WgHCXuAXSMRpb ukPxPFywPH1J3DjoscpHMRsXOlWE+zLVzEGWSI0h5VTLSnxyp4LCDxcgESsJTlX+1C 77rZv4cZMk4wg== From: sashiko-bot@kernel.org Subject: Re: [PATCH v7 3/7] drm/display: Add soft depend for aux-hpd-typec-dp-bridge module To: "Chaoyi Chen" Cc: linux-phy@lists.infradead.org, dri-devel@lists.freedesktop.org, vkoul@kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com In-Reply-To: <20260828084737.565-4-kernel@airkyi.com> References: <20260828084737.565-1-kernel@airkyi.com> <20260828084737.565-4-kernel@airkyi.com> Date: Fri, 28 Aug 2026 08:56:34 +0000 Message-Id: <20260828085634.922FD1F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW01lZGl1bV0gRGVwZW5kZW5jeSBp bnZlcnNpb24gdW5jb25kaXRpb25hbGx5IGxvYWRzIFVTQiBUeXBlLUMgc3Vic3lzdGVtIG9uIGFs bCBEUC1jYXBhYmxlIHN5c3RlbXMKLS0KCmNvbW1pdCAxOGU3NWRmNTU5OWViM2MzNDc5ZGMxMDAy NTQ3ZGNmNWY2YTE1OTNiCkF1dGhvcjogQ2hhb3lpIENoZW4gPGNoYW95aS5jaGVuQHJvY2stY2hp cHMuY29tPgoKZHJtL2Rpc3BsYXk6IEFkZCBzb2Z0IGRlcGVuZCBmb3IgYXV4LWhwZC10eXBlYy1k cC1icmlkZ2UgbW9kdWxlCgpUaGlzIGNvbW1pdCBhZGRzIGEgc29mdCBkZXBlbmRlbmN5IGluIHRo ZSBkcm1fZGlzcGxheV9oZWxwZXIgbW9kdWxlIGZvciB0aGUKYXV4LWhwZC10eXBlYy1kcC1icmlk Z2UgbW9kdWxlLiBUaGlzIGVuc3VyZXMgdGhlIGJyaWRnZSBtb2R1bGUgaXMgbG9hZGVkCmVhcmx5 LCBhcyBpdCBzZXJ2ZXMgYXMgYSBnZW5lcmljIFR5cGUtQyBEaXNwbGF5UG9ydCBIUEQgYnJpZGdl IHRoYXQgaXNuJ3QKZGlyZWN0bHkgcmVxdWlyZWQgYnkgYW55IG90aGVyIG1vZHVsZS4KCj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kaXNwbGF5L2RybV9kaXNwbGF5X2hlbHBlcl9tb2Qu YyBiL2RyaXZlcnMvZ3B1L2RybS9kaXNwbGF5L2RybV9kaXNwbGF5X2hlbHBlcl9tb2QuYwo+IGlu ZGV4IGQ4YTZlNjIyODc3MzYuLmYwMTUyZDZiMGIyZDcgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2Rpc3BsYXkvZHJtX2Rpc3BsYXlfaGVscGVyX21vZC5jCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2Rpc3BsYXkvZHJtX2Rpc3BsYXlfaGVscGVyX21vZC5jCj4gQEAgLTE4LDUgKzE4LDYg QEAgc3RhdGljIHZvaWQgX19leGl0IGRybV9kaXNwbGF5X2hlbHBlcl9tb2R1bGVfZXhpdCh2b2lk KQo+ICAJZHJtX2RwX2F1eF9kZXZfZXhpdCgpOwo+ICB9Cj4gIAo+ICtNT0RVTEVfU09GVERFUCgi cHJlOiBhdXgtaHBkLXR5cGVjLWRwLWJyaWRnZSIpOwoKW1NldmVyaXR5OiBNZWRpdW1dCkRvZXMg YWRkaW5nIGEgc29mdCBkZXBlbmRlbmN5IG9uIGF1eC1ocGQtdHlwZWMtZHAtYnJpZGdlIHRvIHRo ZSBjb3JlCmRybV9kaXNwbGF5X2hlbHBlciBtb2R1bGUgY3JlYXRlIGFuIGFyY2hpdGVjdHVyYWwg ZGVwZW5kZW5jeSBpbnZlcnNpb24/CgpUaGUgbGVhZiBicmlkZ2UgZHJpdmVyIChhdXgtaHBkLXR5 cGVjLWRwLWJyaWRnZSkgaGFzIGEgaGFyZCBkZXBlbmRlbmN5IG9uIHRoZQp0eXBlYyBjb3JlIHN1 YnN5c3RlbSBiZWNhdXNlIGl0IHJlZ2lzdGVycyBhIGJ1cyBub3RpZmllciBvbiB0eXBlY19idXMu IEFzIGEKcmVzdWx0LCB3aGVuIGEgc3lzdGVtIGxvYWRzIGEgRFJNIGRyaXZlciB0aGF0IHV0aWxp emVzIGdlbmVyaWMgZGlzcGxheSBoZWxwZXJzCihzdWNoIGFzIGFtZGdwdSwgaTkxNSwgb3Igbm91 dmVhdSksIHdvbid0IHRoaXMgdW5jb25kaXRpb25hbGx5IHB1bGwgdGhlIGVudGlyZQpVU0IgVHlw ZS1DIHN1YnN5c3RlbSBpbnRvIG1lbW9yeT8KClRoaXMgc2VlbXMgbGlrZSBpdCBtaWdodCB3YXN0 ZSBtZW1vcnkgcmVzb3VyY2VzIG9uIHN5c3RlbXMgd2l0aG91dCBUeXBlLUMKaGFyZHdhcmUgYnkg YXV0b21hdGljYWxseSBsb2FkaW5nIGF1eC1ocGQtdHlwZWMtZHAtYnJpZGdlLmtvIChhbmQgY29u c2VxdWVudGx5CnR5cGVjLmtvKSB1cG9uIGxvYWRpbmcgYW55IHN0YW5kYXJkIERSTSBkcml2ZXIu IElzIHRoZXJlIGEgYmV0dGVyIHdheSB0bwpoYW5kbGUgdGhpcyB3aXRob3V0IGJ1cmRlbmluZyBh bGwgZ2VuZXJpYyBkaXNwbGF5IGhlbHBlciB1c2Vycz8KCj4gIG1vZHVsZV9pbml0KGRybV9kaXNw bGF5X2hlbHBlcl9tb2R1bGVfaW5pdCk7Cj4gIG1vZHVsZV9leGl0KGRybV9kaXNwbGF5X2hlbHBl cl9tb2R1bGVfZXhpdCk7CgotLSAKU2FzaGlrbyBBSSByZXZpZXcgwrcgaHR0cHM6Ly9zYXNoaWtv LmRldi8jL3BhdGNoc2V0LzIwMjYwODI4MDg0NzM3LjU2NS0xLWtlcm5lbEBhaXJreWkuY29tP3Bh cnQ9MwoKLS0gCmxpbnV4LXBoeSBtYWlsaW5nIGxpc3QKbGludXgtcGh5QGxpc3RzLmluZnJhZGVh ZC5vcmcKaHR0cHM6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgt cGh5Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CAE40C61DB9 for ; Fri, 28 Aug 2026 08:56:37 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3843F10F2F9; Fri, 28 Aug 2026 08:56:37 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="Qf92CfQI"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id 120ED10E0E1 for ; Fri, 28 Aug 2026 08:56:36 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 34C63601F7; Fri, 28 Aug 2026 08:56:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 922FD1F000E9; Fri, 28 Aug 2026 08:56:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787907394; bh=K91hK6EiEK54KMzCCrvx+T2/sDYj5zsj9Wh5luVu3vQ=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=Qf92CfQI1MjPl2FTOwyAR8uJbIR2Y7jlIQvMF1b8uMQtTfUz+rXRTfL8EVG9HWCjN TPlGNC7ebh03xFoWpW5eCihHXmjM3jjVhpszRtNOpwCp0EzyStLXBDXiLCbLe2mBnZ CYnz5wP25pbnvb9X4l2rpPIEQ8edANFUprWoy25+i7KYHREo29K7iBFmExkQLsssWY kNMSs33n8hI3ZElRiItPnrz3GKFI2LHOv6/fP0g4vrVcgkz08Hbl9WgHCXuAXSMRpb ukPxPFywPH1J3DjoscpHMRsXOlWE+zLVzEGWSI0h5VTLSnxyp4LCDxcgESsJTlX+1C 77rZv4cZMk4wg== From: sashiko-bot@kernel.org Subject: Re: [PATCH v7 3/7] drm/display: Add soft depend for aux-hpd-typec-dp-bridge module To: "Chaoyi Chen" Cc: linux-phy@lists.infradead.org, dri-devel@lists.freedesktop.org, vkoul@kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com In-Reply-To: <20260828084737.565-4-kernel@airkyi.com> References: <20260828084737.565-1-kernel@airkyi.com> <20260828084737.565-4-kernel@airkyi.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 28 Aug 2026 08:56:34 +0000 Message-Id: <20260828085634.922FD1F000E9@smtp.kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] Dependency inversion unconditionally loads USB Type-C subsystem = on all DP-capable systems -- commit 18e75df5599eb3c3479dc1002547dcf5f6a1593b Author: Chaoyi Chen drm/display: Add soft depend for aux-hpd-typec-dp-bridge module This commit adds a soft dependency in the drm_display_helper module for the aux-hpd-typec-dp-bridge module. This ensures the bridge module is loaded early, as it serves as a generic Type-C DisplayPort HPD bridge that isn't directly required by any other module. > diff --git a/drivers/gpu/drm/display/drm_display_helper_mod.c b/drivers/g= pu/drm/display/drm_display_helper_mod.c > index d8a6e62287736..f0152d6b0b2d7 100644 > --- a/drivers/gpu/drm/display/drm_display_helper_mod.c > +++ b/drivers/gpu/drm/display/drm_display_helper_mod.c > @@ -18,5 +18,6 @@ static void __exit drm_display_helper_module_exit(void) > drm_dp_aux_dev_exit(); > } > =20 > +MODULE_SOFTDEP("pre: aux-hpd-typec-dp-bridge"); [Severity: Medium] Does adding a soft dependency on aux-hpd-typec-dp-bridge to the core drm_display_helper module create an architectural dependency inversion? The leaf bridge driver (aux-hpd-typec-dp-bridge) has a hard dependency on t= he typec core subsystem because it registers a bus notifier on typec_bus. As a result, when a system loads a DRM driver that utilizes generic display help= ers (such as amdgpu, i915, or nouveau), won't this unconditionally pull the ent= ire USB Type-C subsystem into memory? This seems like it might waste memory resources on systems without Type-C hardware by automatically loading aux-hpd-typec-dp-bridge.ko (and consequen= tly typec.ko) upon loading any standard DRM driver. Is there a better way to handle this without burdening all generic display helper users? > module_init(drm_display_helper_module_init); > module_exit(drm_display_helper_module_exit); --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260828084737.565-= 1-kernel@airkyi.com?part=3D3