From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 672FFC61DC6 for ; Fri, 28 Aug 2026 09:14:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jZfRDpPGJ2iR+LfPPM08tsBVY98SXttG4n3RcGYsvcA=; b=J5JkMc/VQ8WYds qpzJFHO5Vg3PXEsv05MOEbxR6wPw/toKDZT55kOgTELEQuyyrq43VxH2q4Cdryx0gs7rP2wA49o3P jbrMuzIficOfTbj77lD8UszlIVAotFug09O0b8uqckYHoc6MVorcHt/RGFO4ghbSWW7UAxFRTgGmk C7omMX9hwI1iAmyIpmYWmE2df109sMmT3dWHbFtoAb+3pFTycvJt0rCHBpcLVOFc0jsSDn6yR4Hvx 7F2X9gM9HCaHRLBeJQiQxq7wdO9m8elYN8R+mFwVct+MraxlfBxKMoZdxter/VIRf3TVrU1fDLTOe cEihTAE1aKb1TRJXQYBA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wzsfN-00000005PsJ-0MLN; Fri, 28 Aug 2026 09:14:29 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wzsfM-00000005Prb-0lVL for linux-phy@lists.infradead.org; Fri, 28 Aug 2026 09:14:28 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 9DF664190A; Fri, 28 Aug 2026 09:14:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C9381F00A3A; Fri, 28 Aug 2026 09:14:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787908467; bh=6jtVWyW3lAo3HEsJHl0q4U7URdaSfejciHwbR2r8Pe8=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=lHOoEgZNIsaRzo638nNSYRvc/MjYVZ/BtVHfkv5lM48GdDJ2Wpc8VsN46Ym4bRxr+ sf4Zjdd9xNnDi17IVITTttkA4abBTq6ImttOrYtbm58easlqLM2KUtz5Um3mEtkgnq HzfCAg5Fl+78HFAUTid8HOBay4AbM0lz277Sq7PfmWOzitVv3NB8U/kKdGRdXpFaoy FA8Mu+Wqji3xDv7rS3EmaKmXzkCrtQYckqRXk3ZwQi0gKBp5O8FtsKTRMLvErPveoQ 34SjYm+qHxuvUmRM9VJ2UEvIP67fuykbX0VudKlxeupQE3PZm1QVTsI7nX96IykrxA 6UuIP+OTKodnA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v7 7/7] drm/rockchip: cdn-dp: Add multiple bridges to support PHY port selection To: "Chaoyi Chen" Cc: linux-phy@lists.infradead.org, olteanv@gmail.com, dri-devel@lists.freedesktop.org, vkoul@kernel.org, neil.armstrong@linaro.org In-Reply-To: <20260828084737.565-8-kernel@airkyi.com> References: <20260828084737.565-1-kernel@airkyi.com> <20260828084737.565-8-kernel@airkyi.com> Date: Fri, 28 Aug 2026 09:14:26 +0000 Message-Id: <20260828091427.4C9381F00A3A@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg NSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0hpZ2hdIE1pc3NpbmcgYXRvbWlj X2NoZWNrIHRvIHByZXZlbnQgY29uY3VycmVudCBlbmFibGVtZW50IG9mIG11dHVhbGx5IGV4Y2x1 c2l2ZSBEUCBicmlkZ2VzLgotIFtIaWdoXSBIYXJkd2FyZSByZWdpc3RlcnMgYXJlIGFjY2Vzc2Vk IHdoaWxlIERQIGNsb2NrcyBhcmUgZGlzYWJsZWQsIGxlYWRpbmcgdG8gYSBzeW5jaHJvbm91cyBl eHRlcm5hbCBhYm9ydCBhbmQga2VybmVsIHBhbmljLgotIFtIaWdoXSBUaGUgZHJpdmVyIGZhaWxz IHRvIHByb3BhZ2F0ZSBpbnRlcm5hbCBob3RwbHVnIHN0YXRlIGNoYW5nZXMgdG8gdXNlcnNwYWNl IGJlY2F1c2UgaXRzIGJyaWRnZSBubyBsb25nZXIgcmVjZWl2ZXMgdGhlIEhQRCBjYWxsYmFjay4K LSBbSGlnaF0gVmlkZW8gcGlwZWxpbmUgY29uZmlndXJhdGlvbiBpcyBpbmFwcHJvcHJpYXRlbHkg ZXhlY3V0ZWQgZHVyaW5nIEVESUQgcmVhZCwgbGVhZGluZyB0byBpbmV2aXRhYmxlIGZhaWx1cmUg b24gc2Vjb25kYXJ5IHBvcnRzLgotIFtNZWRpdW1dIFRoZSBjb25uZWN0ZWQgc3RhdHVzIG9mIGJy aWRnZXMgaXMgdXBkYXRlZCBhbmQgcmVhZCBjb25jdXJyZW50bHkgd2l0aG91dCBob2xkaW5nIHRo ZSBuZWNlc3Nhcnkgc3luY2hyb25pemF0aW9uIGxvY2tzLgotLQoKY29tbWl0IGE0NTU4OGRmOTkw YmIxMWY0MDJiYTk4ZjU2MDUyYmVjMTQwNWRiOTYKQXV0aG9yOiBDaGFveWkgQ2hlbiA8Y2hhb3lp LmNoZW5Acm9jay1jaGlwcy5jb20+Cgpkcm0vcm9ja2NoaXA6IGNkbi1kcDogQWRkIG11bHRpcGxl IGJyaWRnZXMgdG8gc3VwcG9ydCBQSFkgcG9ydCBzZWxlY3Rpb24KClRoaXMgY29tbWl0IGFkZHMg c3VwcG9ydCBmb3IgbXVsdGlwbGUgYnJpZGdlcyB0byB0aGUgUm9ja2NoaXAgQ0ROLURQIGRyaXZl ciwKYWxsb3dpbmcgZHluYW1pYyBvdXRwdXQgcG9ydCBzZWxlY3Rpb24uIEl0IHJlZ2lzdGVycyBz ZXBhcmF0ZSBlbmNvZGVycyBhbmQKYnJpZGdlcyBmb3IgZWFjaCBQSFkgcG9ydCBhbmQgcGFyc2Vz IHRoZSBkZXZpY2UgdHJlZSB0byBkZXNjcmliZSBjb25uZWN0aW9ucy4KUG9ydCBzd2l0Y2hpbmcg aXMgaGFuZGxlZCBkeW5hbWljYWxseSBkdXJpbmcgRURJRCByZWFkcyBvciB3aGVuIGVuYWJsaW5n IHRoZQpEUCBibG9jay4KCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9j ZG4tZHAtY29yZS5jIGIvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL2Nkbi1kcC1jb3JlLmMKPiBp bmRleCA3NGUxZjU0MjJhNmUyLi45OTkzMDliMzliMzRjIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9yb2NrY2hpcC9jZG4tZHAtY29yZS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3Jv Y2tjaGlwL2Nkbi1kcC1jb3JlLmMKClsgLi4uIF0KCj4gQEAgLTI1NCwxMiArMjY4LDQ1IEBAIHN0 YXRpYyBjb25zdCBzdHJ1Y3QgZHJtX2VkaWQgKgo+ICBjZG5fZHBfYnJpZGdlX2VkaWRfcmVhZChz dHJ1Y3QgZHJtX2JyaWRnZSAqYnJpZGdlLCBzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9y KQo+ICB7Cj4gIAlzdHJ1Y3QgY2RuX2RwX2RldmljZSAqZHAgPSBicmlkZ2VfdG9fZHAoYnJpZGdl KTsKPiAtCWNvbnN0IHN0cnVjdCBkcm1fZWRpZCAqZHJtX2VkaWQ7Cj4gKwlzdHJ1Y3QgY2RuX2Rw X2JyaWRnZSAqZHBfYnJpZGdlID0gYnJpZGdlX3RvX2RwX2JyaWRnZShicmlkZ2UpOwo+ICsJc3Ry dWN0IGNkbl9kcF9wb3J0ICpwb3J0ID0gZHAtPnBvcnRbZHBfYnJpZGdlLT5pZF07Cj4gKwlzdHJ1 Y3QgY2RuX2RwX3BvcnQgKnByZXZfcG9ydCA9IE5VTEw7Cj4gKwljb25zdCBzdHJ1Y3QgZHJtX2Vk aWQgKmRybV9lZGlkID0gTlVMTDsKPiArCWludCBpLCByZXQ7Cj4gIAo+ICAJbXV0ZXhfbG9jaygm ZHAtPmxvY2spOwo+ICsKPiArCS8qIE1vcmUgdGhhbiBvbmUgcG9ydCBpcyBhdmFpbGFibGUgKi8K PiArCWlmIChkcC0+YnJpZGdlX2NvdW50ID4gMSAmJiAhcG9ydC0+cGh5X2VuYWJsZWQpIHsKPiAr CQlmb3IgKGkgPSAwOyBpIDwgZHAtPmJyaWRnZV9jb3VudDsgaSsrKSB7Cj4gKwkJCS8qIEFub3Ro ZXIgcG9ydCBhbHJlYWR5IGVuYWJsZSAqLwo+ICsJCQlpZiAoZHAtPmJyaWRnZV9saXN0W2ldICE9 IGRwX2JyaWRnZSAmJiBkcC0+YnJpZGdlX2xpc3RbaV0tPmVuYWJsZWQpCj4gKwkJCQlnb3RvIGdl dF9jYWNoZTsKPiArCQkJLyogRmluZCBhbHJlYWR5IGVuYWJsZWQgcG9ydCAqLwo+ICsJCQlpZiAo ZHAtPnBvcnRbaV0tPnBoeV9lbmFibGVkKQo+ICsJCQkJcHJldl9wb3J0ID0gZHAtPnBvcnRbaV07 Cj4gKwkJfQo+ICsKPiArCQkvKiBTd2l0Y2ggdG8gY3VycmVudCBwb3J0ICovCj4gKwkJaWYgKHBy ZXZfcG9ydCkgewo+ICsJCQlyZXQgPSBjZG5fZHBfc3dpdGNoX3BvcnQoZHAsIHByZXZfcG9ydCwg cG9ydCk7CgpbU2V2ZXJpdHk6IEhpZ2hdCldpbGwgdGhpcyB2aWRlbyBwaXBlbGluZSBjb25maWd1 cmF0aW9uIGZhaWwgZHVyaW5nIGFuIEVESUQgcmVhZD8KCldoZW4gcmVhZGluZyB0aGUgRURJRCBv biBhIHNlY29uZGFyeSBwb3J0LCB0aGlzIHN3aXRjaGVzIHRoZSBwb3J0IGFuZAp1bHRpbWF0ZWx5 IGNhbGxzIGNkbl9kcF9jb25maWdfdmlkZW8oKSB2aWEgY2RuX2RwX3N3aXRjaF9wb3J0KCkuIFNp bmNlIHRoaXMKaGFwcGVucyBkdXJpbmcgY29ubmVjdG9yIHByb2JpbmcsIG5vIGF0b21pYyBtb2Rl IGhhcyBiZWVuIGNvbW1pdHRlZCB5ZXQsCm1lYW5pbmcgZHAtPm1vZGUuY2xvY2sgaXMgZWl0aGVy IDAgb3IgaG9sZHMgYSBzdGFsZSB2YWx1ZS4KClRoaXMgd2lsbCBjYXVzZSB0aGUgdGltaW5nIGNh bGN1bGF0aW9uIGluIGNkbl9kcF9jb25maWdfdmlkZW8oKSB0byByZXR1cm4KLUVJTlZBTC4gVGhl IHN3aXRjaCB0aGVuIGZhaWxzLCBhbmQgdGhpcyBmdW5jdGlvbiBmYWxscyBiYWNrIHRvIHJldHVy bmluZyB0aGUKY2FjaGUgKHdoaWNoIGlzIE5VTEwgb24gdGhlIGZpcnN0IHBsdWcpLCBicmVha2lu ZyBzZWNvbmRhcnkgcG9ydCBkZXRlY3Rpb24uCgo+ICsJCQlpZiAocmV0KQo+ICsJCQkJZ290byBn ZXRfY2FjaGU7Cj4gKwkJfQo+ICsJfQo+ICsKPiAgCWRybV9lZGlkID0gZHJtX2VkaWRfcmVhZF9j dXN0b20oY29ubmVjdG9yLCBjZG5fZHBfZ2V0X2VkaWRfYmxvY2ssIGRwKTsKCltTZXZlcml0eTog SGlnaF0KSXMgdGhlcmUgYSByaXNrIG9mIGEgc3luY2hyb25vdXMgZXh0ZXJuYWwgYWJvcnQgd2hl biBhY2Nlc3NpbmcgdGhlIERQIGhhcmR3YXJlCnJlZ2lzdGVycyBoZXJlPwoKSG90cGx1ZyBldmVu dHMgZnJvbSBkb3duc3RyZWFtIGJyaWRnZXMgdHJpZ2dlciBjZG5fZHBfYnJpZGdlX2hwZF9ub3Rp ZnkoKSwKd2hpY2ggc2NoZWR1bGVzIGRwLT5ldmVudF93b3JrIHRvIGVuYWJsZSB0aGUgRFAgY2xv Y2tzIGFuZCBoYXJkd2FyZSB2aWEKY2RuX2RwX2VuYWJsZSgpLiBBdCB0aGUgc2FtZSB0aW1lLCB0 aGUgRFJNIGNvcmUgcHJvY2Vzc2VzIHRoZSBob3RwbHVnIGV2ZW50CmFuZCBzY2hlZHVsZXMgb3V0 cHV0X3BvbGxfd29yaywgd2hpY2ggaW5pdGlhdGVzIGFuIEVESUQgcmVhZCBoZXJlLgoKSWYgdGhl IEVESUQgcmVhZCBoYXBwZW5zIGJlZm9yZSB0aGUgd29ya2VyIHRocmVhZCBoYXMgZW5hYmxlZCB0 aGUgY2xvY2tzLCBpdAp3aWxsIGJ5cGFzcyB0aGUgcG9ydCBzd2l0Y2ggbG9naWMgKHNpbmNlIHBy ZXZfcG9ydCBpcyBOVUxMKSBhbmQgZGlyZWN0bHkKYWNjZXNzIHRoZSBBUEIgcmVnaXN0ZXJzIChs aWtlIE1BSUxCT1hfRU1QVFlfQUREUikgaW5zaWRlCmNkbl9kcF9nZXRfZWRpZF9ibG9jaygpLiBB Y2Nlc3NpbmcgdGhlc2UgcmVnaXN0ZXJzIHdoaWxlIHBjbGsgYW5kIGNvcmVfY2xrCmFyZSBkaXNh YmxlZCBjYXVzZXMgYSBrZXJuZWwgcGFuaWMuCgo+ICsJLyogcmVwbGFjZSBlZGlkIGNhY2hlICov Cj4gKwlpZiAoZHAtPmVkaWRfY2FjaGVbZHBfYnJpZGdlLT5pZF0pCj4gKwkJZHJtX2VkaWRfZnJl ZShkcC0+ZWRpZF9jYWNoZVtkcF9icmlkZ2UtPmlkXSk7Cj4gKwlkcC0+ZWRpZF9jYWNoZVtkcF9i cmlkZ2UtPmlkXSA9IGRybV9lZGlkX2R1cChkcm1fZWRpZCk7Cj4gKwo+ICAJbXV0ZXhfdW5sb2Nr KCZkcC0+bG9jayk7Cj4gKwlyZXR1cm4gZHJtX2VkaWQ7CgpbIC4uLiBdCgo+IEBAIC01NzIsNiAr NjY0LDcgQEAgc3RhdGljIHZvaWQgY2RuX2RwX2Rpc3BsYXlfaW5mb191cGRhdGUoc3RydWN0IGNk bl9kcF9kZXZpY2UgKmRwLAo+ICBzdGF0aWMgdm9pZCBjZG5fZHBfYnJpZGdlX2F0b21pY19lbmFi bGUoc3RydWN0IGRybV9icmlkZ2UgKmJyaWRnZSwgc3RydWN0IGRybV9hdG9taWNfY29tbWl0ICpz dGF0ZSkKPiAgewo+ICAJc3RydWN0IGNkbl9kcF9kZXZpY2UgKmRwID0gYnJpZGdlX3RvX2RwKGJy aWRnZSk7Cj4gKwlzdHJ1Y3QgY2RuX2RwX2JyaWRnZSAqZHBfYnJpZGdlID0gYnJpZGdlX3RvX2Rw X2JyaWRnZShicmlkZ2UpOwo+ICAJc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvcjsKPiAg CWludCByZXQsIHZhbDsKPiAgCj4gQEAgLTYwMCw2ICs2OTMsOSBAQCBzdGF0aWMgdm9pZCBjZG5f ZHBfYnJpZGdlX2F0b21pY19lbmFibGUoc3RydWN0IGRybV9icmlkZ2UgKmJyaWRnZSwgc3RydWN0 IGRybV9hdAo+ICAKPiAgCW11dGV4X2xvY2soJmRwLT5sb2NrKTsKPiAgCj4gKwlpZiAoZHAtPm5l eHRfYnJpZGdlX3ZhbGlkKQo+ICsJCWRwLT5hY3RpdmVfcG9ydCA9IGRwX2JyaWRnZS0+aWQ7Cj4g Kwo+ICAJcmV0ID0gY2RuX2RwX2VuYWJsZShkcCk7Cj4gIAlpZiAocmV0KSB7Cj4gIAkJRFJNX0RF Vl9FUlJPUihkcC0+ZGV2LCAiRmFpbGVkIHRvIGVuYWJsZSBicmlkZ2UgJWRcbiIsCj4gQEAgLTYz Miw2ICs3MjgsNyBAQCBzdGF0aWMgdm9pZCBjZG5fZHBfYnJpZGdlX2F0b21pY19lbmFibGUoc3Ry dWN0IGRybV9icmlkZ2UgKmJyaWRnZSwgc3RydWN0IGRybV9hdAo+ICAJCWdvdG8gb3V0Owo+ICAJ fQo+ICAKPiArCWRwX2JyaWRnZS0+ZW5hYmxlZCA9IHRydWU7CgpbU2V2ZXJpdHk6IEhpZ2hdCldo YXQgcHJldmVudHMgdXNlcnNwYWNlIGZyb20gZW5hYmxpbmcgbXVsdGlwbGUgQ1JUQ3Mgc2ltdWx0 YW5lb3VzbHkgb24gdGhpcwpzaW5nbGUgRFAgaGFyZHdhcmUgYmxvY2s/CgpUaGUgZHJpdmVyIHJl Z2lzdGVycyBtdWx0aXBsZSBpbmRlcGVuZGVudCBEUk0gYnJpZGdlcyBhbmQgZW5jb2RlcnMgdGhh dCBzaGFyZQphIHNpbmdsZSBEUCBjb250cm9sbGVyLiBXaXRob3V0IGEgY3VzdG9tIGF0b21pY19j aGVjayB0byBlbmZvcmNlIG11dHVhbApleGNsdXNpb24sIHRoZSBEUk0gY29yZSBhbGxvd3MgdXNl cnNwYWNlIHRvIGFzc2lnbiBhbmQgZW5hYmxlIG11bHRpcGxlIENSVENzCnRvIHRoZXNlIGVuY29k ZXJzLgoKSWYgbXVsdGlwbGUgYnJpZGdlcyBhcmUgZW5hYmxlZCBjb25jdXJyZW50bHksIGNkbl9k cF9icmlkZ2VfYXRvbWljX2VuYWJsZSgpCmlzIGNhbGxlZCBmb3IgYm90aC4gVGhlIHNlY29uZCBj YWxsIHdpbGwgc2VlIGRwLT5hY3RpdmUgPT0gdHJ1ZSwgc2tpcCB0aGUKUEhZIGVuYWJsZW1lbnQs IGFuZCB0aGVuIHByb2NlZWQgdG8gY2FsbCBjZG5fZHBfdHJhaW5fbGluaygpIGFuZApjZG5fZHBf Y29uZmlnX3ZpZGVvKCkgaGVyZSwgd2hpY2ggb3ZlcnJpZGVzIHRoZSBzaGFyZWQgaGFyZHdhcmUg cmVnaXN0ZXJzCmFuZCBjb3JydXB0cyB0aGUgYWN0aXZlIGRpc3BsYXkuCgo+ICBvdXQ6Cj4gIAlt dXRleF91bmxvY2soJmRwLT5sb2NrKTsKPiAgfQoKWyAuLi4gXQoKPiBAQCAtODI4LDYgKzkyNywx NyBAQCBzdGF0aWMgaW50IGNkbl9kcF9hdWRpb19tdXRlX3N0cmVhbShzdHJ1Y3QgZHJtX2JyaWRn ZSAqYnJpZGdlLAo+ICAJcmV0dXJuIHJldDsKPiAgfQo+ICAKPiArc3RhdGljIHZvaWQgY2RuX2Rw X2JyaWRnZV9ocGRfbm90aWZ5KHN0cnVjdCBkcm1fYnJpZGdlICpicmlkZ2UsCj4gKwkJCQkgICAg IHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsCj4gKwkJCQkgICAgIGVudW0gZHJtX2Nv bm5lY3Rvcl9zdGF0dXMgc3RhdHVzKQo+ICt7Cj4gKwlzdHJ1Y3QgY2RuX2RwX2JyaWRnZSAqZHBf YnJpZGdlID0gYnJpZGdlX3RvX2RwX2JyaWRnZShicmlkZ2UpOwo+ICsJc3RydWN0IGNkbl9kcF9k ZXZpY2UgKmRwID0gYnJpZGdlX3RvX2RwKGJyaWRnZSk7Cj4gKwo+ICsJZHAtPmJyaWRnZV9saXN0 W2RwX2JyaWRnZS0+aWRdLT5jb25uZWN0ZWQgPSBzdGF0dXMgPT0gY29ubmVjdG9yX3N0YXR1c19j b25uZWN0ZWQ7Cj4gKwlzY2hlZHVsZV93b3JrKCZkcC0+ZXZlbnRfd29yayk7Cj4gK30KCltTZXZl cml0eTogTWVkaXVtXQpJcyBpdCBzYWZlIHRvIG1vZGlmeSB0aGlzIGNvbm5lY3RlZCBzdGF0ZSB3 aXRob3V0IGFjcXVpcmluZyBkcC0+bG9jaz8KClRoZSBib29sZWFuIHN0YXRlIGRwLT5icmlkZ2Vf bGlzdFtkcF9icmlkZ2UtPmlkXS0+Y29ubmVjdGVkIGlzIHdyaXR0ZW4gaGVyZQpkaXJlY3RseSwg YnV0IGNkbl9kcF9wZF9ldmVudF93b3JrKCkgcmVhZHMgdGhpcyBleGFjdCBmbGFnIGltbWVkaWF0 ZWx5IGFmdGVyCmV4cGxpY2l0bHkgZHJvcHBpbmcgZHAtPmxvY2suIFRoaXMgZGF0YSByYWNlIGNv dWxkIGNhdXNlIHRoZSB3b3JrZXIgdG8KcHJvY2VzcyBzdGFsZSBzdGF0ZSBpZiBhIGNvbmN1cnJl bnQgSFBEIG5vdGlmaWNhdGlvbiBvY2N1cnMuCgo+ICsKPiAgc3RhdGljIGNvbnN0IHN0cnVjdCBk cm1fYnJpZGdlX2Z1bmNzIGNkbl9kcF9icmlkZ2VfZnVuY3MgPSB7Cj4gIAkuYXRvbWljX2R1cGxp Y2F0ZV9zdGF0ZSA9IGRybV9hdG9taWNfaGVscGVyX2JyaWRnZV9kdXBsaWNhdGVfc3RhdGUsCj4g IAkuYXRvbWljX2Rlc3Ryb3lfc3RhdGUgPSBkcm1fYXRvbWljX2hlbHBlcl9icmlkZ2VfZGVzdHJv eV9zdGF0ZSwKClsgLi4uIF0KCj4gQEAgLTk0NSw5ICsxMDU3LDEyIEBAIHN0YXRpYyB2b2lkIGNk bl9kcF9wZF9ldmVudF93b3JrKHN0cnVjdCB3b3JrX3N0cnVjdCAqd29yaykKPiAgCj4gIG91dDoK PiAgCW11dGV4X3VubG9jaygmZHAtPmxvY2spOwo+IC0JZHJtX2JyaWRnZV9ocGRfbm90aWZ5KCZk cC0+YnJpZGdlLAo+IC0JCQkgICAgICBkcC0+Y29ubmVjdGVkID8gY29ubmVjdG9yX3N0YXR1c19j b25uZWN0ZWQKPiAtCQkJCQkgICAgOiBjb25uZWN0b3Jfc3RhdHVzX2Rpc2Nvbm5lY3RlZCk7Cj4g Kwlmb3IgKGkgPSAwOyBpIDwgZHAtPmJyaWRnZV9jb3VudDsgaSsrKSB7Cj4gKwkJY29ubmVjdGVk ID0gZHAtPmNvbm5lY3RlZCAmJiBkcC0+YnJpZGdlX2xpc3RbaV0tPmNvbm5lY3RlZDsKPiArCQlk cm1fYnJpZGdlX2hwZF9ub3RpZnkoJmRwLT5icmlkZ2VfbGlzdFtpXS0+YnJpZGdlLAo+ICsJCQkJ ICAgICAgY29ubmVjdGVkID8gY29ubmVjdG9yX3N0YXR1c19jb25uZWN0ZWQKPiArCQkJCQkJOiBj b25uZWN0b3Jfc3RhdHVzX2Rpc2Nvbm5lY3RlZCk7Cj4gKwl9Cj4gIH0KCltTZXZlcml0eTogSGln aF0KV2lsbCB0aGlzIEhQRCBub3RpZmljYXRpb24gYWN0dWFsbHkgcmVhY2ggdXNlcnNwYWNlPwoK VGhlIERSTSBicmlkZ2UgY29ubmVjdG9yIChkcm1fYnJpZGdlX2Nvbm5lY3Rvcl9pbml0KSBvbmx5 IHJlZ2lzdGVycyB0aGUKaHBkX2NiIG9uIHRoZSBsYXN0IGJyaWRnZSBpbiB0aGUgY2hhaW4gdGhh dCBzdXBwb3J0cyBEUk1fQlJJREdFX09QX0hQRC4KQmVjYXVzZSB0aGUgZG93bnN0cmVhbSBBVVgg SFBEIGJyaWRnZSBzdXBwb3J0cyBIUEQgYW5kIGlzIGFkZGVkIHRvIHRoZSBjaGFpbiwKaXQgYmVj b21lcyB0aGUgZGVzaWduYXRlZCBIUEQgYnJpZGdlIGFuZCB0YWtlcyB0aGUgaHBkX2NiLgoKQXMg YSByZXN1bHQsIHRoaXMgYnJpZGdlJ3MgaHBkX2NiIGlzIG5ldmVyIHNldCwgbWFraW5nIHRoaXMg Y2FsbCB0bwpkcm1fYnJpZGdlX2hwZF9ub3RpZnkoKSBhIHNpbGVudCBuby1vcC4gSWYgbGluayB0 cmFpbmluZyBmYWlscywgdXNlcnNwYWNlCmlzIG5ldmVyIG5vdGlmaWVkIHRoYXQgdGhlIGNvbm5l Y3Rpb24gaGFzIGRyb3BwZWQsIHBlcm1hbmVudGx5IGJyZWFraW5nIHRoZQpkaXNwbGF5IHN0YXRl IG1hY2hpbmUuCgpbIC4uLiBdCgotLSAKU2FzaGlrbyBBSSByZXZpZXcgwrcgaHR0cHM6Ly9zYXNo aWtvLmRldi8jL3BhdGNoc2V0LzIwMjYwODI4MDg0NzM3LjU2NS0xLWtlcm5lbEBhaXJreWkuY29t P3BhcnQ9NwoKLS0gCmxpbnV4LXBoeSBtYWlsaW5nIGxpc3QKbGludXgtcGh5QGxpc3RzLmluZnJh ZGVhZC5vcmcKaHR0cHM6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGlu dXgtcGh5Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A37DBC61DB9 for ; Fri, 28 Aug 2026 09:14:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D3F4110F309; Fri, 28 Aug 2026 09:14:28 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="lHOoEgZN"; dkim-atps=neutral Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 03A7610F309 for ; Fri, 28 Aug 2026 09:14:28 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 9DF664190A; Fri, 28 Aug 2026 09:14:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C9381F00A3A; Fri, 28 Aug 2026 09:14:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787908467; bh=6jtVWyW3lAo3HEsJHl0q4U7URdaSfejciHwbR2r8Pe8=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=lHOoEgZNIsaRzo638nNSYRvc/MjYVZ/BtVHfkv5lM48GdDJ2Wpc8VsN46Ym4bRxr+ sf4Zjdd9xNnDi17IVITTttkA4abBTq6ImttOrYtbm58easlqLM2KUtz5Um3mEtkgnq HzfCAg5Fl+78HFAUTid8HOBay4AbM0lz277Sq7PfmWOzitVv3NB8U/kKdGRdXpFaoy FA8Mu+Wqji3xDv7rS3EmaKmXzkCrtQYckqRXk3ZwQi0gKBp5O8FtsKTRMLvErPveoQ 34SjYm+qHxuvUmRM9VJ2UEvIP67fuykbX0VudKlxeupQE3PZm1QVTsI7nX96IykrxA 6UuIP+OTKodnA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v7 7/7] drm/rockchip: cdn-dp: Add multiple bridges to support PHY port selection To: "Chaoyi Chen" Cc: linux-phy@lists.infradead.org, olteanv@gmail.com, dri-devel@lists.freedesktop.org, vkoul@kernel.org, neil.armstrong@linaro.org In-Reply-To: <20260828084737.565-8-kernel@airkyi.com> References: <20260828084737.565-1-kernel@airkyi.com> <20260828084737.565-8-kernel@airkyi.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 28 Aug 2026 09:14:26 +0000 Message-Id: <20260828091427.4C9381F00A3A@smtp.kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Thank you for your contribution! Sashiko AI review found 5 potential issue(= s) to consider: - [High] Missing atomic_check to prevent concurrent enablement of mutually = exclusive DP bridges. - [High] Hardware registers are accessed while DP clocks are disabled, lead= ing to a synchronous external abort and kernel panic. - [High] The driver fails to propagate internal hotplug state changes to us= erspace because its bridge no longer receives the HPD callback. - [High] Video pipeline configuration is inappropriately executed during ED= ID read, leading to inevitable failure on secondary ports. - [Medium] The connected status of bridges is updated and read concurrently= without holding the necessary synchronization locks. -- commit a45588df990bb11f402ba98f56052bec1405db96 Author: Chaoyi Chen drm/rockchip: cdn-dp: Add multiple bridges to support PHY port selection This commit adds support for multiple bridges to the Rockchip CDN-DP driver, allowing dynamic output port selection. It registers separate encoders and bridges for each PHY port and parses the device tree to describe connection= s. Port switching is handled dynamically during EDID reads or when enabling the DP block. > diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/roc= kchip/cdn-dp-core.c > index 74e1f5422a6e2..999309b39b34c 100644 > --- a/drivers/gpu/drm/rockchip/cdn-dp-core.c > +++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c [ ... ] > @@ -254,12 +268,45 @@ static const struct drm_edid * > cdn_dp_bridge_edid_read(struct drm_bridge *bridge, struct drm_connector = *connector) > { > struct cdn_dp_device *dp =3D bridge_to_dp(bridge); > - const struct drm_edid *drm_edid; > + struct cdn_dp_bridge *dp_bridge =3D bridge_to_dp_bridge(bridge); > + struct cdn_dp_port *port =3D dp->port[dp_bridge->id]; > + struct cdn_dp_port *prev_port =3D NULL; > + const struct drm_edid *drm_edid =3D NULL; > + int i, ret; > =20 > mutex_lock(&dp->lock); > + > + /* More than one port is available */ > + if (dp->bridge_count > 1 && !port->phy_enabled) { > + for (i =3D 0; i < dp->bridge_count; i++) { > + /* Another port already enable */ > + if (dp->bridge_list[i] !=3D dp_bridge && dp->bridge_list[i]->enabled) > + goto get_cache; > + /* Find already enabled port */ > + if (dp->port[i]->phy_enabled) > + prev_port =3D dp->port[i]; > + } > + > + /* Switch to current port */ > + if (prev_port) { > + ret =3D cdn_dp_switch_port(dp, prev_port, port); [Severity: High] Will this video pipeline configuration fail during an EDID read? When reading the EDID on a secondary port, this switches the port and ultimately calls cdn_dp_config_video() via cdn_dp_switch_port(). Since this happens during connector probing, no atomic mode has been committed yet, meaning dp->mode.clock is either 0 or holds a stale value. This will cause the timing calculation in cdn_dp_config_video() to return -EINVAL. The switch then fails, and this function falls back to returning t= he cache (which is NULL on the first plug), breaking secondary port detection. > + if (ret) > + goto get_cache; > + } > + } > + > drm_edid =3D drm_edid_read_custom(connector, cdn_dp_get_edid_block, dp); [Severity: High] Is there a risk of a synchronous external abort when accessing the DP hardw= are registers here? Hotplug events from downstream bridges trigger cdn_dp_bridge_hpd_notify(), which schedules dp->event_work to enable the DP clocks and hardware via cdn_dp_enable(). At the same time, the DRM core processes the hotplug event and schedules output_poll_work, which initiates an EDID read here. If the EDID read happens before the worker thread has enabled the clocks, it will bypass the port switch logic (since prev_port is NULL) and directly access the APB registers (like MAILBOX_EMPTY_ADDR) inside cdn_dp_get_edid_block(). Accessing these registers while pclk and core_clk are disabled causes a kernel panic. > + /* replace edid cache */ > + if (dp->edid_cache[dp_bridge->id]) > + drm_edid_free(dp->edid_cache[dp_bridge->id]); > + dp->edid_cache[dp_bridge->id] =3D drm_edid_dup(drm_edid); > + > mutex_unlock(&dp->lock); > + return drm_edid; [ ... ] > @@ -572,6 +664,7 @@ static void cdn_dp_display_info_update(struct cdn_dp_= device *dp, > static void cdn_dp_bridge_atomic_enable(struct drm_bridge *bridge, struc= t drm_atomic_commit *state) > { > struct cdn_dp_device *dp =3D bridge_to_dp(bridge); > + struct cdn_dp_bridge *dp_bridge =3D bridge_to_dp_bridge(bridge); > struct drm_connector *connector; > int ret, val; > =20 > @@ -600,6 +693,9 @@ static void cdn_dp_bridge_atomic_enable(struct drm_br= idge *bridge, struct drm_at > =20 > mutex_lock(&dp->lock); > =20 > + if (dp->next_bridge_valid) > + dp->active_port =3D dp_bridge->id; > + > ret =3D cdn_dp_enable(dp); > if (ret) { > DRM_DEV_ERROR(dp->dev, "Failed to enable bridge %d\n", > @@ -632,6 +728,7 @@ static void cdn_dp_bridge_atomic_enable(struct drm_br= idge *bridge, struct drm_at > goto out; > } > =20 > + dp_bridge->enabled =3D true; [Severity: High] What prevents userspace from enabling multiple CRTCs simultaneously on this single DP hardware block? The driver registers multiple independent DRM bridges and encoders that sha= re a single DP controller. Without a custom atomic_check to enforce mutual exclusion, the DRM core allows userspace to assign and enable multiple CRTCs to these encoders. If multiple bridges are enabled concurrently, cdn_dp_bridge_atomic_enable() is called for both. The second call will see dp->active =3D=3D true, skip t= he PHY enablement, and then proceed to call cdn_dp_train_link() and cdn_dp_config_video() here, which overrides the shared hardware registers and corrupts the active display. > out: > mutex_unlock(&dp->lock); > } [ ... ] > @@ -828,6 +927,17 @@ static int cdn_dp_audio_mute_stream(struct drm_bridg= e *bridge, > return ret; > } > =20 > +static void cdn_dp_bridge_hpd_notify(struct drm_bridge *bridge, > + struct drm_connector *connector, > + enum drm_connector_status status) > +{ > + struct cdn_dp_bridge *dp_bridge =3D bridge_to_dp_bridge(bridge); > + struct cdn_dp_device *dp =3D bridge_to_dp(bridge); > + > + dp->bridge_list[dp_bridge->id]->connected =3D status =3D=3D connector_s= tatus_connected; > + schedule_work(&dp->event_work); > +} [Severity: Medium] Is it safe to modify this connected state without acquiring dp->lock? The boolean state dp->bridge_list[dp_bridge->id]->connected is written here directly, but cdn_dp_pd_event_work() reads this exact flag immediately after explicitly dropping dp->lock. This data race could cause the worker to process stale state if a concurrent HPD notification occurs. > + > static const struct drm_bridge_funcs cdn_dp_bridge_funcs =3D { > .atomic_duplicate_state =3D drm_atomic_helper_bridge_duplicate_state, > .atomic_destroy_state =3D drm_atomic_helper_bridge_destroy_state, [ ... ] > @@ -945,9 +1057,12 @@ static void cdn_dp_pd_event_work(struct work_struct= *work) > =20 > out: > mutex_unlock(&dp->lock); > - drm_bridge_hpd_notify(&dp->bridge, > - dp->connected ? connector_status_connected > - : connector_status_disconnected); > + for (i =3D 0; i < dp->bridge_count; i++) { > + connected =3D dp->connected && dp->bridge_list[i]->connected; > + drm_bridge_hpd_notify(&dp->bridge_list[i]->bridge, > + connected ? connector_status_connected > + : connector_status_disconnected); > + } > } [Severity: High] Will this HPD notification actually reach userspace? The DRM bridge connector (drm_bridge_connector_init) only registers the hpd_cb on the last bridge in the chain that supports DRM_BRIDGE_OP_HPD. Because the downstream AUX HPD bridge supports HPD and is added to the chai= n, it becomes the designated HPD bridge and takes the hpd_cb. As a result, this bridge's hpd_cb is never set, making this call to drm_bridge_hpd_notify() a silent no-op. If link training fails, userspace is never notified that the connection has dropped, permanently breaking the display state machine. [ ... ] --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260828084737.565-= 1-kernel@airkyi.com?part=3D7