All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rasmus Villemoes <ravi@prevas.dk>
To: u-boot@lists.u-boot-project.org
Cc: Igor Opaniuk <igor.opaniuk@gmail.com>,
	Mattijs Korpershoek <mkorpershoek@kernel.org>,
	Tom Rini <trini@konsulko.com>,
	Ilias Apalodimas <ilias.apalodimas@linaro.org>,
	Jens Wiklander <jens.wiklander@linaro.org>,
	Rasmus Villemoes <ravi@prevas.dk>
Subject: [PATCH 0/3] avb: start handling too small buffer for reading persistent values
Date: Fri, 28 Aug 2026 12:50:02 +0200	[thread overview]
Message-ID: <20260828105005.200338-1-ravi@prevas.dk> (raw)

The avb_ops.h header clearly indicates that it should be possible for
the callers of the read_persistent_value interface to know that they
provided too small a buffer, and the interface should also tell the
callers how big a buffer would need to be.

However, that was never really implemented, neither here nor on the
op-tee side. So if a too small buffer is passed, the caller simply
gets a silently truncated result.

I've proposed a fix on the op-tee side:
https://github.com/OP-TEE/optee_os/pull/7959 . Since that is an ABI
change (returning an error where it previously "succeeded", for some
definition of succeed), the maintainer would like to see client side
updates as well before that can be merged. So here are some of the
changes that would be needed in U-Boot.

I have not yet looked at any of the callers of the
->read_persistent_value method via the avb_ops structure, only the
implementation of that method itself.

Rasmus Villemoes (3):
  cmd: optee_rpmb: sanitize TEE_ERROR -> E* translations
  cmd: optee_rpmb: try to allocate large enough buffer when reading
    persistent value
  avb_verify: read_persistent_value: honour contract regarding too small
    buffer

 cmd/optee_rpmb.c    | 45 ++++++++++++++++++++++++++++++---------------
 common/avb_verify.c |  5 ++++-
 2 files changed, 34 insertions(+), 16 deletions(-)

-- 
2.55.0


             reply	other threads:[~2026-08-28 10:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-28 10:50 Rasmus Villemoes [this message]
2026-08-28 10:50 ` [PATCH 1/3] cmd: optee_rpmb: sanitize TEE_ERROR -> E* translations Rasmus Villemoes
2026-09-02 12:45   ` Mattijs Korpershoek
2026-09-02 12:51     ` Rasmus Villemoes
2026-08-28 10:50 ` [PATCH 2/3] cmd: optee_rpmb: try to allocate large enough buffer when reading persistent value Rasmus Villemoes
2026-09-02 12:55   ` Mattijs Korpershoek
2026-08-28 10:50 ` [PATCH 3/3] avb_verify: read_persistent_value: honour contract regarding too small buffer Rasmus Villemoes
2026-09-02 13:03   ` Mattijs Korpershoek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260828105005.200338-1-ravi@prevas.dk \
    --to=ravi@prevas.dk \
    --cc=igor.opaniuk@gmail.com \
    --cc=ilias.apalodimas@linaro.org \
    --cc=jens.wiklander@linaro.org \
    --cc=mkorpershoek@kernel.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.u-boot-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.