Re: [PATCH v2 1/3] arm64: tegra: Add PWM fan on Jetson AGX Thor DevKit

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] Incomplete `pwm@c6a0000` node and unit address collision
- [Low] Missing phandle `&pwm4` causes a fatal DTC build error
--

commit 896b2e4dbdcbabef8cf82b66c7dcabdbec8e9800
Author: Thierry Reding <treding@nvidia.com>

arm64: tegra: Add PWM fan on Jetson AGX Thor DevKit

Add a PWM fan device node to actively control the PWM, preventing it from
stopping or running at full speed during boot when the controller's clock
is turned off.

> diff --git a/arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi b/arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi
> index 45f8df9bbfd62..4550e843f513c 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi
> @@ -9,4 +9,17 @@ aliases {
>  	chosen {
>  		stdout-path = "serial0:115200n8";
>  	};
> +
> +	bus@0 {
> +		pwm@c6a0000 {
> +			status = "okay";
> +		};

[Severity: Medium]
Will this node fail to bind the PWM driver? Because the base tegra264.dtsi
does not define this node, it lacks essential properties like compatible,
reg, and #pwm-cells.

Also, does this cause a unit-address collision warning? The base tree already
defines i2c9: i2c@c6a0000 at the exact same address:

arch/arm64/boot/dts/nvidia/tegra264.dtsi:bus@0 {
	...
	i2c9: i2c@c6a0000 {
		compatible = "nvidia,tegra264-i2c";
	...
}

> +	};
> +
> +	fan: pwm-fan {
> +		compatible = "pwm-fan";
> +		cooling-levels = <77 102 140 192 255>;
> +		pwms = <&pwm4 0 40000>;

[Severity: Low]
Does this cause a fatal DTC build error? The label &pwm4 is unresolved
because it is referenced but never defined in tegra264.dtsi or any included
file, resulting in a 'label or path not found' syntax error.

> +		#cooling-cells = <2>;
> +	};
>  };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260828-tegra264-fan-v2-0-a460389d8ef5@nvidia.com?part=1