From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D3FD2C031E; Fri, 28 Aug 2026 13:54:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787925246; cv=none; b=BldqBX9Sog8bHyD1Xxd/UpAYdVPyl51+GZ1VdsjnhZNUIFu9EWg09vwKhPAlqAz0eZ9u+iU4rR4smMA893E9itYGjrHPinuUtWtASIg8pojskzeYiJB2c0iJI5rJHMAstA+TrtC+M2NhbSy3H2RIRtZz4obCeFJfjx8xWlWUSBc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787925246; c=relaxed/simple; bh=mLpZyvcHJbhF+acLQ5W8TeqwwoCClYINwLWY5zXEipU=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=GoPYTS1RjPbGMMulYWQj+pSQYCR7fEgvxWlJV2q+PJIsNW8RCGZ5gwegdVDgr0mJml3I1I8qfTbDf37MZnPKCCDuE2ImNQ88odln6w1+d/Kz0lD6NxIiqBfw2aYDwsEUcSTSj067VTbkd6/Pt7zBGBGio81R6D6HiTV/Zxp7HBY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QF4fewV3; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QF4fewV3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F12C1F000E9; Fri, 28 Aug 2026 13:54:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787925244; bh=2c8diSklvVUd6K6I6bSdgpwdYZU6SUVzQlMEjE+KPWA=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=QF4fewV3m9gBHaINgD97JHB3uR/xyDcmpuJKAR5IGoBnglde8KYq9Wu5FNZ/ZDL9o axes+Ku5Awi2vrgnlRXUp9jifxGsrIsFzgCIrgJzCMALs5LDxiPV2RjLC/rBoVtYWZ ZXZ9xdX5I/dKFwfulnZLw+YglsXjur8c4ekU48lZhxVEY/HQU2FTweL+Itv+LNvb4i CCQh9KxJegNhbxxfqAMrdZebY7bo3bl+oXtOo+PoCcIItd+ovh2rVrZsjiA8QEOEKJ c7I3MP6ZJy676XVwqHpqbj8+S0osR6f1YlmYFZwo4lWD2IV5cEUZjId1nBYKYVl55f rqeqZQWM6seBg== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 03/15] dt-bindings: mfd: Add starfive,jh7110-hdmi-subsystem Reply-To: sashiko-reviews@lists.linux.dev To: "Michal Wilczynski" Cc: dri-devel@lists.freedesktop.org, olteanv@gmail.com, robh@kernel.org, conor+dt@kernel.org, linux-phy@lists.infradead.org, vkoul@kernel.org, neil.armstrong@linaro.org, devicetree@vger.kernel.org, mfd@lists.linux.dev, lee@kernel.org, linux-clk@vger.kernel.org In-Reply-To: <20260828-jh7110-clean-send-v2-3-331680c8b9d1@samsung.com> References: <20260828-jh7110-clean-send-v2-0-331680c8b9d1@samsung.com> <20260828-jh7110-clean-send-v2-3-331680c8b9d1@samsung.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 28 Aug 2026 13:54:03 +0000 Message-Id: <20260828135404.2F12C1F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] The compatible string 'starfive,jh7110-hdmi-subsystem' embeds softw= are architecture details into the hardware description. -- commit f244c8f1868df1c7d5507202956114ed3dbd675e Author: Michal Wilczynski dt-bindings: mfd: Add starfive,jh7110-hdmi-subsystem This commit adds a device tree binding for the StarFive JH7110 HDMI subsyst= em. The binding describes a parent device acting as an MFD to hold shared registers for PHY and controller children, addressing a circular clock dependency. > diff --git a/Documentation/devicetree/bindings/mfd/starfive,jh7110-hdmi-s= ubsystem.yaml b/Documentation/devicetree/bindings/mfd/starfive,jh7110-hdmi-= subsystem.yaml > new file mode 100644 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/starfive,jh7110-hdmi-subsyste= m.yaml [ ... ] > +description: > + The StarFive JH7110 HDMI block is a monolithic IP containing both > + the digital controller logic and the analog PHY logic in a single > + register space. > + > +properties: > + compatible: > + const: starfive,jh7110-hdmi-subsystem [Severity: Low] Is the use of "subsystem" in this compatible string intentional? Device tree bindings typically describe the physical hardware block rather than the software architecture. Since the commit message and description indicate the HDMI IP is a monolithic physical block, encoding a Linux-speci= fic driver concept like a subsystem or an MFD parent into the compatible string appears to embed software details into the hardware description. Could this compatible string be updated to reflect the actual hardware bloc= k's designation without the "subsystem" suffix? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260828-jh7110-cle= an-send-v2-0-331680c8b9d1@samsung.com?part=3D3 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9D7EBC61DCB for ; Fri, 28 Aug 2026 13:54:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5zPx91r/JER0ALsoreduHc2gPYtskwj7Q+ba5/tZoiU=; b=193n8sdFBWaZ8x 8jAbmqQ46V6jL4tG3CagigpEGxKbHlJK11jPqy9dzcfxE3cpDRltzw31Oz7t05xrhNpAr6jhAVEgk 3/VyFH7XiFRtZuRX4eAr5hca6Mz7HeNk43ldGeF9L6II225vCFKXMr0fV8zZ8dS+BJqX1rUuBz68v O1Yj3ASwXtK4bq8g89UtOCgm9vcTkgjA0Txbi7QN/OIjTItTCTDQEd3zbPyDsRPWpKR3kn3enUZnI c1pwjujSTbmJw9iOGT3V95ZrzTz0RbfSupzrEoFRMwaQOL3v/tVonK3wo1JU2wKuoHdSpk080wmip 4Oj1qDEN6v3tocdG83xA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wzx1z-00000005v9Y-1NeE; Fri, 28 Aug 2026 13:54:07 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wzx1x-00000005v8o-1SxQ for linux-phy@lists.infradead.org; Fri, 28 Aug 2026 13:54:05 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id E9DCD417E9; Fri, 28 Aug 2026 13:54:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F12C1F000E9; Fri, 28 Aug 2026 13:54:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787925244; bh=2c8diSklvVUd6K6I6bSdgpwdYZU6SUVzQlMEjE+KPWA=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=QF4fewV3m9gBHaINgD97JHB3uR/xyDcmpuJKAR5IGoBnglde8KYq9Wu5FNZ/ZDL9o axes+Ku5Awi2vrgnlRXUp9jifxGsrIsFzgCIrgJzCMALs5LDxiPV2RjLC/rBoVtYWZ ZXZ9xdX5I/dKFwfulnZLw+YglsXjur8c4ekU48lZhxVEY/HQU2FTweL+Itv+LNvb4i CCQh9KxJegNhbxxfqAMrdZebY7bo3bl+oXtOo+PoCcIItd+ovh2rVrZsjiA8QEOEKJ c7I3MP6ZJy676XVwqHpqbj8+S0osR6f1YlmYFZwo4lWD2IV5cEUZjId1nBYKYVl55f rqeqZQWM6seBg== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 03/15] dt-bindings: mfd: Add starfive,jh7110-hdmi-subsystem To: "Michal Wilczynski" Cc: dri-devel@lists.freedesktop.org, olteanv@gmail.com, robh@kernel.org, conor+dt@kernel.org, linux-phy@lists.infradead.org, vkoul@kernel.org, neil.armstrong@linaro.org, devicetree@vger.kernel.org, mfd@lists.linux.dev, lee@kernel.org, linux-clk@vger.kernel.org In-Reply-To: <20260828-jh7110-clean-send-v2-3-331680c8b9d1@samsung.com> References: <20260828-jh7110-clean-send-v2-0-331680c8b9d1@samsung.com> <20260828-jh7110-clean-send-v2-3-331680c8b9d1@samsung.com> Date: Fri, 28 Aug 2026 13:54:03 +0000 Message-Id: <20260828135404.2F12C1F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0xvd10gVGhlIGNvbXBhdGlibGUg c3RyaW5nICdzdGFyZml2ZSxqaDcxMTAtaGRtaS1zdWJzeXN0ZW0nIGVtYmVkcyBzb2Z0d2FyZSBh cmNoaXRlY3R1cmUgZGV0YWlscyBpbnRvIHRoZSBoYXJkd2FyZSBkZXNjcmlwdGlvbi4KLS0KCmNv bW1pdCBmMjQ0YzhmMTg2OGRmMWM3ZDU1MDcyMDI5NTYxMTRlZDNkYmQ2NzVlCkF1dGhvcjogTWlj aGFsIFdpbGN6eW5za2kgPG0ud2lsY3p5bnNraUBzYW1zdW5nLmNvbT4KCmR0LWJpbmRpbmdzOiBt ZmQ6IEFkZCBzdGFyZml2ZSxqaDcxMTAtaGRtaS1zdWJzeXN0ZW0KClRoaXMgY29tbWl0IGFkZHMg YSBkZXZpY2UgdHJlZSBiaW5kaW5nIGZvciB0aGUgU3RhckZpdmUgSkg3MTEwIEhETUkgc3Vic3lz dGVtLgpUaGUgYmluZGluZyBkZXNjcmliZXMgYSBwYXJlbnQgZGV2aWNlIGFjdGluZyBhcyBhbiBN RkQgdG8gaG9sZCBzaGFyZWQKcmVnaXN0ZXJzIGZvciBQSFkgYW5kIGNvbnRyb2xsZXIgY2hpbGRy ZW4sIGFkZHJlc3NpbmcgYSBjaXJjdWxhciBjbG9jawpkZXBlbmRlbmN5LgoKPiBkaWZmIC0tZ2l0 IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL21mZC9zdGFyZml2ZSxqaDcxMTAt aGRtaS1zdWJzeXN0ZW0ueWFtbCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9t ZmQvc3RhcmZpdmUsamg3MTEwLWhkbWktc3Vic3lzdGVtLnlhbWwKPiBuZXcgZmlsZSBtb2RlIDEw MDY0NAo+IC0tLSAvZGV2L251bGwKPiArKysgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmlu ZGluZ3MvbWZkL3N0YXJmaXZlLGpoNzExMC1oZG1pLXN1YnN5c3RlbS55YW1sClsgLi4uIF0KPiAr ZGVzY3JpcHRpb246Cj4gKyAgVGhlIFN0YXJGaXZlIEpINzExMCBIRE1JIGJsb2NrIGlzIGEgbW9u b2xpdGhpYyBJUCBjb250YWluaW5nIGJvdGgKPiArICB0aGUgZGlnaXRhbCBjb250cm9sbGVyIGxv Z2ljIGFuZCB0aGUgYW5hbG9nIFBIWSBsb2dpYyBpbiBhIHNpbmdsZQo+ICsgIHJlZ2lzdGVyIHNw YWNlLgo+ICsKPiArcHJvcGVydGllczoKPiArICBjb21wYXRpYmxlOgo+ICsgICAgY29uc3Q6IHN0 YXJmaXZlLGpoNzExMC1oZG1pLXN1YnN5c3RlbQoKW1NldmVyaXR5OiBMb3ddCklzIHRoZSB1c2Ug b2YgInN1YnN5c3RlbSIgaW4gdGhpcyBjb21wYXRpYmxlIHN0cmluZyBpbnRlbnRpb25hbD8KCkRl dmljZSB0cmVlIGJpbmRpbmdzIHR5cGljYWxseSBkZXNjcmliZSB0aGUgcGh5c2ljYWwgaGFyZHdh cmUgYmxvY2sgcmF0aGVyCnRoYW4gdGhlIHNvZnR3YXJlIGFyY2hpdGVjdHVyZS4gU2luY2UgdGhl IGNvbW1pdCBtZXNzYWdlIGFuZCBkZXNjcmlwdGlvbgppbmRpY2F0ZSB0aGUgSERNSSBJUCBpcyBh IG1vbm9saXRoaWMgcGh5c2ljYWwgYmxvY2ssIGVuY29kaW5nIGEgTGludXgtc3BlY2lmaWMKZHJp dmVyIGNvbmNlcHQgbGlrZSBhIHN1YnN5c3RlbSBvciBhbiBNRkQgcGFyZW50IGludG8gdGhlIGNv bXBhdGlibGUgc3RyaW5nCmFwcGVhcnMgdG8gZW1iZWQgc29mdHdhcmUgZGV0YWlscyBpbnRvIHRo ZSBoYXJkd2FyZSBkZXNjcmlwdGlvbi4KCkNvdWxkIHRoaXMgY29tcGF0aWJsZSBzdHJpbmcgYmUg dXBkYXRlZCB0byByZWZsZWN0IHRoZSBhY3R1YWwgaGFyZHdhcmUgYmxvY2sncwpkZXNpZ25hdGlv biB3aXRob3V0IHRoZSAic3Vic3lzdGVtIiBzdWZmaXg/CgotLSAKU2FzaGlrbyBBSSByZXZpZXcg wrcgaHR0cHM6Ly9zYXNoaWtvLmRldi8jL3BhdGNoc2V0LzIwMjYwODI4LWpoNzExMC1jbGVhbi1z ZW5kLXYyLTAtMzMxNjgwYzhiOWQxQHNhbXN1bmcuY29tP3BhcnQ9MwoKLS0gCmxpbnV4LXBoeSBt YWlsaW5nIGxpc3QKbGludXgtcGh5QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cHM6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcGh5Cg==