From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E5B0DC61DCB for ; Fri, 28 Aug 2026 14:04:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WX09z7GYRfWSiE40dOjVXYvU3lCYwrU9Yr2pirjnU9w=; b=4goir++lPiLvAG gqpVC7oL05KDC5IyjwMLzS8T7vdbPrVG96UenfnLzqd9R6DNF1fB8XF3mhci0HBtwfA3ahuZYxD6K PeQDlQO7fFoI/9Dy/tvI5awOLpiLJS0S4+IJq79d86kscH34ArlRb3C86GFfZ0Wb1aDvsUj/KX84g PtSusl+FY3s01qB6nivX++Udce7woY5zW/a/jbux/InZB9zVskUcjWQ8qklmH0OZSPilKtE9GSHJ5 00xV3DjoH2SO//QScGG/kJCwfNhaLeXBCdS0f10ACICgWtKO2ghbaPgMaNoxiwMEHNBtXAcyyc7gF FBCv4wzoGOa8Oi61WzLg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wzxCP-00000005wDQ-2iVx; Fri, 28 Aug 2026 14:04:53 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wzxCN-00000005wD3-3p0j for linux-phy@lists.infradead.org; Fri, 28 Aug 2026 14:04:52 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 4B48C60200; Fri, 28 Aug 2026 14:04:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 66CAE1F00A3A; Fri, 28 Aug 2026 14:04:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787925891; bh=BEf7wsmWGyjenIb5dVc/Hd41acSlqCKQek2mD9YF+6s=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=fr2CRQfurqqiCNqIcuSDQwpRQGwS2JdQ+mp2F+gah+FXcTH19fHXsFzsqQP4j3i66 sNhQmiPOiqY9s7nQRbZyoLniHnm/6mXtwgn4cPKu6BZOerLV/25RPiztz84yrSloDJ b2ogDKPObTvlc9B/DO501n0eD/5MSOJeKGlnbfC9wmxD8P8Gxh/FhdOudZWCx5fTLJ hojEvulsRR7U1HUnulRjSTyBJ4rTBHhNGMemDnzJCSi5BmHTgU0KIwGu32CKQFHhkP DLGC3aBAgKRdlctj+5Cy0mwDheddQrLzUXECfu0oCy3EOQmm6TFcR7NNS8xB7Dh+5/ qqSFf5yRuE0XQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 13/15] phy: starfive: Add jh7110-inno-hdmi-phy driver To: "Michal Wilczynski" Cc: mfd@lists.linux.dev, linux-phy@lists.infradead.org, neil.armstrong@linaro.org, linux-clk@vger.kernel.org, conor+dt@kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, lee@kernel.org, olteanv@gmail.com, vkoul@kernel.org, robh@kernel.org In-Reply-To: <20260828-jh7110-clean-send-v2-13-331680c8b9d1@samsung.com> References: <20260828-jh7110-clean-send-v2-0-331680c8b9d1@samsung.com> <20260828-jh7110-clean-send-v2-13-331680c8b9d1@samsung.com> Date: Fri, 28 Aug 2026 14:04:49 +0000 Message-Id: <20260828140450.66CAE1F00A3A@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MyBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0hpZ2hdIE1pc3NpbmcgY2xlYW51 cCBvbiB0aGUgY2xrX3NldF9yYXRlIGVycm9yIHBhdGggaW4gcHJvYmUgbGVhdmVzIGEgZGFuZ2xp bmcgY2xvY2sgcHJvdmlkZXIuCi0gW0hpZ2hdIENsb2NrIG9wZXJhdGlvbnMgaW5jb3JyZWN0bHkg bW9kaWZ5IGFuYWxvZyBQSFkgc3RhdGUgd2l0aG91dCBzeW5jaHJvbml6YXRpb24sIHJpc2tpbmcg c3RhdGUgY29ycnVwdGlvbiBhbmQgcG93ZXIgbGVha3MuCi0gW01lZGl1bV0gSGFyZHdhcmUgUEhZ IHJlc291cmNlcyBhcmUgbGVmdCBwb3dlcmVkIG9uIGlmIHN0YXJmaXZlX2hkbWlfcGh5X3Bvd2Vy X29uKCkgZmFpbHMuCi0tCgpjb21taXQgN2M0NmY5ZTg2ZjA5MzkxYjhjNTQyZTk0MGRhMTQ1N2Uz NjY2MTg3NApBdXRob3I6IE1pY2hhbCBXaWxjenluc2tpIDxtLndpbGN6eW5za2lAc2Ftc3VuZy5j b20+CgpwaHk6IHN0YXJmaXZlOiBBZGQgamg3MTEwLWlubm8taGRtaS1waHkgZHJpdmVyCgpUaGlz IGNvbW1pdCBhZGRzIHRoZSBIRE1JIFBIWSBkcml2ZXIgZm9yIHRoZSBTdGFyRml2ZSBKSDcxMTAu IEl0IHByb3ZpZGVzCnRoZSB2YXJpYWJsZSBwaXhlbCBjbG9jayBmcm9tIHRoZSBQcmUtUExMIGFu ZCB0aGUgUEhZIG9wZXJhdGlvbnMgZm9yIHRoZQpQb3N0LVBMTCBhbmQgYW5hbG9nIGJsb2Nrcy4K Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGh5L3N0YXJmaXZlL3BoeS1qaDcxMTAtaW5uby1oZG1p LmMgYi9kcml2ZXJzL3BoeS9zdGFyZml2ZS9waHktamg3MTEwLWlubm8taGRtaS5jCj4gbmV3IGZp bGUgbW9kZSAxMDA2NDQKPiAtLS0gL2Rldi9udWxsCj4gKysrIGIvZHJpdmVycy9waHkvc3RhcmZp dmUvcGh5LWpoNzExMC1pbm5vLWhkbWkuYwpbIC4uLiBdCj4gK3N0YXRpYyBpbnQgc3RhcmZpdmVf aGRtaV9waHlfY2xrX3NldF9yYXRlKHN0cnVjdCBjbGtfaHcgKmh3LCB1bnNpZ25lZCBsb25nIHJh dGUsCj4gKwkJCQkJICB1bnNpZ25lZCBsb25nIHBhcmVudF9yYXRlKQo+ICt7ClsgLi4uIF0KPiAr CWlmIChpbm5vLT5waXhjbG9jayA9PSByYXRlICYmIGlubm8tPnRtZHNjbG9jayA9PSBjZmctPnRt ZHNjbG9jaykKPiArCQlyZXR1cm4gMDsKPiArCj4gKwlpbm5vX3VwZGF0ZV9iaXRzKGlubm8sIFNU Rl9JTk5PX0JJQVNfQ09OVFJPTCwKPiArCQkJIFNURl9JTk5PX0JJQVNfRU5BQkxFLCBTVEZfSU5O T19CSUFTX0VOQUJMRSk7Cj4gKwlpbm5vX3dyaXRlKGlubm8sIFNURl9JTk5PX1JYX0NPTlRST0ws IFNURl9JTk5PX1JYX0VOQUJMRSk7CgpbU2V2ZXJpdHk6IEhpZ2hdCkRvZXMgdGhpcyBpbmNvcnJl Y3RseSBtb2RpZnkgYW5hbG9nIFBIWSBzdGF0ZSBkdXJpbmcgY2xvY2sgb3BlcmF0aW9ucz8KClNp bmNlIGNsa19zZXRfcmF0ZSgpIGlzIHVuY29uZGl0aW9uYWxseSBjYWxsZWQgZHVyaW5nIHN0YXJm aXZlX2hkbWlfcGh5X3Byb2JlKCksCnRoZXNlIGFuYWxvZyBibG9ja3MgYXJlIHBvd2VyZWQgb24g aW1tZWRpYXRlbHkgYXQgYm9vdCwgd2hpY2ggY291bGQgY2F1c2UgYQpwZXJtYW5lbnQgcG93ZXIg bGVhayB1bnRpbCB0aGUgcG93ZXJfb2ZmIGNhbGxiYWNrIGhhcHBlbnMgdG8gYmUgY2FsbGVkLgoK RnVydGhlcm1vcmUsIGRvIHRoZXNlIHN0YXRlIG1vZGlmaWNhdGlvbnMgcmFjZSB3aXRoIHRoZSBQ SFkgY2FsbGJhY2tzPyBUaGUKY29tbW9uIGNsb2NrIGZyYW1ld29yayBjYWxsYmFja3MgZXhlY3V0 ZSB1bmRlciB0aGUgQ0NGIHByZXBhcmVfbG9jaywgd2hpbGUgUEhZCmNhbGxiYWNrcyBleGVjdXRl IHVuZGVyIHRoZSBwaHktPm11dGV4IGxvY2suIEEgY29uY3VycmVudCBjbGtfc2V0X3JhdGUoKSBh bmQKc3RhcmZpdmVfaGRtaV9waHlfcG93ZXJfb24oKSBjb3VsZCByYWNlIG9uIGhhcmR3YXJlIHJl Z2lzdGVycyBhbmQgc2hhcmVkIGRyaXZlcgpzdGF0ZSBsaWtlIGlubm8tPnBpeGNsb2NrLgoKWyAu Li4gXQo+ICtzdGF0aWMgaW50IHN0YXJmaXZlX2hkbWlfcGh5X3Bvd2VyX29uKHN0cnVjdCBwaHkg KnBoeSkKPiArewpbIC4uLiBdCj4gKwlpbm5vX3dyaXRlKGlubm8sIFNURl9JTk5PX1BPU1RfUExM X0RJVl8xLCByZWdfMWFhX3ZhbHVlKTsKPiArCj4gKwkvKiBXYWl0IGZvciBwb3N0IFBMTCBsb2Nr ICovCj4gKwlyZXQgPSBpbm5vX3BvbGwoaW5ubywgU1RGX0lOTk9fUE9TVF9QTExfTE9DS19TVEFU VVMsIHYsCj4gKwkJCXYgJiBTVEZfSU5OT19QT1NUX1BMTF9MT0NLLCAxMDAwLCAxMDAwMDApOwo+ ICsJaWYgKHJldCkgewo+ICsJCWRldl9lcnIoaW5uby0+ZGV2LCAiUG9zdC1QTEwgbG9ja2luZyBm YWlsZWRcbiIpOwo+ICsJCXJldHVybiByZXQ7Cj4gKwl9CgpbU2V2ZXJpdHk6IE1lZGl1bV0KQXJl IHRoZSBoYXJkd2FyZSBQSFkgcmVzb3VyY2VzIGxlZnQgcG93ZXJlZCBvbiBpZiB0aGUgUG9zdC1Q TEwgbG9jayB0aW1lcyBvdXQ/CgpJZiBpbm5vX3BvbGwoKSBmYWlscywgdGhlIGZ1bmN0aW9uIHJl dHVybnMgaW1tZWRpYXRlbHkuIFRoZSBQSFkgY29yZSBmcmFtZXdvcmsKZG9lcyBub3QgYXV0b21h dGljYWxseSBjYWxsIHRoZSBwb3dlcl9vZmYgY2FsbGJhY2sgaWYgdGhlIHBvd2VyX29uIGNhbGxi YWNrCmZhaWxzLCBiZWNhdXNlIHRoZSBwb3dlcl9jb3VudCByZW1haW5zIDAuCgpEb2VzIHRoaXMg ZXJyb3IgcGF0aCBuZWVkIHRvIGV4cGxpY2l0bHkgdW5kbyB0aGUgcmVnaXN0ZXIgd3JpdGVzIHRo YXQgZW5hYmxlZAp0aGUgQklBUywgUlgsIGFuZCBQb3N0LVBMTCBibG9ja3MgZWFybGllciBpbiB0 aGlzIGZ1bmN0aW9uPwoKWyAuLi4gXQo+ICtzdGF0aWMgaW50IHN0YXJmaXZlX2hkbWlfcGh5X3By b2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gK3sKWyAuLi4gXQo+ICsJcmV0ID0g Y2xrX3NldF9yYXRlKGlubm8tPnBoeWNsaywgMjk3MDAwMDAwKTsKPiArCWlmIChyZXQpIHsKPiAr CQlkZXZfZXJyKGRldiwgIkZhaWxlZCB0byBzZXQgZGVmYXVsdCByYXRlOiAlZFxuIiwgcmV0KTsK PiArCQlnb3RvIGVycl9kaXNhYmxlX3JlZm9jbGs7Cj4gKwl9ClsgLi4uIF0KPiArZXJyX2RlbF9j bGtfcHJvdmlkZXI6Cj4gKwlvZl9jbGtfZGVsX3Byb3ZpZGVyKGRldi0+b2Zfbm9kZSk7Cj4gK2Vy cl9kaXNhYmxlX3JlZm9jbGs6Cj4gKwljbGtfZGlzYWJsZV91bnByZXBhcmUoaW5uby0+cmVmb2Ns ayk7Cj4gKwlyZXR1cm4gcmV0Owo+ICt9CgpbU2V2ZXJpdHk6IEhpZ2hdCkRvZXMgdGhpcyBlcnJv ciBwYXRoIGxlYXZlIGEgZGFuZ2xpbmcgY2xvY2sgcHJvdmlkZXIgaW4gdGhlIGdsb2JhbCBsaXN0 PwoKSWYgY2xrX3NldF9yYXRlKCkgZmFpbHMsIHRoZSBjb2RlIGp1bXBzIHRvIGVycl9kaXNhYmxl X3JlZm9jbGssIGJ5cGFzc2luZwp0aGUgcmVxdWlyZWQgb2ZfY2xrX2RlbF9wcm92aWRlcigpIGNs ZWFudXAuIFRoZSBkZXZyZXMgZnJhbWV3b3JrIHdpbGwgdGhlbgp1bnJlZ2lzdGVyIGFuZCBmcmVl IGlubm8tPnBoeWNsaywgYnV0IHRoZSBkZXZpY2Ugbm9kZSB3aWxsIHJlbWFpbiBpbiB0aGUKc3lz dGVtLXdpZGUgb2ZfY2xrX3Byb3ZpZGVycyBsaXN0IHBvaW50aW5nIHRvIGZyZWVkIG1lbW9yeS4g QW55IHN1YnNlcXVlbnQKY2xvY2sgbG9va3VwIGNvdWxkIHRyaWdnZXIgYSB1c2UtYWZ0ZXItZnJl ZSBjcmFzaC4KCi0tIApTYXNoaWtvIEFJIHJldmlldyDCtyBodHRwczovL3Nhc2hpa28uZGV2LyMv cGF0Y2hzZXQvMjAyNjA4Mjgtamg3MTEwLWNsZWFuLXNlbmQtdjItMC0zMzE2ODBjOGI5ZDFAc2Ft c3VuZy5jb20/cGFydD0xMwoKLS0gCmxpbnV4LXBoeSBtYWlsaW5nIGxpc3QKbGludXgtcGh5QGxp c3RzLmluZnJhZGVhZC5vcmcKaHR0cHM6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vbGludXgtcGh5Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F199CC61DD3 for ; Fri, 28 Aug 2026 14:04:54 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 164C610F3C1; Fri, 28 Aug 2026 14:04:54 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="fr2CRQfu"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id 14F7510F3C1 for ; Fri, 28 Aug 2026 14:04:52 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 4B48C60200; Fri, 28 Aug 2026 14:04:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 66CAE1F00A3A; Fri, 28 Aug 2026 14:04:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787925891; bh=BEf7wsmWGyjenIb5dVc/Hd41acSlqCKQek2mD9YF+6s=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=fr2CRQfurqqiCNqIcuSDQwpRQGwS2JdQ+mp2F+gah+FXcTH19fHXsFzsqQP4j3i66 sNhQmiPOiqY9s7nQRbZyoLniHnm/6mXtwgn4cPKu6BZOerLV/25RPiztz84yrSloDJ b2ogDKPObTvlc9B/DO501n0eD/5MSOJeKGlnbfC9wmxD8P8Gxh/FhdOudZWCx5fTLJ hojEvulsRR7U1HUnulRjSTyBJ4rTBHhNGMemDnzJCSi5BmHTgU0KIwGu32CKQFHhkP DLGC3aBAgKRdlctj+5Cy0mwDheddQrLzUXECfu0oCy3EOQmm6TFcR7NNS8xB7Dh+5/ qqSFf5yRuE0XQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 13/15] phy: starfive: Add jh7110-inno-hdmi-phy driver To: "Michal Wilczynski" Cc: mfd@lists.linux.dev, linux-phy@lists.infradead.org, neil.armstrong@linaro.org, linux-clk@vger.kernel.org, conor+dt@kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, lee@kernel.org, olteanv@gmail.com, vkoul@kernel.org, robh@kernel.org In-Reply-To: <20260828-jh7110-clean-send-v2-13-331680c8b9d1@samsung.com> References: <20260828-jh7110-clean-send-v2-0-331680c8b9d1@samsung.com> <20260828-jh7110-clean-send-v2-13-331680c8b9d1@samsung.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 28 Aug 2026 14:04:49 +0000 Message-Id: <20260828140450.66CAE1F00A3A@smtp.kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Thank you for your contribution! Sashiko AI review found 3 potential issue(= s) to consider: - [High] Missing cleanup on the clk_set_rate error path in probe leaves a d= angling clock provider. - [High] Clock operations incorrectly modify analog PHY state without synch= ronization, risking state corruption and power leaks. - [Medium] Hardware PHY resources are left powered on if starfive_hdmi_phy_= power_on() fails. -- commit 7c46f9e86f09391b8c542e940da1457e36661874 Author: Michal Wilczynski phy: starfive: Add jh7110-inno-hdmi-phy driver This commit adds the HDMI PHY driver for the StarFive JH7110. It provides the variable pixel clock from the Pre-PLL and the PHY operations for the Post-PLL and analog blocks. > diff --git a/drivers/phy/starfive/phy-jh7110-inno-hdmi.c b/drivers/phy/st= arfive/phy-jh7110-inno-hdmi.c > new file mode 100644 > --- /dev/null > +++ b/drivers/phy/starfive/phy-jh7110-inno-hdmi.c [ ... ] > +static int starfive_hdmi_phy_clk_set_rate(struct clk_hw *hw, unsigned lo= ng rate, > + unsigned long parent_rate) > +{ [ ... ] > + if (inno->pixclock =3D=3D rate && inno->tmdsclock =3D=3D cfg->tmdsclock) > + return 0; > + > + inno_update_bits(inno, STF_INNO_BIAS_CONTROL, > + STF_INNO_BIAS_ENABLE, STF_INNO_BIAS_ENABLE); > + inno_write(inno, STF_INNO_RX_CONTROL, STF_INNO_RX_ENABLE); [Severity: High] Does this incorrectly modify analog PHY state during clock operations? Since clk_set_rate() is unconditionally called during starfive_hdmi_phy_pro= be(), these analog blocks are powered on immediately at boot, which could cause a permanent power leak until the power_off callback happens to be called. Furthermore, do these state modifications race with the PHY callbacks? The common clock framework callbacks execute under the CCF prepare_lock, while = PHY callbacks execute under the phy->mutex lock. A concurrent clk_set_rate() and starfive_hdmi_phy_power_on() could race on hardware registers and shared dr= iver state like inno->pixclock. [ ... ] > +static int starfive_hdmi_phy_power_on(struct phy *phy) > +{ [ ... ] > + inno_write(inno, STF_INNO_POST_PLL_DIV_1, reg_1aa_value); > + > + /* Wait for post PLL lock */ > + ret =3D inno_poll(inno, STF_INNO_POST_PLL_LOCK_STATUS, v, > + v & STF_INNO_POST_PLL_LOCK, 1000, 100000); > + if (ret) { > + dev_err(inno->dev, "Post-PLL locking failed\n"); > + return ret; > + } [Severity: Medium] Are the hardware PHY resources left powered on if the Post-PLL lock times o= ut? If inno_poll() fails, the function returns immediately. The PHY core framew= ork does not automatically call the power_off callback if the power_on callback fails, because the power_count remains 0. Does this error path need to explicitly undo the register writes that enabl= ed the BIAS, RX, and Post-PLL blocks earlier in this function? [ ... ] > +static int starfive_hdmi_phy_probe(struct platform_device *pdev) > +{ [ ... ] > + ret =3D clk_set_rate(inno->phyclk, 297000000); > + if (ret) { > + dev_err(dev, "Failed to set default rate: %d\n", ret); > + goto err_disable_refoclk; > + } [ ... ] > +err_del_clk_provider: > + of_clk_del_provider(dev->of_node); > +err_disable_refoclk: > + clk_disable_unprepare(inno->refoclk); > + return ret; > +} [Severity: High] Does this error path leave a dangling clock provider in the global list? If clk_set_rate() fails, the code jumps to err_disable_refoclk, bypassing the required of_clk_del_provider() cleanup. The devres framework will then unregister and free inno->phyclk, but the device node will remain in the system-wide of_clk_providers list pointing to freed memory. Any subsequent clock lookup could trigger a use-after-free crash. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260828-jh7110-cle= an-send-v2-0-331680c8b9d1@samsung.com?part=3D13