From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AF2245C6F7; Fri, 28 Aug 2026 14:12:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787926381; cv=none; b=tiJG1dUJJ2Qcmh6TpJWoF1F84RmU+ojRJEHpkL6OxWjBRC4eI7hxZt2nn3/jkQ3LneGxTxA7IntvFfyFho76lxDeO2vXDTo5GpMzKlFAgDo/wiuT8t6w8y2wSZeMvVXV2FwWWmrFeJZESRa7QmDZLaxWoL5lRGF19Le0w2YDpXM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787926381; c=relaxed/simple; bh=gkbDRMk7nwXfJgndT++gv8hrcXL4qTRLGpNmUZu2py4=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=dMromaYSBZ6lJFLxIRXVFGHqYKAQ53z3oeenBCPeF4v6tyJ97sZ9OhUYXJogxYsrhKtetCiVOFf8N6EobitDnzujeHj6NdxQM4Fo2Z5zfkwElxYnx7iNrz/EWnTGzMr27deNqsN4sukbqiyxrgP1Aju4HOuyQtI7s2rx/xJv2l4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bi6hHuRE; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bi6hHuRE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2BE9A1F000E9; Fri, 28 Aug 2026 14:12:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787926374; bh=aM8XEFJ0qJZcpu0Sj/0mV5jOXotIxwuMFgdJBSFfZxU=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=bi6hHuREj6ut9QnGiNpns5g233BYEFbLt820Lwad5fg0Jy0i/npLfrm29W3f+Ul3c 9SyjkY7e3r8JZwcxx3M232iLVWUXckZ+diHlf5ocD0+qYQC4U0Tb3aBtPPSqvJuTBX kand2TtcuwEnvCjdIxGbHYvnecQsOO920tsjFDQHPebnoa90Ras4kjZWPO7o7zMuvV Dr8rIZKgfdzbGy6XvIK/LxEBCgTQ/w08csQEB4QngvhnUpBrTH8vopUgKC2aQNwQmG vNSbUSg1SeHYeUS/gaKPitt0WVoRdf3tvUmSnGqxpzcKfkWp1B3J3mPrrp/1SULGEG 4NLUBjfgOXykg== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 12/15] phy: rockchip: inno-hdmi: Use the common Innosilicon PHY helpers Reply-To: sashiko-reviews@lists.linux.dev To: "Michal Wilczynski" Cc: lee@kernel.org, conor+dt@kernel.org, olteanv@gmail.com, vkoul@kernel.org, mfd@lists.linux.dev, linux-clk@vger.kernel.org, robh@kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, neil.armstrong@linaro.org, linux-phy@lists.infradead.org In-Reply-To: <20260828-jh7110-clean-send-v2-12-331680c8b9d1@samsung.com> References: <20260828-jh7110-clean-send-v2-0-331680c8b9d1@samsung.com> <20260828-jh7110-clean-send-v2-12-331680c8b9d1@samsung.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 28 Aug 2026 14:12:53 +0000 Message-Id: <20260828141254.2BE9A1F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: mfd@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 2 potential issue(= s) to consider: Pre-existing issues: - [High] Kernel panic or division-by-zero exception due to division by zero= in clock rate recalculation if hardware registers are uninitialized or zer= oed. - [High] Multiplication of unsigned long values silently overflows on 32-bi= t architectures before assignment to a 64-bit variable in VCO rate calculat= ion. -- commit 65afb8fac5b8b08e9749e00354df9fbca4121dd2 Author: Michal Wilczynski phy: rockchip: inno-hdmi: Use the common Innosilicon PHY helpers This commit replaces the local RK3328 pre-PLL implementations for calculati= ng and setting rates with the generic shared Innosilicon helpers. It keeps the RK3228 register-level code separate due to different register addresses but shares the table lookup. > diff --git a/drivers/phy/rockchip/phy-rockchip-inno-hdmi.c b/drivers/phy/= rockchip/phy-rockchip-inno-hdmi.c > index 1483907413faa..fae766607b0ea 100644 > --- a/drivers/phy/rockchip/phy-rockchip-inno-hdmi.c > +++ b/drivers/phy/rockchip/phy-rockchip-inno-hdmi.c [ ... ] > @@ -870,39 +850,11 @@ unsigned long inno_hdmi_phy_rk3328_clk_recalc_rate(= struct clk_hw *hw, > unsigned long parent_rate) > { > struct inno_hdmi_phy *inno =3D to_inno_hdmi_phy(hw); [ ... ] > + inno->pixclock =3D inno_hdmi_phy_pre_pll_recalc_rate(&inno->pre_pll, > + parent_rate); [Severity: High] This is a pre-existing issue, but since we are switching to the shared help= er inno_hdmi_phy_pre_pll_recalc_rate(), can this code cause a division by zero? If the bootloader has not initialized the PHY, the hardware registers may contain their default 0 values. When the clock framework calls recalc_rate during registration at boot, would the following logic in the helper result= in a division by zero: drivers/phy/phy-inno-hdmi.c:inno_hdmi_phy_pre_pll_recalc_rate() { ... nd =3D inno_read(pll, INNO_PRE_PLL_DIV_1) & INNO_PRE_PLL_PRE_DIV_MASK; ... if (inno_read(pll, INNO_PRE_PLL_CONTROL) & INNO_PCLK_VCO_DIV_5_MASK) { do_div(vco, nd * 5); } else { no_a =3D inno_read(pll, INNO_PCLK_DIV_AB) & INNO_PCLK_DIV_A_MASK; no_b =3D FIELD_GET(INNO_PCLK_DIV_B_MASK, inno_read(pll, INNO_PCLK_DIV_AB)) + 2; no_d =3D inno_read(pll, INNO_PCLK_DIV_CD) & INNO_PCLK_DIV_D_MASK; do_div(vco, nd * (no_a =3D=3D 1 ? no_b : no_a) * no_d * 2); } ... } If nd, no_a, or no_d evaluate to 0, the denominator becomes 0, which could lead to a kernel panic or exception on some architectures. [Severity: High] This isn't a bug introduced by this patch, but does the rate recalculation silently overflow on 32-bit architectures? Inside the same helper, the VCO rate is calculated as: drivers/phy/phy-inno-hdmi.c:inno_hdmi_phy_pre_pll_recalc_rate() { ... vco =3D parent_rate * nf; if (!(inno_read(pll, INNO_PRE_PLL_DIV_2) & INNO_PRE_PLL_FRAC_DIV_DISABLE)) { frac =3D inno_read(pll, INNO_PRE_PLL_FRAC_DIV_7_0) | (inno_read(pll, INNO_PRE_PLL_FRAC_DIV_15_8) << 8) | (inno_read(pll, INNO_PRE_PLL_FRAC_DIV_23_16) << 16); vco +=3D DIV_ROUND_CLOSEST(parent_rate * frac, BIT(INNO_FRAC_DIV_WIDTH)); } ... } The parent_rate is typically 24,000,000, while nf can be up to 757 and frac up to ~14.6 million. Since parent_rate is an unsigned long and nf is a u16, the multiplication is performed as 32-bit unsigned math on 32-bit platforms (like RK3228 which uses ARM32). Would parent_rate * nf and parent_rate * frac wrap around ULONG_MAX before being assigned to the 64-bit vco variable or before the division in DIV_ROUND_CLOSEST? > =20 > - inno->pixclock =3D DIV_ROUND_CLOSEST((unsigned long)vco, 1000) * 1000; > - > - dev_dbg(inno->dev, "%s rate %lu vco %llu\n", > - __func__, inno->pixclock, vco); > + dev_dbg(inno->dev, "%s rate %lu\n", __func__, inno->pixclock); > =20 > return inno->pixclock; > } --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260828-jh7110-cle= an-send-v2-0-331680c8b9d1@samsung.com?part=3D12 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48B1FC61DBD for ; Fri, 28 Aug 2026 14:12:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ma4EQp3dvV8hQmh18OXNjrJJn3IXoLartrAzr7Ggo3M=; b=turcJhrTDvIqP1 p5Zl1py70dJomJnRYfPXuTOm4ZCjouaO8LfFViGcSzhsCYBgNOzOio+3K12bH+ikZzHkaYCnOaj1J cQZx80qsmnGVN07nzNAwe3VyDJN7MB4RT/YexMgkJ3tgLPV+9UhCP20yrFWdr9lgMOHASOBfY0nfm o3N+ztnHHmT2W6fjcLC0X8q/Wvpga2IWVIZesAFVaSvSuvtlUX5OY9sCQc/Kve9T60UeqeXBS1eM/ XuwK6KNCEh2Jk/JOqabJa25yTFn48RRe/AlmrBZL5ViSQu7aLRSMVUNV94nzIHxvuTzqEoNBVBPlR RKSQKa2w+wnjryuIzMsg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wzxKC-00000005xIi-00tj; Fri, 28 Aug 2026 14:12:56 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wzxKB-00000005xIY-0vSy for linux-phy@lists.infradead.org; Fri, 28 Aug 2026 14:12:55 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id DA9E040167; Fri, 28 Aug 2026 14:12:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2BE9A1F000E9; Fri, 28 Aug 2026 14:12:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787926374; bh=aM8XEFJ0qJZcpu0Sj/0mV5jOXotIxwuMFgdJBSFfZxU=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=bi6hHuREj6ut9QnGiNpns5g233BYEFbLt820Lwad5fg0Jy0i/npLfrm29W3f+Ul3c 9SyjkY7e3r8JZwcxx3M232iLVWUXckZ+diHlf5ocD0+qYQC4U0Tb3aBtPPSqvJuTBX kand2TtcuwEnvCjdIxGbHYvnecQsOO920tsjFDQHPebnoa90Ras4kjZWPO7o7zMuvV Dr8rIZKgfdzbGy6XvIK/LxEBCgTQ/w08csQEB4QngvhnUpBrTH8vopUgKC2aQNwQmG vNSbUSg1SeHYeUS/gaKPitt0WVoRdf3tvUmSnGqxpzcKfkWp1B3J3mPrrp/1SULGEG 4NLUBjfgOXykg== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 12/15] phy: rockchip: inno-hdmi: Use the common Innosilicon PHY helpers To: "Michal Wilczynski" Cc: lee@kernel.org, conor+dt@kernel.org, olteanv@gmail.com, vkoul@kernel.org, mfd@lists.linux.dev, linux-clk@vger.kernel.org, robh@kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, neil.armstrong@linaro.org, linux-phy@lists.infradead.org In-Reply-To: <20260828-jh7110-clean-send-v2-12-331680c8b9d1@samsung.com> References: <20260828-jh7110-clean-send-v2-0-331680c8b9d1@samsung.com> <20260828-jh7110-clean-send-v2-12-331680c8b9d1@samsung.com> Date: Fri, 28 Aug 2026 14:12:53 +0000 Message-Id: <20260828141254.2BE9A1F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MiBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6CgpQcmUtZXhpc3RpbmcgaXNzdWVzOgot IFtIaWdoXSBLZXJuZWwgcGFuaWMgb3IgZGl2aXNpb24tYnktemVybyBleGNlcHRpb24gZHVlIHRv IGRpdmlzaW9uIGJ5IHplcm8gaW4gY2xvY2sgcmF0ZSByZWNhbGN1bGF0aW9uIGlmIGhhcmR3YXJl IHJlZ2lzdGVycyBhcmUgdW5pbml0aWFsaXplZCBvciB6ZXJvZWQuCi0gW0hpZ2hdIE11bHRpcGxp Y2F0aW9uIG9mIHVuc2lnbmVkIGxvbmcgdmFsdWVzIHNpbGVudGx5IG92ZXJmbG93cyBvbiAzMi1i aXQgYXJjaGl0ZWN0dXJlcyBiZWZvcmUgYXNzaWdubWVudCB0byBhIDY0LWJpdCB2YXJpYWJsZSBp biBWQ08gcmF0ZSBjYWxjdWxhdGlvbi4KLS0KCmNvbW1pdCA2NWFmYjhmYWM1YjhiMDhlOTc0OWUw MDM1NGRmOWZiY2E0MTIxZGQyCkF1dGhvcjogTWljaGFsIFdpbGN6eW5za2kgPG0ud2lsY3p5bnNr aUBzYW1zdW5nLmNvbT4KCnBoeTogcm9ja2NoaXA6IGlubm8taGRtaTogVXNlIHRoZSBjb21tb24g SW5ub3NpbGljb24gUEhZIGhlbHBlcnMKClRoaXMgY29tbWl0IHJlcGxhY2VzIHRoZSBsb2NhbCBS SzMzMjggcHJlLVBMTCBpbXBsZW1lbnRhdGlvbnMgZm9yIGNhbGN1bGF0aW5nCmFuZCBzZXR0aW5n IHJhdGVzIHdpdGggdGhlIGdlbmVyaWMgc2hhcmVkIElubm9zaWxpY29uIGhlbHBlcnMuIEl0IGtl ZXBzIHRoZQpSSzMyMjggcmVnaXN0ZXItbGV2ZWwgY29kZSBzZXBhcmF0ZSBkdWUgdG8gZGlmZmVy ZW50IHJlZ2lzdGVyIGFkZHJlc3NlcyBidXQKc2hhcmVzIHRoZSB0YWJsZSBsb29rdXAuCgo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL3BoeS9yb2NrY2hpcC9waHktcm9ja2NoaXAtaW5uby1oZG1pLmMg Yi9kcml2ZXJzL3BoeS9yb2NrY2hpcC9waHktcm9ja2NoaXAtaW5uby1oZG1pLmMKPiBpbmRleCAx NDgzOTA3NDEzZmFhLi5mYWU3NjY2MDdiMGVhIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvcGh5L3Jv Y2tjaGlwL3BoeS1yb2NrY2hpcC1pbm5vLWhkbWkuYwo+ICsrKyBiL2RyaXZlcnMvcGh5L3JvY2tj aGlwL3BoeS1yb2NrY2hpcC1pbm5vLWhkbWkuYwpbIC4uLiBdCj4gQEAgLTg3MCwzOSArODUwLDEx IEBAIHVuc2lnbmVkIGxvbmcgaW5ub19oZG1pX3BoeV9yazMzMjhfY2xrX3JlY2FsY19yYXRlKHN0 cnVjdCBjbGtfaHcgKmh3LAo+ICAJCQkJCQkgICB1bnNpZ25lZCBsb25nIHBhcmVudF9yYXRlKQo+ ICB7Cj4gIAlzdHJ1Y3QgaW5ub19oZG1pX3BoeSAqaW5ubyA9IHRvX2lubm9faGRtaV9waHkoaHcp OwpbIC4uLiBdCj4gKwlpbm5vLT5waXhjbG9jayA9IGlubm9faGRtaV9waHlfcHJlX3BsbF9yZWNh bGNfcmF0ZSgmaW5uby0+cHJlX3BsbCwKPiArCQkJCQkJCSAgIHBhcmVudF9yYXRlKTsKCltTZXZl cml0eTogSGlnaF0KVGhpcyBpcyBhIHByZS1leGlzdGluZyBpc3N1ZSwgYnV0IHNpbmNlIHdlIGFy ZSBzd2l0Y2hpbmcgdG8gdGhlIHNoYXJlZCBoZWxwZXIKaW5ub19oZG1pX3BoeV9wcmVfcGxsX3Jl Y2FsY19yYXRlKCksIGNhbiB0aGlzIGNvZGUgY2F1c2UgYSBkaXZpc2lvbiBieSB6ZXJvPwoKSWYg dGhlIGJvb3Rsb2FkZXIgaGFzIG5vdCBpbml0aWFsaXplZCB0aGUgUEhZLCB0aGUgaGFyZHdhcmUg cmVnaXN0ZXJzIG1heQpjb250YWluIHRoZWlyIGRlZmF1bHQgMCB2YWx1ZXMuIFdoZW4gdGhlIGNs b2NrIGZyYW1ld29yayBjYWxscyByZWNhbGNfcmF0ZQpkdXJpbmcgcmVnaXN0cmF0aW9uIGF0IGJv b3QsIHdvdWxkIHRoZSBmb2xsb3dpbmcgbG9naWMgaW4gdGhlIGhlbHBlciByZXN1bHQgaW4KYSBk aXZpc2lvbiBieSB6ZXJvOgoKZHJpdmVycy9waHkvcGh5LWlubm8taGRtaS5jOmlubm9faGRtaV9w aHlfcHJlX3BsbF9yZWNhbGNfcmF0ZSgpIHsKICAgIC4uLgoJbmQgPSBpbm5vX3JlYWQocGxsLCBJ Tk5PX1BSRV9QTExfRElWXzEpICYgSU5OT19QUkVfUExMX1BSRV9ESVZfTUFTSzsKICAgIC4uLgoJ aWYgKGlubm9fcmVhZChwbGwsIElOTk9fUFJFX1BMTF9DT05UUk9MKSAmIElOTk9fUENMS19WQ09f RElWXzVfTUFTSykgewoJCWRvX2Rpdih2Y28sIG5kICogNSk7Cgl9IGVsc2UgewoJCW5vX2EgPSBp bm5vX3JlYWQocGxsLCBJTk5PX1BDTEtfRElWX0FCKSAmIElOTk9fUENMS19ESVZfQV9NQVNLOwoJ CW5vX2IgPSBGSUVMRF9HRVQoSU5OT19QQ0xLX0RJVl9CX01BU0ssCgkJCQkgaW5ub19yZWFkKHBs bCwgSU5OT19QQ0xLX0RJVl9BQikpICsgMjsKCQlub19kID0gaW5ub19yZWFkKHBsbCwgSU5OT19Q Q0xLX0RJVl9DRCkgJiBJTk5PX1BDTEtfRElWX0RfTUFTSzsKCgkJZG9fZGl2KHZjbywgbmQgKiAo bm9fYSA9PSAxID8gbm9fYiA6IG5vX2EpICogbm9fZCAqIDIpOwoJfQogICAgLi4uCn0KCklmIG5k LCBub19hLCBvciBub19kIGV2YWx1YXRlIHRvIDAsIHRoZSBkZW5vbWluYXRvciBiZWNvbWVzIDAs IHdoaWNoIGNvdWxkCmxlYWQgdG8gYSBrZXJuZWwgcGFuaWMgb3IgZXhjZXB0aW9uIG9uIHNvbWUg YXJjaGl0ZWN0dXJlcy4KCltTZXZlcml0eTogSGlnaF0KVGhpcyBpc24ndCBhIGJ1ZyBpbnRyb2R1 Y2VkIGJ5IHRoaXMgcGF0Y2gsIGJ1dCBkb2VzIHRoZSByYXRlIHJlY2FsY3VsYXRpb24Kc2lsZW50 bHkgb3ZlcmZsb3cgb24gMzItYml0IGFyY2hpdGVjdHVyZXM/CgpJbnNpZGUgdGhlIHNhbWUgaGVs cGVyLCB0aGUgVkNPIHJhdGUgaXMgY2FsY3VsYXRlZCBhczoKCmRyaXZlcnMvcGh5L3BoeS1pbm5v LWhkbWkuYzppbm5vX2hkbWlfcGh5X3ByZV9wbGxfcmVjYWxjX3JhdGUoKSB7CiAgICAuLi4KCXZj byA9IHBhcmVudF9yYXRlICogbmY7CgoJaWYgKCEoaW5ub19yZWFkKHBsbCwgSU5OT19QUkVfUExM X0RJVl8yKSAmCgkgICAgICBJTk5PX1BSRV9QTExfRlJBQ19ESVZfRElTQUJMRSkpIHsKCQlmcmFj ID0gaW5ub19yZWFkKHBsbCwgSU5OT19QUkVfUExMX0ZSQUNfRElWXzdfMCkgfAoJCSAgICAgICAo aW5ub19yZWFkKHBsbCwgSU5OT19QUkVfUExMX0ZSQUNfRElWXzE1XzgpIDw8IDgpIHwKCQkgICAg ICAgKGlubm9fcmVhZChwbGwsIElOTk9fUFJFX1BMTF9GUkFDX0RJVl8yM18xNikgPDwgMTYpOwoJ CXZjbyArPSBESVZfUk9VTkRfQ0xPU0VTVChwYXJlbnRfcmF0ZSAqIGZyYWMsCgkJCQkJIEJJVChJ Tk5PX0ZSQUNfRElWX1dJRFRIKSk7Cgl9CiAgICAuLi4KfQoKVGhlIHBhcmVudF9yYXRlIGlzIHR5 cGljYWxseSAyNCwwMDAsMDAwLCB3aGlsZSBuZiBjYW4gYmUgdXAgdG8gNzU3IGFuZApmcmFjIHVw IHRvIH4xNC42IG1pbGxpb24uIFNpbmNlIHBhcmVudF9yYXRlIGlzIGFuIHVuc2lnbmVkIGxvbmcg YW5kIG5mIGlzIGEKdTE2LCB0aGUgbXVsdGlwbGljYXRpb24gaXMgcGVyZm9ybWVkIGFzIDMyLWJp dCB1bnNpZ25lZCBtYXRoIG9uIDMyLWJpdApwbGF0Zm9ybXMgKGxpa2UgUkszMjI4IHdoaWNoIHVz ZXMgQVJNMzIpLgoKV291bGQgcGFyZW50X3JhdGUgKiBuZiBhbmQgcGFyZW50X3JhdGUgKiBmcmFj IHdyYXAgYXJvdW5kIFVMT05HX01BWCBiZWZvcmUKYmVpbmcgYXNzaWduZWQgdG8gdGhlIDY0LWJp dCB2Y28gdmFyaWFibGUgb3IgYmVmb3JlIHRoZSBkaXZpc2lvbiBpbgpESVZfUk9VTkRfQ0xPU0VT VD8KCj4gIAo+IC0JaW5uby0+cGl4Y2xvY2sgPSBESVZfUk9VTkRfQ0xPU0VTVCgodW5zaWduZWQg bG9uZyl2Y28sIDEwMDApICogMTAwMDsKPiAtCj4gLQlkZXZfZGJnKGlubm8tPmRldiwgIiVzIHJh dGUgJWx1IHZjbyAlbGx1XG4iLAo+IC0JCV9fZnVuY19fLCBpbm5vLT5waXhjbG9jaywgdmNvKTsK PiArCWRldl9kYmcoaW5uby0+ZGV2LCAiJXMgcmF0ZSAlbHVcbiIsIF9fZnVuY19fLCBpbm5vLT5w aXhjbG9jayk7Cj4gIAo+ICAJcmV0dXJuIGlubm8tPnBpeGNsb2NrOwo+ICB9CgotLSAKU2FzaGlr byBBSSByZXZpZXcgwrcgaHR0cHM6Ly9zYXNoaWtvLmRldi8jL3BhdGNoc2V0LzIwMjYwODI4LWpo NzExMC1jbGVhbi1zZW5kLXYyLTAtMzMxNjgwYzhiOWQxQHNhbXN1bmcuY29tP3BhcnQ9MTIKCi0t IApsaW51eC1waHkgbWFpbGluZyBsaXN0CmxpbnV4LXBoeUBsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHBzOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXBoeQo=