From: sashiko-bot@kernel.org
To: "Marek Vasut" <marex@nabladev.com>
Cc: robh@kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: usb: generic-ehci: Document ST STM32MP1 SoC compatibles
Date: Fri, 28 Aug 2026 15:26:06 +0000 [thread overview]
Message-ID: <20260828152606.B0B271F00A3D@smtp.kernel.org> (raw)
In-Reply-To: <20260828152130.176171-1-marex@nabladev.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incomplete binding update: missing matching SoC compatibles for OHCI
--
commit 7095875c29b62fc4da25d15360437f36863e8a6a
Author: Marek Vasut <marex@nabladev.com>
dt-bindings: usb: generic-ehci: Document ST STM32MP1 SoC compatibles
This commit documents SoC-specific compatibles for the ST STM32MP13xx and
STM32MP15xx series in the generic-ehci binding. This provides a more
accurate compatible string for the SoC DTSI than the plain "generic-ehci"
fallback.
> diff --git a/Documentation/devicetree/bindings/usb/generic-ehci.yaml b/Documentation/devicetree/bindings/usb/generic-ehci.yaml
> index 55a5aa7d7a54e..a88aa1e1ee59c 100644
> --- a/Documentation/devicetree/bindings/usb/generic-ehci.yaml
> +++ b/Documentation/devicetree/bindings/usb/generic-ehci.yaml
> @@ -55,6 +55,8 @@ properties:
> - rockchip,rk3588-ehci
> - snps,hsdk-v1.0-ehci
> - socionext,uniphier-ehci
> + - st,stm32mp13-ehci
> + - st,stm32mp15-ehci
> - const: generic-ehci
[Severity: Medium]
Since the STM32MP13xx and STM32MP15xx hardware includes both EHCI and OHCI
controllers in a companion setup, should a matching update be made to
Documentation/devicetree/bindings/usb/generic-ohci.yaml?
Currently, generic-ohci.yaml has an equivalent list of SoC-specific OHCI
compatibles:
- ingenic,jz4740-ohci
- rockchip,rk3588-ohci
- snps,hsdk-v1.0-ohci
- const: generic-ohci
Without adding the corresponding ST compatible strings to generic-ohci.yaml,
the OHCI controller remains documented only as "generic-ohci", which leaves
it not future proof in the same way generic-ehci was prior to this change.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260828152130.176171-1-marex@nabladev.com?part=1
next prev parent reply other threads:[~2026-08-28 15:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-28 15:21 [PATCH v2 1/3] dt-bindings: usb: generic-ehci: Document ST STM32MP1 SoC compatibles Marek Vasut
2026-08-28 15:21 ` [PATCH v2 2/3] ARM: dts: stm32: Use STM32MP13xx compatible string for EHCI USB controller Marek Vasut
2026-08-28 15:21 ` [PATCH v2 3/3] ARM: dts: stm32: Use STM32MP15xx " Marek Vasut
2026-08-28 15:26 ` sashiko-bot [this message]
2026-08-28 15:51 ` [PATCH v2 1/3] dt-bindings: usb: generic-ehci: Document ST STM32MP1 SoC compatibles Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260828152606.B0B271F00A3D@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=marex@nabladev.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.