Re: [PATCH v4 1/2] dt-bindings: arm: stm32: Document st,stm32mp23/25-syscfg subnodes and cells

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] The conditional `if` block for `st,stm32mp23-syscfg` and `st,stm32mp25-syscfg` uses `enum` directly instead of `contains: enum`, which fails to match the array-typed `compatible` property and bypasses validation.
- [Medium] The schema examples section does not include a demonstration of the newly required properties and subnodes, leaving the new variant untested.
--

commit 756e633a3636918c549af9224be89571f86da4e0
Author: Marek Vasut <marex@nabladev.com>
Subject: dt-bindings: arm: stm32: Document st,stm32mp23/25-syscfg subnodes and cells

The st,stm32mp23-syscfg and st,stm32mp25-syscfg can have subnodes, which
represent the USB 2.0 FEMTO-PHY. Document subnodes pattern properties and
address/size cells.

> diff --git a/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml b/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml
> index 95d2319afe235..d82afa39960b9 100644
> --- a/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml
> +++ b/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml

[ ... ]

> @@ -57,10 +68,14 @@ allOf:
>    - if:
>        properties:
>          compatible:
> -          const: st,stm32mp25-syscfg
> +          enum:
> +            - st,stm32mp23-syscfg
> +            - st,stm32mp25-syscfg

[Severity: High]
Does checking the array-typed compatible property directly against enum fail
to match here?

Since the compatible property is defined globally as an array (e.g.,
["st,stm32mp25-syscfg", "syscon"]), wouldn't evaluating it against a string
enum evaluate to false and completely bypass the validation constraints?

Should this use contains: enum instead?

>      then:
>        required:
>          - "#clock-cells"
> +        - "#address-cells"
> +        - "#size-cells"

[Severity: Medium]
Do the newly authored constraints and phy subnode need to be added to the
examples section?

Currently, the examples only cover the older st,stm32mp157-syscfg variant.
Does this mean the new requirements for mp23/mp25 aren't validated when
running make dt_binding_check?

>  
>  additionalProperties: false
>

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260828151216.175020-1-marex@nabladev.com?part=1