Re: [PATCH v4 1/2] dt-bindings: usb: dwc3: Document ST STM32MP2 DWC3 xHCI USB controller

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Introduction of an un-prefixed, undocumented generic property `over-current-active-low`.
--

commit 5c70b019c9a119b961b9928eb41cf7a19bb476a6
Author: Marek Vasut <marex@nabladev.com>

dt-bindings: usb: dwc3: Document ST STM32MP2 DWC3 xHCI USB controller

This commit documents the ST STM32MP2 SoC single instance of the DWC3 USB
controller. It details the glue logic wrapper controlled by syscon along
with the controller itself.

> diff --git a/Documentation/devicetree/bindings/usb/st,stm32mp25-dwc3.yaml b/Documentation/devicetree/bindings/usb/st,stm32mp25-dwc3.yaml
> new file mode 100644
> index 0000000000000..96bd557327252
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/st,stm32mp25-dwc3.yaml
[ ... ]
> +  interrupts:
> +    maxItems: 1
> +
> +  resets:
> +    maxItems: 1
> +
> +  over-current-active-low:
> +    type: boolean
> +    description: Over-Current signal polarity is active-low

[Severity: Low]
Should this property include a vendor prefix?

Since this property is defined locally rather than inheriting from a common
core USB schema, introducing over-current-active-low as a generic un-prefixed
property could violate devicetree naming conventions for custom properties. 

Would it be safer to prefix this, such as st,over-current-active-low, to
prevent namespace pollution and avoid conflicts if the subsystem later
standardizes a property with the identical name but different semantics?

> +
> +  st,syscfg:
> +    $ref: /schemas/types.yaml#/definitions/phandle-array
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260828150937.174735-1-marex@nabladev.com?part=1